New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736703 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression

Blocked on:
issue skia:6814

Blocking:
issue pdfium:11



Sign in to add a comment

Regression:English translation of content doesn't appear properly after loading the page on Mac OS.

Reported by vku...@etouch.net, Jun 26 2017

Issue description

Chrome Version: 61.0.3141.0 (Official Build) Revision	180095eb1bca7df1cdcb02547340499c2ee3af6e-refs/heads/master@{#482153} (32/64-bit)
OS:Windows(7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LTS)

What steps will reproduce the problem?
(1)Launch chrome and navigate to http://www.stepupnihongo.com/images/SUN3_L-51.pdf
(2)Scroll down the page and observe the content of page


Actual: English translation of content doesn't appear properly after loading the page.

Expected: English translation of content should be properly displayed.

This is a regression issue broken in 'M61' and below is the manual regression range
Good Build: 61.0.3138.0 
Bad Build:  61.0.3140.0 
 
Actual_Result.mov
3.9 MB Download
Expected_Result.mov
3.1 MB Download

Comment 1 by vku...@etouch.net, Jun 26 2017

Labels: -OS-Linux -OS-Windows
Summary: Regression:English translation of content doesn't appear properly after loading the page on Mac OS. (was: Regression:English translation of content doesn't appear properly after loading the page.)
NOTE:
On Windows & Linux OS after navigating to http://www.stepupnihongo.com/images/SUN3_L-51.pdf
-Font size is not properly displayed(i.e overlapping of text/alphabet is seen)

Please refer attached actual & expected screenshot 
Actual_Win.png
321 KB View Download
Expected_Win.png
359 KB View Download
Cc: gov...@chromium.org ligim...@chromium.org
Labels: ReleaseBlock-Dev
Owner: dsinclair@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue and below are the bisect details obtained using per-revision bisect:

You are probably looking for a change made after 481560 (known good), but no later than 481561 (first known bad).
CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/a95e0bf52bfe99622e4bf498adb761cf9eb218a9..1545ba94087279c773705760d51b728d709fd72d

@dsinclair: Assigning to you, kindly take a look into it Please help us to find an owner if not with respect to your change.

Adding Blocker label, please decrease or remove priority if not the case.

Thanks.!
Labels: hasbisect-per-revision
Blocking: pdfium:11
Cc: dsinclair@chromium.org
Owner: caryclark@chromium.org
Looks like it picked a different font to use when rendering. Given the regression CL probably due to switching on Skia paths rendering.

Comment 5 by npm@chromium.org, Jun 26 2017

Labels: -ReleaseBlock-Dev OS-Linux OS-Windows
This is a recent regression but it also happens to be broken in Stable so ReleaseBlock-Dev is not appropriate even if we hand't already disabled Skia paths. FYI this suggests my spacing CL [1] does not seem to be working properly when Skia paths is  enabled.
[1] https://pdfium-review.googlesource.com/c/6630/

Comment 6 by npm@chromium.org, Jun 26 2017

Cc: npm@chromium.org
CFX_SkiaDeviceDriver::DrawDeviceText seems to be ignoring the m_AdjustMatrix even when m_bGlyphAdjust is true, see for example
https://cs.chromium.org/chromium/src/third_party/pdfium/core/fxge/ge/cfx_renderdevice.cpp?type=cs&l=951
re #8 : thanks for the diagnosis -- very helpful
Labels: -Pri-1 -M-61 Pri-2
dsinclair@ turned off Skia path for PDFium, so this is no longer a P1 regression.
Cc: bungeman@google.com
Owner: caryclark@google.com
While this PDF does indeed use m_AdjustMatrix to condense characters, it mostly uses multiple master axis parameters to narrow the text in some places an embolden it in others.

The multiple master control code is in cfx_font.cpp, CFX_Font::AdjustMMParams.

I have a bit of rewriting to do to take advantage of this, and will work with our resident font expert to make sure that the result is sustainable.
Blockedon: skia:6814
Owner: bunge...@chromium.org

Sign in to add a comment