Perf benchmark for PWAs using the loading benchmark |
||||||||||
Issue description
Currently there are only two types of perf tests for service workers:
- service_worker.service_worker_micro_benchmark
- service_worker.service_worker
= service_worker.service_worker_micro_benchmark =
This test uses local testing page to evaluate the performance of the simplest fetch event use case. This is very flaky by nature, and the deviation of the benchmark from the actual pages is large.
= service_worker.service_worker =
This test uses Speedindex which is a measurement of the loading speed, but it's deprecated and this test is the last user.
We are now having a new unified metrics like Time To First {Contentful Paint, Meaningful Paint}.
Let's have the loading benchmark for PWAs.
There are already several pageset which have service workers, so run several times and tag them based on the temperature of the state like install sw [1st]/installed sw [2nd]/cached [3rd].
Design doc of perf benchmark for PWA:
https://docs.google.com/document/d/1Nf97CVp1X7aSqvAspyJ7yOCDyr1osUNrnfrGwZ_Yuuo/edit?usp=sharing
,
Jun 26 2017
,
Jun 26 2017
Can we also remove those obsolete SW benchmarks?
,
Jun 27 2017
Yes, I think so. Currently these are our only benchmarks, so I'd like to remove them after new perf tests land.
,
Jun 27 2017
Your plan SGTM.
,
Jun 30 2017
,
Jul 12 2017
,
Jul 12 2017
,
Jul 12 2017
,
Jul 21 2017
The NextAction date has arrived: 2017-07-21
,
Aug 3 2017
,
Aug 31 2017
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86469d1705f47992edd13d7154724ec870d945a3 commit 86469d1705f47992edd13d7154724ec870d945a3 Author: Yuki Yamada <yukiy@google.com> Date: Thu Aug 31 08:00:45 2017 Add trace events at DispatchFetchEvent and DidHandleFetchEvent This CL adds trace events at ServiceWorkerContextClient::DispatchFetchEvent() and ServiceWorkerContextClient::DidHandleFetchEvent() for checking if all service worker fetch events are completed at the end of perf test measuring. Design doc of perf benchmark for PWA: https://docs.google.com/document/d/1Nf97CVp1X7aSqvAspyJ7yOCDyr1osUNrnfrGwZ_Yuuo/edit?usp=sharing Bug: 736697 Change-Id: Idad98dda033cd85447c5eb37a2a443995c297594 Reviewed-on: https://chromium-review.googlesource.com/640277 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#498779} [modify] https://crrev.com/86469d1705f47992edd13d7154724ec870d945a3/content/renderer/service_worker/service_worker_context_client.cc
,
Sep 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e56f178767143148dca2895dfd8945a57b24a66 commit 4e56f178767143148dca2895dfd8945a57b24a66 Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Tue Sep 05 20:29:24 2017 Roll src/third_party/catapult/ d4179a057..4ab7a181d (7 commits) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d4179a057d4b..4ab7a181db1c $ git log d4179a057..4ab7a181d --date=short --no-merges --format='%ad %ae %s' 2017-09-05 perezju Revert of Add tab.IsServiceWorkerReadyOrNotRegist() which tells whether serviceworker registration is finished (patchset #8 id:140001 of https://chromiumcodereview.appspot.com/3012573002/ ) 2017-09-05 perezju [Telemetry] Temporarily disable modal permission prompts on Android 2017-09-04 dtu [pinpoint] Abbreviated Job dict for the Jobs listing page. 2017-09-04 dtu [pinpoint] Fix GTest parameters. 2017-09-04 NghiaNguyenBH Rename directory from mip to mips 2017-09-04 djordje.golubovic.imgtec Add MIPS d8 binary (version 5.7.492.65) 2017-09-04 yukiy Add tab.IsServiceWorkerReadyOrNotRegistered() which tells whether serviceworker registration is finished Created with: roll-dep src/third_party/catapult BUG= 736697 , 760319 , 736697 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia2ba493dffdaf0f52106ba3c481e40a018c2b247 Reviewed-on: https://chromium-review.googlesource.com/650686 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#499734} [modify] https://crrev.com/4e56f178767143148dca2895dfd8945a57b24a66/DEPS
,
Sep 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d814f79c599c6421b5e280a6d0c4b778c748ec5a commit d814f79c599c6421b5e280a6d0c4b778c748ec5a Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Thu Sep 14 08:12:24 2017 Roll src/third_party/catapult/ e45810de0..743ca01bf (3 commits) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e45810de0f2f..743ca01bfe12 $ git log e45810de0..743ca01bf --date=short --no-merges --format='%ad %ae %s' 2017-09-13 yukiy Add tab.ClearDataForOrigin() which calls Storage.clearDataForOrigin 2017-09-13 benjhayden Plumb traceUrls through ChartJsonConverter. 2017-09-13 yukiy Reland Add tab.IsServiceWorkerReadyOrNotRegist() which tells whether serviceworker registration is finished ( https://chromiumcodereview.appspot.com/3012573002 ) Created with: roll-dep src/third_party/catapult BUG= 736697 , 736697 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I92cecac1f55c205cdbde067a0a0c1e4debc68a84 Reviewed-on: https://chromium-review.googlesource.com/666147 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501897} [modify] https://crrev.com/d814f79c599c6421b5e280a6d0c4b778c748ec5a/DEPS
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09ef5146146ee2df4ad9e4d43d9755b22c5838e2 commit 09ef5146146ee2df4ad9e4d43d9755b22c5838e2 Author: Yuki Yamada <yukiy@google.com> Date: Fri Sep 15 07:36:36 2017 Add stopAllWorkers to devtools protocol This CL adds ServiceWorker.stopAllWorkers() to devtools protocol for stopping all service workers before running perf benchmark for PWA. Design doc of perf benchmark for PWA: https://docs.google.com/document/d/1Nf97CVp1X7aSqvAspyJ7yOCDyr1osUNrnfrGwZ_Yuuo/edit?usp=sharing Bug: 736697 Change-Id: I4286b6a79dbfd29c28437145ef870fca352cce1c Reviewed-on: https://chromium-review.googlesource.com/635105 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#502186} [modify] https://crrev.com/09ef5146146ee2df4ad9e4d43d9755b22c5838e2/content/browser/devtools/protocol/service_worker_handler.cc [modify] https://crrev.com/09ef5146146ee2df4ad9e4d43d9755b22c5838e2/content/browser/devtools/protocol/service_worker_handler.h [modify] https://crrev.com/09ef5146146ee2df4ad9e4d43d9755b22c5838e2/content/browser/devtools/protocol_config.json [modify] https://crrev.com/09ef5146146ee2df4ad9e4d43d9755b22c5838e2/content/browser/service_worker/service_worker_context_wrapper.cc [modify] https://crrev.com/09ef5146146ee2df4ad9e4d43d9755b22c5838e2/content/browser/service_worker/service_worker_context_wrapper.h [modify] https://crrev.com/09ef5146146ee2df4ad9e4d43d9755b22c5838e2/content/public/browser/service_worker_context.h [modify] https://crrev.com/09ef5146146ee2df4ad9e4d43d9755b22c5838e2/content/public/test/fake_service_worker_context.cc [modify] https://crrev.com/09ef5146146ee2df4ad9e4d43d9755b22c5838e2/content/public/test/fake_service_worker_context.h [modify] https://crrev.com/09ef5146146ee2df4ad9e4d43d9755b22c5838e2/third_party/WebKit/Source/core/inspector/browser_protocol.json
,
Sep 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ea409b28620ff9cb99d352763864bdba95e158b commit 2ea409b28620ff9cb99d352763864bdba95e158b Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Tue Sep 19 02:02:15 2017 Roll src/third_party/catapult/ 441164c72..c173be04c (2 commits) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/441164c72d1c..c173be04cac2 $ git log 441164c72..c173be04c --date=short --no-merges --format='%ad %ae %s' 2017-09-18 yukiy Rename cache_temperature states 2017-09-18 dtu [pinpoint] No taskqueue retries. Created with: roll-dep src/third_party/catapult BUG= 736697 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I755e4e7a7ef8c47d4d7c525026427828b245d7e4 Reviewed-on: https://chromium-review.googlesource.com/671677 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502759} [modify] https://crrev.com/2ea409b28620ff9cb99d352763864bdba95e158b/DEPS
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c0bb1781d15a9a8ea78b1f7cab1ba472b36d507 commit 5c0bb1781d15a9a8ea78b1f7cab1ba472b36d507 Author: Yuki Yamada <yukiy@google.com> Date: Thu Sep 21 02:37:13 2017 PostTask in ServiceWorkerContextWrapper::StopAllServiceWorkersOnIO() This is a following CL for https://chromium-review.googlesource.com/c/chromium/src/+/635105/23 |callback| should be run from |task_runner_for_callback|. Bug: 736697 Change-Id: I51212a96f00801fd019670ca6b3c57d755b3d5c6 Reviewed-on: https://chromium-review.googlesource.com/672265 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#503329} [modify] https://crrev.com/5c0bb1781d15a9a8ea78b1f7cab1ba472b36d507/content/browser/service_worker/service_worker_context_wrapper.cc
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bcdac8d88864a5fc8a4c2cd5a4f9360a8a12bb3a commit bcdac8d88864a5fc8a4c2cd5a4f9360a8a12bb3a Author: Yuki Yamada <yukiy@google.com> Date: Thu Sep 21 10:29:52 2017 Wait service worker registration at RunPageInteractions Wait service worker registration to be completed at RunPageInteractions. tab.IsServiceWorkerActivatedOrNotRegistered returns true if service worker registration is finished or service worker is not registered, so RunPageInteractions waits this to be true. Design doc of perf benchmark for PWA: https://docs.google.com/document/d/1Nf97CVp1X7aSqvAspyJ7yOCDyr1osUNrnfrGwZ_Yuuo/edit?usp=sharing Bug: 736697 Change-Id: I507b0bdf76bdf460841348136dc86db0f32aeab7 Reviewed-on: https://chromium-review.googlesource.com/647128 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#503410} [modify] https://crrev.com/bcdac8d88864a5fc8a4c2cd5a4f9360a8a12bb3a/tools/perf/page_sets/page_cycler_story.py
,
Sep 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05054a75d3c5fa349e6e33e297c4e9f56c143851 commit 05054a75d3c5fa349e6e33e297c4e9f56c143851 Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Thu Sep 21 10:50:49 2017 Roll src/third_party/catapult/ 195ce2a78..e1aa3179f (1 commit) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/195ce2a78d4c..e1aa3179fac3 $ git log 195ce2a78..e1aa3179f --date=short --no-merges --format='%ad %ae %s' 2017-09-21 yukiy Rename 'warmCache' to 'warm_cache' Created with: roll-dep src/third_party/catapult BUG= 736697 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ibec1074d6dbc3064087307190d077b9c0ee0eef6 Reviewed-on: https://chromium-review.googlesource.com/677051 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#503415} [modify] https://crrev.com/05054a75d3c5fa349e6e33e297c4e9f56c143851/DEPS
,
Sep 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9fd90f3acee8e03fc303e11a86e431b484002eaf commit 9fd90f3acee8e03fc303e11a86e431b484002eaf Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Fri Sep 22 06:51:51 2017 Roll src/third_party/catapult/ b233ea0e0..eb2e641ee (1 commit) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b233ea0e0e23..eb2e641ee3d1 $ git log b233ea0e0..eb2e641ee --date=short --no-merges --format='%ad %ae %s' 2017-09-21 yukiy Add methods for cache_temperature: ClearCache, WarmCache (refactoring of cache_temperature) Created with: roll-dep src/third_party/catapult BUG= 736697 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I8d171fb792ddbe45ba30735fadd5afb097925027 Reviewed-on: https://chromium-review.googlesource.com/678057 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#503674} [modify] https://crrev.com/9fd90f3acee8e03fc303e11a86e431b484002eaf/DEPS
,
Sep 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5d3a551f62a5f97e286e2dfc4611ebc847d86bc commit c5d3a551f62a5f97e286e2dfc4611ebc847d86bc Author: Yuki Yamada <yukiy@google.com> Date: Mon Sep 25 10:39:58 2017 Replace cache_temperature state names This CL replaces old cache_temperature state names to new ones. cache_temperature states are renamed in this CL: https://codereview.chromium.org/3016523002/ Bug: 736697 Change-Id: I6cbf735c28471d1be136618e9296e1d8050d53af Reviewed-on: https://chromium-review.googlesource.com/674483 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#504023} [modify] https://crrev.com/c5d3a551f62a5f97e286e2dfc4611ebc847d86bc/tools/perf/benchmarks/loading.py [modify] https://crrev.com/c5d3a551f62a5f97e286e2dfc4611ebc847d86bc/tools/perf/contrib/cros_benchmarks/page_cycler_v2.py [modify] https://crrev.com/c5d3a551f62a5f97e286e2dfc4611ebc847d86bc/tools/perf/page_sets/loading_desktop.py
,
Sep 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e618e54348a6a9f87d98c31e3ae46715c688e1ba commit e618e54348a6a9f87d98c31e3ae46715c688e1ba Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Tue Sep 26 08:51:46 2017 Roll src/third_party/catapult/ 030de5515..639e972bf (1 commit) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/030de5515608..639e972bf15c $ git log 030de5515..639e972bf --date=short --no-merges --format='%ad %ae %s' 2017-09-25 yukiy Add tab.StopAllServiceWorkers() Created with: roll-dep src/third_party/catapult BUG= 736697 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I7e1d0b5fa661a50b05e839ccce96b4b732f7936c Reviewed-on: https://chromium-review.googlesource.com/684194 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504319} [modify] https://crrev.com/e618e54348a6a9f87d98c31e3ae46715c688e1ba/DEPS
,
Sep 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66651e7000cf55dc7abddda278c1418ed687461f commit 66651e7000cf55dc7abddda278c1418ed687461f Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Wed Sep 27 10:03:11 2017 Roll src/third_party/catapult/ 1b6b78dad..0ce28daf7 (1 commit) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1b6b78dad501..0ce28daf74eb $ git log 1b6b78dad..0ce28daf7 --date=short --no-merges --format='%ad %ae %s' 2017-09-27 yukiy Handle error code METHOD_NOT_FOUND_CODE in InspectorServiceWorker.StopAllWorkers() Created with: roll-dep src/third_party/catapult BUG= 736697 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ibc863aa11b7aa438e86376295029807142ec6d05 Reviewed-on: https://chromium-review.googlesource.com/686298 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504618} [modify] https://crrev.com/66651e7000cf55dc7abddda278c1418ed687461f/DEPS
,
Sep 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3c34753736f364fe33b15ecaa590ffe7e2f0a09 commit b3c34753736f364fe33b15ecaa590ffe7e2f0a09 Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org> Date: Wed Sep 27 15:03:58 2017 Roll src/third_party/catapult/ 0ce28daf7..d08152f8a (4 commits) https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0ce28daf74eb..d08152f8a5da $ git log 0ce28daf7..d08152f8a --date=short --no-merges --format='%ad %ae %s' 2017-09-27 eakuefner Whitelist histograms service account 2017-09-27 yukiy Update telemetry user-agent 2017-09-27 yukiy Remove legacy states from cache_temperature 2017-09-27 yukiy Add cache_temperature state "HOT" Created with: roll-dep src/third_party/catapult BUG= 769195 , 736697 , 736697 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I55f72c0ddd4ebe6d300f0c724594094e84ed5bc9 Reviewed-on: https://chromium-review.googlesource.com/686999 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#504674} [modify] https://crrev.com/b3c34753736f364fe33b15ecaa590ffe7e2f0a09/DEPS
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84bec0a51f80332480ef24f8de7e34e987faffde commit 84bec0a51f80332480ef24f8de7e34e987faffde Author: Yuki Yamada <yukiy@google.com> Date: Fri Sep 29 06:52:08 2017 Use new cache_temperature state in PWA story set of loading.mobile In order to testing PWAs with service worker, this CL make PWA story set in loading.mobile use cahce_temperature state COLD, WARM and HOT. Also this removes the following pages from test to reduce the total execution time. GuitarTuner InboxAttack Pokedex 2048 TrainedToThrill TownWork cache_temperature.HOT is added in https://crrev.com/3011263002/ Design doc of perf benchmark for PWA: https://docs.google.com/document/d/1Nf97CVp1X7aSqvAspyJ7yOCDyr1osUNrnfrGwZ_Yuuo/edit?usp=sharing Bug: 736697 Change-Id: Iecdbe28f59d3378f3c18619d058a527231a6cfc3 Reviewed-on: https://chromium-review.googlesource.com/684034 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#505313} [modify] https://crrev.com/84bec0a51f80332480ef24f8de7e34e987faffde/tools/perf/benchmarks/loading.py [modify] https://crrev.com/84bec0a51f80332480ef24f8de7e34e987faffde/tools/perf/page_sets/loading_mobile.py
,
Oct 2 2017
It's started to work! :) https://chromeperf.appspot.com/report?sid=4c717551d9717ff0d1e8f249b82bcc98bddd8543b803bdff101fd93062739d4a&rev=505529
,
Oct 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/63a614b752730aea77b24d26e20ad356b51a70aa commit 63a614b752730aea77b24d26e20ad356b51a70aa Author: Makoto Shimazu <shimazu@chromium.org> Date: Thu Oct 05 03:04:37 2017 Factored out EnsureCacheTemperature into each temperature This is a follow-up patch for https://crrev.com/3013213002. Each temperature is overriding CacheManipulator in this patch. Also, this patch adds '_' prefix for functions used only in cache_temperature.py. Bug: chromium:736697 Change-Id: I1f9bc2f5c7d65896d10325ec18b5014f3fcf36bc Reviewed-on: https://chromium-review.googlesource.com/700156 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/63a614b752730aea77b24d26e20ad356b51a70aa/telemetry/telemetry/page/cache_temperature.py |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by shimazu@chromium.org
, Jun 26 2017