New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736695 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue pdfium:11



Sign in to add a comment

Regression:Drop down list doesn't appear properly and field appears blank after closing list for pdf file.

Reported by vku...@etouch.net, Jun 26 2017

Issue description

Chrome Version : 61.0.3141.0 (Official Build) Revision	180095eb1bca7df1cdcb02547340499c2ee3af6e-refs/heads/master@{#482153} (32/64-bit)
OS:Windows(7,8,10), Mac (10.11.6, 10.12.1), Linux (14.04 LTS)

What steps will reproduce the problem?
(1)Launch chrome and navigate to http://foersom.com/net/HowTo/data/OoPdfFormExample.pdf
(2)Scroll down the page click on drop down button under "favourite colour" OR "country" field.
(3)Hover mouse on option and observe,click on page such that list closes.
(4)Observe the field after closing list.

Actual: Drop down list doesn't appear properly & field appears blank after closing list.

Expected: Drop down list should be properly displayed & field should not appear blank after closing list.

This is a regression issue broken in 'M61' and below is the manual regression range
Good Build: 61.0.3138.0 
Bad Build:  61.0.3140.0 
 
Actual_PDF.mov
1.5 MB Download
Expected_PDF.mov
1.1 MB Download
Labels: hasbisect-per-revision ReleaseBlock-Dev
Owner: dsinclair@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue and below are the bisect details obtained using per-revision bisect:

You are probably looking for a change made after 481560 (known good), but no later than 481561 (first known bad).
CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/a95e0bf52bfe99622e4bf498adb761cf9eb218a9..1545ba94087279c773705760d51b728d709fd72d

@dsinclair: Assigning to you, kindly take a look into it Please help us to find an owner if not with respect to your change.

Adding Blocker label, please decrease or remove priority if not the case.

Thanks.!
Blocking: pdfium:11
Cc: dsinclair@chromium.org
Owner: caryclark@chromium.org
Bisect shows Skia Paths enabling CL.
Labels: -ReleaseBlock-Dev ReleaseBlock-Beta
Not an RBD since the bug doesn't affects the functionality.
Labels: -ReleaseBlock-Beta -M-61
The skia code has been disabled again. Removing release block label.
Owner: caryclark@google.com
Owner: dsinclair@chromium.org
Dan graciously offered to help create a repro case. He'll assign back to me once he's done.
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/08c6651ec45b8cf01e6b6bbe8f57b1052554de94

commit 08c6651ec45b8cf01e6b6bbe8f57b1052554de94
Author: dan sinclair <dsinclair@chromium.org>
Date: Mon Jul 10 16:03:02 2017

Add combo box tests.

These tests pass under normal PDFium bug fail when Skia Paths is
enabled.

Bug:  chromium:736695 
Change-Id: I7e3e789ae25857060dd45940c313f5383c548d2c
Reviewed-on: https://pdfium-review.googlesource.com/7450
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Cary Clark <caryclark@google.com>

[add] https://crrev.com/08c6651ec45b8cf01e6b6bbe8f57b1052554de94/testing/resources/pixel/bug_736695_1.in
[add] https://crrev.com/08c6651ec45b8cf01e6b6bbe8f57b1052554de94/testing/resources/pixel/bug_736695_4_expected.pdf.0.png
[add] https://crrev.com/08c6651ec45b8cf01e6b6bbe8f57b1052554de94/testing/resources/pixel/bug_736695_2.in
[add] https://crrev.com/08c6651ec45b8cf01e6b6bbe8f57b1052554de94/testing/resources/pixel/bug_736695_2_expected.pdf.0.png
[add] https://crrev.com/08c6651ec45b8cf01e6b6bbe8f57b1052554de94/testing/resources/pixel/bug_736695_2.evt
[add] https://crrev.com/08c6651ec45b8cf01e6b6bbe8f57b1052554de94/testing/resources/pixel/bug_736695_3_expected_mac.pdf.0.png
[add] https://crrev.com/08c6651ec45b8cf01e6b6bbe8f57b1052554de94/testing/resources/pixel/bug_736695_3.evt
[add] https://crrev.com/08c6651ec45b8cf01e6b6bbe8f57b1052554de94/testing/resources/pixel/bug_736695_3_expected.pdf.0.png
[add] https://crrev.com/08c6651ec45b8cf01e6b6bbe8f57b1052554de94/testing/resources/pixel/bug_736695_2_expected_mac.pdf.0.png
[add] https://crrev.com/08c6651ec45b8cf01e6b6bbe8f57b1052554de94/testing/resources/pixel/bug_736695_3.in
[add] https://crrev.com/08c6651ec45b8cf01e6b6bbe8f57b1052554de94/testing/resources/pixel/bug_736695_1_expected.pdf.0.png
[add] https://crrev.com/08c6651ec45b8cf01e6b6bbe8f57b1052554de94/testing/resources/pixel/bug_736695_4.in
[add] https://crrev.com/08c6651ec45b8cf01e6b6bbe8f57b1052554de94/testing/resources/pixel/bug_736695_4.evt

Owner: caryclark@google.com
Tests landed with https://pdfium-review.googlesource.com/c/7450
Cc: thestig@chromium.org
This seems to be a difference caused by the progressive renderer. In pdfium_test we call FPDF_RenderPageBitmap() but Chrome uses the FPDF_RenderPageBitmap_Start(), FPDF_RenderPage_Continue() and FPDF_RenderPage_Close() methods.

Interestingly, if you print the PDF from chrome you see the correct widget, which I believe is because Chrome uses the FPDF_RenderPageBitmap() call to rendering the print preview page.
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/aeadad1dfb7e4d3582d63dacd2ecbed71a5dd4ec

commit aeadad1dfb7e4d3582d63dacd2ecbed71a5dd4ec
Author: Dan Sinclair <dsinclair@chromium.org>
Date: Tue Jul 18 21:20:38 2017

Make progressive renderer default for pdfium_test.

When Chrome renders PDF pages it uses the progressive renderer. The one
shot renderer is used to render print preview pages. This CL changes
pdfium_test to use the progressive renderer by default to better match
Chrome. This also adds a --render-oneshot flag which will use the
non-progressive renderer.

Bug:  chromium:736695 
Change-Id: If79333ae10a0ed1c9bce1290caad8d531e6709aa
Reviewed-on: https://pdfium-review.googlesource.com/8130
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>

[modify] https://crrev.com/aeadad1dfb7e4d3582d63dacd2ecbed71a5dd4ec/testing/tools/test_runner.py
[modify] https://crrev.com/aeadad1dfb7e4d3582d63dacd2ecbed71a5dd4ec/samples/pdfium_test.cc
[modify] https://crrev.com/aeadad1dfb7e4d3582d63dacd2ecbed71a5dd4ec/testing/tools/run_corpus_tests.py

Status: Fixed (was: Assigned)
Fixed here: https://pdfium-review.googlesource.com/c/8270/

Sign in to add a comment