Recent tlsdate change broke the chromiumos-sdk builder |
|||||
Issue descriptionThe chromiumos-sdk waterfall builder started failing sometime between 9:15am Friday morning and 1am Saturday (see https://uberchromegw.corp.google.com/i/chromiumos/builders/chromiumos-sdk) According to the build logs, it is failing while trying to build platform-cros-util-unitttest.c in the net-misc/tlsdate package. It looks this file was added by the CL https://chromium-review.googlesource.com/c/545225/ that was committed on Friday at 10:19am. It looks like the issue is easy enough to fix: The error messages in the build logs are: tlsdate-0.0.5-r49: src/platform-cros-util-unittest.c: In function 'test_canonicalize_pac_parsing': tlsdate-0.0.5-r49: src/platform-cros-util-unittest.c:71:3: error: 'for' loop initial declarations are only allowed in C99 or C11 mode tlsdate-0.0.5-r49: for (size_t i = 0; i < ARRAYSIZE(kCases); ++i) { tlsdate-0.0.5-r49: ^ tlsdate-0.0.5-r49: src/platform-cros-util-unittest.c:71:3: note: use option -std=c99, -std=gnu99, -std=c11 or -std=gnu11 to compile your code tlsdate-0.0.5-r49: src/platform-cros-util-unittest.c: In function 'test_canonicalize_pac_overflow': tlsdate-0.0.5-r49: src/platform-cros-util-unittest.c:95:3: error: 'for' loop initial declarations are only allowed in C99 or C11 mode tlsdate-0.0.5-r49: for (size_t i = 0; i < ARRAYSIZE(kCases); ++i) { tlsdate-0.0.5-r49: ^ tlsdate-0.0.5-r49: make[1]: *** [Makefile:1222: src/platform-cros-util-unittest.o] Error 1 tlsdate-0.0.5-r49: make[1]: *** Waiting for unfinished jobs.... tlsdate-0.0.5-r49: CC src/src_tlsdated-tlsdated.o tlsdate-0.0.5-r49: src/platform-cros.c: In function 'handle_proxy_change': tlsdate-0.0.5-r49: src/platform-cros.c:158:18: warning: variable 'src' set but not used [-Wunused-but-set-variable] tlsdate-0.0.5-r49: struct source *src = ctx->state->opts.sources; tlsdate-0.0.5-r49: ^ tlsdate-0.0.5-r49: src/platform-cros.c: In function 'handle_proxy_change': tlsdate-0.0.5-r49: src/platform-cros.c:158:18: warning: variable 'src' set but not used [-Wunused-but-set-variable] tlsdate-0.0.5-r49: struct source *src = ctx->state->opts.sources; tlsdate-0.0.5-r49: ^
,
Jun 26 2017
tlsdate also fails with the same error messages on an x86-generic build. It does not fail on 3 other boards I tried locally (cyan, samus, stumpy).
,
Jun 26 2017
I think I might've heard that the x86-generic build was turned down recently, but maybe I'm making that up. If compiling for chromiumos-sdk is critical, we should probably have something with a similar toolchain config in the CQ, though.
,
Jun 26 2017
Ugh, I forgot about that waterfall. We have dropped support of x86, so we need to turn down the x86-generic builders on that waterfall.
,
Jun 26 2017
This is news to me. What does "dropped support of x86" mean exactly? Besides x86-generic, what else is impacted?
,
Jun 26 2017
EOL policy for Chromebooks is 5 years: https://support.google.com/chrome/a/answer/6220366?hl=en There are no x86 based Chromebooks receiving updates. We recently decided to stop supporting x86 testing in the waterfalls so that we can provide better coverage for supported devices.
,
Jun 26 2017
I will remove the x86-generic testing in the chromiumos-sdk builder. Removing x86-generic is simple but I wanted to keep some basic x86-testing for a little bit of functionality that still uses it. And I have not figured out that yet. So, please commit the CL (https://bugs.chromium.org/p/chromium/issues/detail?id=736534) to fix the current issue as soon as you can.
,
Jun 26 2017
We shouldn't have downstream compilation failures in the Chrome OS build waterfall. If chromiumos-sdk should have a CQ bot somewhere.
,
Jun 26 2017
The pre-cq seems to be broken because of this -- what's the ETA on the fix?
,
Jun 26 2017
Can you elaborate on "pre-cq seems to be broken"? https://chromium-review.googlesource.com/c/545225/ went in on Friday morning (after being verified by the pre-CQ and CQ). I see many successful pre-CQ runs since then. The CQ status message links to three bugs, but not this one. I linked to the speculative fix, https://chromium-review.googlesource.com/c/548217/, in the first comment. It's been in the CQ for about an hour (and passed the pre-CQ as well, for whatever that's worth).
,
Jun 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/tlsdate/+/e29f26e73dbdea06d16a134fa14761be675b4c12 commit e29f26e73dbdea06d16a134fa14761be675b4c12 Author: Daniel Erat <derat@chromium.org> Date: Tue Jun 27 00:25:25 2017 tlsdate: Avoid declaring vars in for-loop conditions. Change some code in platform-cros-util-unittest.c to avoid errors when using old compilers. Also delete an unused variable in platform-cros.c. BUG= chromium:736689 TEST=tests still pass in local build Change-Id: Ib80b8162203f4041b4b5afa9c7508a2bbc73c93f Reviewed-on: https://chromium-review.googlesource.com/548217 Commit-Queue: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Trybot-Ready: Dan Erat <derat@chromium.org> Reviewed-by: Luis Lozano <llozano@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> [modify] https://crrev.com/e29f26e73dbdea06d16a134fa14761be675b4c12/src/platform-cros-util-unittest.c [modify] https://crrev.com/e29f26e73dbdea06d16a134fa14761be675b4c12/src/platform-cros.c
,
Jun 27 2017
,
Jun 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/tlsdate/+/87305fef6ff3eeb9843273a285192d4457f99b1f commit 87305fef6ff3eeb9843273a285192d4457f99b1f Author: Daniel Erat <derat@chromium.org> Date: Tue Jun 27 05:51:42 2017 tlsdate: Avoid declaring vars in for-loop conditions. Change some code in platform-cros-util-unittest.c to avoid errors when using old compilers. Also delete an unused variable in platform-cros.c. BUG= chromium:736689 TEST=tests still pass in local build Change-Id: Ib80b8162203f4041b4b5afa9c7508a2bbc73c93f Reviewed-on: https://chromium-review.googlesource.com/548217 Commit-Queue: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Trybot-Ready: Dan Erat <derat@chromium.org> Reviewed-by: Luis Lozano <llozano@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> (cherry picked from commit e29f26e73dbdea06d16a134fa14761be675b4c12) Reviewed-on: https://chromium-review.googlesource.com/549663 Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/87305fef6ff3eeb9843273a285192d4457f99b1f/src/platform-cros-util-unittest.c [modify] https://crrev.com/87305fef6ff3eeb9843273a285192d4457f99b1f/src/platform-cros.c
,
Jan 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by derat@chromium.org
, Jun 26 2017Components: OS>Systems Build
Status: Started (was: Untriaged)
Summary: Recent tlsdate change broke the chromiumos-sdk builder (was: Recent change broke the chromiumos-sdk builder)