content_unittests failing on chromium.win/Win7 Tests (dbg)(1) |
|||
Issue descriptioncontent_unittests failing on chromium.win/Win7 Tests (dbg)(1) Builders failed on: - Win7 Tests (dbg)(1): https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29 https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/61045 failures: DevToolsHttpHandlerTest.TestDevToolsActivePort DevToolsHttpHandlerTest.TestServerSocketFailed DevToolsHttpHandlerTest.TestStartStop
,
Jun 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c41874caefd3b6aabc2cb6645b833c60bc5e8bf commit 6c41874caefd3b6aabc2cb6645b833c60bc5e8bf Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Mon Jun 26 03:23:00 2017 Revert "Remove usage of FILE thread from devtools_http_handler" This reverts commit 878caac25f40c8d3ab7c853315bab0708882ed28. Reason for revert: Speculative revert for DevToolsHttpHandlerTest.* failure on Win7 Tests (dbg)(1). See crbug.com/736681 . Original change's description: > Remove usage of FILE thread from devtools_http_handler > > - do not use FILE thread to start the handler thread, this doesn't block > abd should be fine on UI; > - make ownership transfer for objects passed between threads more > explicit by passing unique_ptr<> instead of raw pointers; > - delete thread on an arbitrary thread from pool, not on FILE thread. > > Bug: 689520 > Change-Id: I81fcbc5038a306453ba620bbe66287900153dcc8 > Reviewed-on: https://chromium-review.googlesource.com/544225 > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#482066} TBR=dgozman@chromium.org,caseq@chromium.org,pfeldman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 689520 , 736681 Change-Id: I444218567f46eb853599b5468f26b351e6782175 Reviewed-on: https://chromium-review.googlesource.com/547117 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#482190} [modify] https://crrev.com/6c41874caefd3b6aabc2cb6645b833c60bc5e8bf/content/browser/devtools/devtools_http_handler.cc [modify] https://crrev.com/6c41874caefd3b6aabc2cb6645b833c60bc5e8bf/content/browser/devtools/devtools_http_handler.h [modify] https://crrev.com/6c41874caefd3b6aabc2cb6645b833c60bc5e8bf/content/browser/devtools/devtools_http_handler_unittest.cc
,
Jun 26 2017
The revert seems to have fixed the problem.
,
Jun 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9755ea989cd70104a067207e3d524a19ebd6cfd9 commit 9755ea989cd70104a067207e3d524a19ebd6cfd9 Author: Andrey Kosyakov <caseq@chromium.org> Date: Mon Jun 26 18:50:13 2017 Revert "Remove usage of FILE thread from devtools_http_handler" This reverts commit 878caac25f40c8d3ab7c853315bab0708882ed28. Reason for revert: Speculative revert for DevToolsHttpHandlerTest.* failure on Win7 Tests (dbg)(1). See crbug.com/736681 . Original change's description: > Remove usage of FILE thread from devtools_http_handler > > - do not use FILE thread to start the handler thread, this doesn't block > abd should be fine on UI; > - make ownership transfer for objects passed between threads more > explicit by passing unique_ptr<> instead of raw pointers; > - delete thread on an arbitrary thread from pool, not on FILE thread. > > Bug: 689520 > Change-Id: I81fcbc5038a306453ba620bbe66287900153dcc8 > Reviewed-on: https://chromium-review.googlesource.com/544225 > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#482066} TBR=caseq@chromium.org, dgozman@chromium.org, ksakamoto@chromium.org, pfeldman@chromium.org (cherry picked from commit 6c41874caefd3b6aabc2cb6645b833c60bc5e8bf) Bug: 689520 , 736681 Change-Id: I444218567f46eb853599b5468f26b351e6782175 Reviewed-on: https://chromium-review.googlesource.com/547117 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#482190} Reviewed-on: https://chromium-review.googlesource.com/549078 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/branch-heads/3141@{#5} Cr-Branched-From: 180095eb1bca7df1cdcb02547340499c2ee3af6e-refs/heads/master@{#482153} [modify] https://crrev.com/9755ea989cd70104a067207e3d524a19ebd6cfd9/content/browser/devtools/devtools_http_handler.cc [modify] https://crrev.com/9755ea989cd70104a067207e3d524a19ebd6cfd9/content/browser/devtools/devtools_http_handler.h [modify] https://crrev.com/9755ea989cd70104a067207e3d524a19ebd6cfd9/content/browser/devtools/devtools_http_handler_unittest.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by ksakamoto@chromium.org
, Jun 26 2017