Layout Test virtual/enable_wasm_streaming/http/tests/wasm_streaming/wasm_response_apis.html is flaky |
||||||||
Issue descriptionThe following layout test is flaky on All debug bots: virtual/enable_wasm_streaming/http/tests/wasm_streaming/wasm_response_apis.html Probable cause: https://chromium.googlesource.com/chromium/src/+/bb2ecc3904828a1619cf7c55d66b2b19731782e8 https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&showLargeExpectations=true&showExpectations=true&tests=virtual%2Fenable_wasm_streaming%2Fhttp%2Ftests%2Fwasm_streaming%2Fwasm_response_apis.html STDERR: # Fatal error in e:\b\c\builder\site_isolation_win\src\v8\src\base\platform\elapsed-timer.h, line 24 STDERR: # Check failed: !IsStarted(). STDERR: # STDERR: Backtrace: STDERR: base::debug::StackTrace::StackTrace [0x00F7EB57+55] STDERR: base::debug::StackTrace::StackTrace [0x00F9AA9A+10] STDERR: V8_Fatal [0x01D17D51+81] STDERR: v8::base::ElapsedTimer::Start [0x0083B313+147] STDERR: v8::internal::TimedHistogram::Start [0x00A33974+20] STDERR: v8::internal::compiler::WasmCompilationUnit::ExecuteCompilation [0x00A21769+57] STDERR: v8::internal::wasm::ModuleCompiler::CompileAndSchedule [0x00D2A0D4+132] STDERR: v8::internal::wasm::ModuleCompiler::CompileInParallel [0x00D2A1CE+110] STDERR: v8::internal::wasm::ModuleCompiler::CompileToModuleObjectInternal [0x00D2A644+372] STDERR: v8::internal::wasm::ModuleCompiler::CompileToModuleObject [0x00D2A4AC+332] STDERR: v8::internal::wasm::SyncCompile [0x00D54E06+294] STDERR: v8::WasmCompiledModule::Compile [0x00820410+96] STDERR: v8::WasmModuleObjectBuilder::Finish [0x00824B8E+110] STDERR: blink::WasmResponseExtensions::Initialize [0x02E1A02E+290] STDERR: blink::WasmResponseExtensions::Initialize [0x02E1A25A+846] STDERR: blink::BodyStreamBuffer::StartLoading [0x023F4EF4+237] STDERR: blink::`anonymous namespace'::FetchDataLoaderAsWasmModule::`vector deleting destructor' [0x02E19CC7+711]
,
Jun 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/f7d60ab798a550f8f77cbfdbd297b9d76cfa7e4d commit f7d60ab798a550f8f77cbfdbd297b9d76cfa7e4d Author: Michael Achenbach <machenbach@chromium.org> Date: Mon Jun 26 06:41:57 2017 Revert "Remove DCHECK for isolate->counters()" This reverts commit ee0e295d8e829b5c3fc1225b09c7c886e00305f6. Suspect for http://crbug.com/736676 Another dcheck fails, starting after the reverted CL, e.g.: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/8666 BUG= chromium:736676 , v8:6361 TBR=kschimpf@chromium.org,mtrofin@chromium.org NOTRY=true NOPRESUBMIT=true Change-Id: I160b996a07d77f90a96864f3ae84f861f495ed42 Reviewed-on: https://chromium-review.googlesource.com/547425 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#46196} [modify] https://crrev.com/f7d60ab798a550f8f77cbfdbd297b9d76cfa7e4d/src/compiler/wasm-compiler.cc [modify] https://crrev.com/f7d60ab798a550f8f77cbfdbd297b9d76cfa7e4d/src/compiler/wasm-compiler.h [modify] https://crrev.com/f7d60ab798a550f8f77cbfdbd297b9d76cfa7e4d/src/counters.cc [modify] https://crrev.com/f7d60ab798a550f8f77cbfdbd297b9d76cfa7e4d/src/counters.h [modify] https://crrev.com/f7d60ab798a550f8f77cbfdbd297b9d76cfa7e4d/src/isolate.cc [modify] https://crrev.com/f7d60ab798a550f8f77cbfdbd297b9d76cfa7e4d/src/isolate.h [modify] https://crrev.com/f7d60ab798a550f8f77cbfdbd297b9d76cfa7e4d/src/wasm/module-compiler.cc [modify] https://crrev.com/f7d60ab798a550f8f77cbfdbd297b9d76cfa7e4d/src/wasm/module-compiler.h [modify] https://crrev.com/f7d60ab798a550f8f77cbfdbd297b9d76cfa7e4d/src/wasm/module-decoder.cc [modify] https://crrev.com/f7d60ab798a550f8f77cbfdbd297b9d76cfa7e4d/src/wasm/module-decoder.h [modify] https://crrev.com/f7d60ab798a550f8f77cbfdbd297b9d76cfa7e4d/src/wasm/wasm-module.cc [modify] https://crrev.com/f7d60ab798a550f8f77cbfdbd297b9d76cfa7e4d/src/wasm/wasm-module.h [modify] https://crrev.com/f7d60ab798a550f8f77cbfdbd297b9d76cfa7e4d/src/wasm/wasm-objects.cc [modify] https://crrev.com/f7d60ab798a550f8f77cbfdbd297b9d76cfa7e4d/test/cctest/test-api.cc [modify] https://crrev.com/f7d60ab798a550f8f77cbfdbd297b9d76cfa7e4d/test/common/wasm/wasm-module-runner.cc [modify] https://crrev.com/f7d60ab798a550f8f77cbfdbd297b9d76cfa7e4d/test/unittests/wasm/module-decoder-unittest.cc
,
Jun 26 2017
FYI: reverted roll for the record: https://codereview.chromium.org/2956753002/
,
Jun 26 2017
,
Jun 26 2017
The problem (based on the trace) is that ExecuteCompilation() is running in parallel, though the code claims it only runs on the main thread. This based on the fact that the HistogramTimer using a single ElapsedTimer, and ElapsedTimer::Start() fails if it is already started.
,
Jul 10 2017
Detected 4 new flakes for test/step "virtual/enable_wasm_streaming/http/tests/wasm_streaming/wasm_response_apis.html". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWgsSBUZsYWtlIk92aXJ0dWFsL2VuYWJsZV93YXNtX3N0cmVhbWluZy9odHRwL3Rlc3RzL3dhc21fc3RyZWFtaW5nL3dhc21fcmVzcG9uc2VfYXBpcy5odG1sDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Jul 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09714b52d330f9640afb74d20a2aa04ab78906ff commit 09714b52d330f9640afb74d20a2aa04ab78906ff Author: Bret Sepulveda <bsep@chromium.org> Date: Mon Jul 10 20:55:03 2017 Mark wasm_response_apis.html as crash-flaky. TBR=kschimpf@chromium.org Bug: 736676 Change-Id: Ib3b51e610eab6433d9de2d43f774bcdc5f1f9e43 Reviewed-on: https://chromium-review.googlesource.com/565419 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#485375} [modify] https://crrev.com/09714b52d330f9640afb74d20a2aa04ab78906ff/third_party/WebKit/LayoutTests/TestExpectations
,
Jul 10 2017
Removing from sheriff queue.
,
Jul 11 2017
Detected 6 new flakes for test/step "virtual/enable_wasm_streaming/http/tests/wasm_streaming/wasm_response_apis.html". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWgsSBUZsYWtlIk92aXJ0dWFsL2VuYWJsZV93YXNtX3N0cmVhbWluZy9odHRwL3Rlc3RzL3dhc21fc3RyZWFtaW5nL3dhc21fcmVzcG9uc2VfYXBpcy5odG1sDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Jul 13 2017
I believe that the flaky crashes mentioned in #9 were failures that happened before the flaky crash expectation was added, so I'll remove this from the sheriff queue once more. kschimpf@, what do you think will be the next thing to do here?
,
Jul 13 2017
I don't know. I'm not sure why I was assigned this. Assigning to Ben, who hopefully can find the right person to assign to.
,
Jul 17 2017
This might be a race in isolate shutdown during compilation. Assigning to ahaas@ to take a look, since he recently fixed many bugs in this area. (it might already be fixed now, in fact).
,
Jul 19 2017
This issue has been fixed in https://chromium-review.googlesource.com/c/559769/ The originally used HistogramTimerScope in wasm-compiler.cc is not thread-safe. In the cited CL this scope has been replaced with the thread-safe TimedHistogramScope.
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5f03e28168223953bc82a770eb7f6385ccdbe01 commit d5f03e28168223953bc82a770eb7f6385ccdbe01 Author: Andreas Haas <ahaas@chromium.org> Date: Thu Jul 20 06:49:20 2017 Enable wasm_response_apis.html again. The issue which made this test flaky has been fixed in https://chromium-review.googlesource.com/c/559769/, so we can turn this test on again. R=bsep@chromium.org Bug: chromium:736676 Change-Id: I423782d2cd1f299f40a70a1f1595b573fa7646c2 Reviewed-on: https://chromium-review.googlesource.com/576033 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#488153} [modify] https://crrev.com/d5f03e28168223953bc82a770eb7f6385ccdbe01/third_party/WebKit/LayoutTests/TestExpectations |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by tkent@chromium.org
, Jun 26 2017Status: Assigned (was: Untriaged)