https://cs.chromium.org/search/?q=frame.*Loader.*Client&type=cs i.e. code like frame->Loader().Client()->DidDispatchPingLoader(request.Url()); Should be frame->Client()->....
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7944b4df85629f79462c8992c63936fc6abee153 commit 7944b4df85629f79462c8992c63936fc6abee153 Author: Stuart Langley <slangley@chromium.org> Date: Tue Jun 27 06:39:45 2017 Replace use of frame->Loader().Client() with frame->Client(). Where possible also remove the header file, if there we no other usages of frame->Loader(). Bug: 736673 Change-Id: I2e6638c6fe65f9dd513f2bb6b5624a3a6e670864 Reviewed-on: https://chromium-review.googlesource.com/549755 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#482552} [modify] https://crrev.com/7944b4df85629f79462c8992c63936fc6abee153/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp [modify] https://crrev.com/7944b4df85629f79462c8992c63936fc6abee153/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp [modify] https://crrev.com/7944b4df85629f79462c8992c63936fc6abee153/third_party/WebKit/Source/core/dom/Document.cpp [modify] https://crrev.com/7944b4df85629f79462c8992c63936fc6abee153/third_party/WebKit/Source/core/exported/WebHelperPluginImpl.cpp [modify] https://crrev.com/7944b4df85629f79462c8992c63936fc6abee153/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp [modify] https://crrev.com/7944b4df85629f79462c8992c63936fc6abee153/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp [modify] https://crrev.com/7944b4df85629f79462c8992c63936fc6abee153/third_party/WebKit/Source/core/html/HTMLFormElement.cpp [modify] https://crrev.com/7944b4df85629f79462c8992c63936fc6abee153/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp [modify] https://crrev.com/7944b4df85629f79462c8992c63936fc6abee153/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/345e6018c68a0617d9e7e722e518c0c3c557b748 commit 345e6018c68a0617d9e7e722e518c0c3c557b748 Author: Stuart Langley <slangley@chromium.org> Date: Wed Jun 28 02:00:47 2017 Replace use of frame->Loader().Client() with frame->Client(). Bug: 736673 Change-Id: Ia37d2029a42c3623384857414a0e90169b9b7968 Reviewed-on: https://chromium-review.googlesource.com/551115 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#482851} [modify] https://crrev.com/345e6018c68a0617d9e7e722e518c0c3c557b748/third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp [modify] https://crrev.com/345e6018c68a0617d9e7e722e518c0c3c557b748/third_party/WebKit/Source/core/dom/UserGestureIndicator.cpp [modify] https://crrev.com/345e6018c68a0617d9e7e722e518c0c3c557b748/third_party/WebKit/Source/core/frame/History.cpp [modify] https://crrev.com/345e6018c68a0617d9e7e722e518c0c3c557b748/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp [modify] https://crrev.com/345e6018c68a0617d9e7e722e518c0c3c557b748/third_party/WebKit/Source/core/frame/LocalFrameView.cpp [modify] https://crrev.com/345e6018c68a0617d9e7e722e518c0c3c557b748/third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp [modify] https://crrev.com/345e6018c68a0617d9e7e722e518c0c3c557b748/third_party/WebKit/Source/core/html/HTMLFormControlElementWithState.cpp [modify] https://crrev.com/345e6018c68a0617d9e7e722e518c0c3c557b748/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f44495904991c7e2003d3301279ac7f897b4609d commit f44495904991c7e2003d3301279ac7f897b4609d Author: Stuart Langley <slangley@chromium.org> Date: Fri Jun 30 10:21:48 2017 Replace use of frame->Loader().Client() with frame->Client(). Make FrameLoader::Client() private so that it cannot be used to retrieve the LocalFrameClient in new cases anymore. Bug: 736673 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia890099ca6dc03babb296413c15adda66b460b00 Reviewed-on: https://chromium-review.googlesource.com/557559 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#483669} [modify] https://crrev.com/f44495904991c7e2003d3301279ac7f897b4609d/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp [modify] https://crrev.com/f44495904991c7e2003d3301279ac7f897b4609d/third_party/WebKit/Source/core/html/HTMLMetaElement.cpp [modify] https://crrev.com/f44495904991c7e2003d3301279ac7f897b4609d/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp [modify] https://crrev.com/f44495904991c7e2003d3301279ac7f897b4609d/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp [modify] https://crrev.com/f44495904991c7e2003d3301279ac7f897b4609d/third_party/WebKit/Source/core/html/LinkManifest.cpp [modify] https://crrev.com/f44495904991c7e2003d3301279ac7f897b4609d/third_party/WebKit/Source/core/html/LinkStyle.cpp [modify] https://crrev.com/f44495904991c7e2003d3301279ac7f897b4609d/third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp [modify] https://crrev.com/f44495904991c7e2003d3301279ac7f897b4609d/third_party/WebKit/Source/core/loader/CookieJar.cpp [modify] https://crrev.com/f44495904991c7e2003d3301279ac7f897b4609d/third_party/WebKit/Source/core/loader/FrameLoader.h [modify] https://crrev.com/f44495904991c7e2003d3301279ac7f897b4609d/third_party/WebKit/Source/core/loader/MixedContentChecker.cpp [modify] https://crrev.com/f44495904991c7e2003d3301279ac7f897b4609d/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp [modify] https://crrev.com/f44495904991c7e2003d3301279ac7f897b4609d/third_party/WebKit/Source/core/loader/PingLoader.cpp [modify] https://crrev.com/f44495904991c7e2003d3301279ac7f897b4609d/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp [modify] https://crrev.com/f44495904991c7e2003d3301279ac7f897b4609d/third_party/WebKit/Source/core/workers/SharedWorker.cpp [modify] https://crrev.com/f44495904991c7e2003d3301279ac7f897b4609d/third_party/WebKit/Source/core/xml/XSLTProcessor.cpp [modify] https://crrev.com/f44495904991c7e2003d3301279ac7f897b4609d/third_party/WebKit/Source/modules/donottrack/NavigatorDoNotTrack.cpp [modify] https://crrev.com/f44495904991c7e2003d3301279ac7f897b4609d/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp [modify] https://crrev.com/f44495904991c7e2003d3301279ac7f897b4609d/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerClient.cpp [modify] https://crrev.com/f44495904991c7e2003d3301279ac7f897b4609d/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp [modify] https://crrev.com/f44495904991c7e2003d3301279ac7f897b4609d/third_party/WebKit/Source/web/tests/LocalFrameClientImplTest.cpp
Comment 1 by bugdroid1@chromium.org
, Jun 27 2017