New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736670 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::CanBeScrolledIntoView

Project Member Reported by ClusterFuzz, Jun 25 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6100085825077248

Fuzzer: mbarbella_js_mutation_layout
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000018
Crash State:
  blink::CanBeScrolledIntoView
  blink::FocusController::FindFocusCandidateInContainer
  blink::FocusController::AdvanceFocusDirectionallyInContainer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=473072:473106

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6100085825077248


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 

Comment 1 by tkent@chromium.org, Jun 26 2017

Components: Blink>Focus

Comment 2 by kochi@chromium.org, Jun 26 2017

Owner: kochi@chromium.org
Status: Started (was: Untriaged)
Reproduces locally, taking a look.

Comment 3 by kochi@chromium.org, Jun 26 2017

Cc: hu...@opera.com kolc...@opera.com
Adding people who might be interested in spatial navigation.

Comment 4 by kochi@chromium.org, Jun 26 2017

Cc: kochi@chromium.org
Owner: eco...@igalia.com
Status: Assigned (was: Started)
Attaching manually cleaned up minimized test case.
This seems happening when a focused element is inside display:contents
container, and its layout object is null.

ecobos@, could you take a look?
min.html
735 bytes View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74228a3e7750f7065159b9aa00262b3cb5216972

commit 74228a3e7750f7065159b9aa00262b3cb5216972
Author: Emilio Cobos Álvarez <ecobos@igalia.com>
Date: Thu Jun 29 16:54:51 2017

Don't assume all the ancestors of the visible node have layout objects.

This is quite wrong in the presence of display: contents.

BUG= 736670 

Change-Id: I300e9a4cc9ef7acc4b767f7b955ef9c9779f9b14
Reviewed-on: https://chromium-review.googlesource.com/550255
Reviewed-by: Rune Lillesveen <rune@opera.com>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Emilio Cobos Álvarez <ecobos@igalia.com>
Cr-Commit-Position: refs/heads/master@{#483389}
[add] https://crrev.com/74228a3e7750f7065159b9aa00262b3cb5216972/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-display-contents-crash-expected.txt
[add] https://crrev.com/74228a3e7750f7065159b9aa00262b3cb5216972/third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-display-contents-crash.html
[modify] https://crrev.com/74228a3e7750f7065159b9aa00262b3cb5216972/third_party/WebKit/Source/core/page/SpatialNavigation.cpp

Comment 6 by eco...@igalia.com, Jun 29 2017

Status: Fixed (was: Assigned)
Project Member

Comment 7 by ClusterFuzz, Jun 30 2017

ClusterFuzz has detected this issue as fixed in range 483366:483401.

Detailed report: https://clusterfuzz.com/testcase?key=6100085825077248

Fuzzer: mbarbella_js_mutation_layout
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000018
Crash State:
  blink::CanBeScrolledIntoView
  blink::FocusController::FindFocusCandidateInContainer
  blink::FocusController::AdvanceFocusDirectionallyInContainer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=473072:473106
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=483366:483401

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6100085825077248


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Components: Blink>HTML>Focus
Components: -Blink>Focus

Sign in to add a comment