Rather than passing ownership by comment.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4eaf8ff5a55de1988e86e746e11f60a535078b68 commit 4eaf8ff5a55de1988e86e746e11f60a535078b68 Author: Daniel Cheng <dcheng@chromium.org> Date: Mon Jun 26 22:19:24 2017 Convert gfx::ImageSkia constructors to use std::unique_ptr. For now, leave the legacy constructors so that legacy usage can be incrementally converted. Bug: 736629 Change-Id: I858e0ac84b4231edcb7997e7bf5794b6ca0d55fc Reviewed-on: https://chromium-review.googlesource.com/547695 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#482433} [modify] https://crrev.com/4eaf8ff5a55de1988e86e746e11f60a535078b68/ui/gfx/image/image_skia.cc [modify] https://crrev.com/4eaf8ff5a55de1988e86e746e11f60a535078b68/ui/gfx/image/image_skia.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f975532f9d45b9016fd3512d581f59777c17b906 commit f975532f9d45b9016fd3512d581f59777c17b906 Author: Daniel Cheng <dcheng@chromium.org> Date: Wed Jun 28 05:05:40 2017 Remove ImageSkia(ImageSkiaSource*, float) overload. Instead, code should use the std::unique_ptr overload which clearly indicates ownership transfer. Bug: 736629 Change-Id: Icbec8e6ac96f81dfb717405b4273ec1214456257 Reviewed-on: https://chromium-review.googlesource.com/549515 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#482887} [modify] https://crrev.com/f975532f9d45b9016fd3512d581f59777c17b906/chrome/browser/themes/browser_theme_pack.cc [modify] https://crrev.com/f975532f9d45b9016fd3512d581f59777c17b906/chrome/browser/ui/libgtkui/gtk_ui.cc [modify] https://crrev.com/f975532f9d45b9016fd3512d581f59777c17b906/ui/base/resource/resource_bundle.cc [modify] https://crrev.com/f975532f9d45b9016fd3512d581f59777c17b906/ui/gfx/image/image_skia.cc [modify] https://crrev.com/f975532f9d45b9016fd3512d581f59777c17b906/ui/gfx/image/image_skia.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23eed1d94187c2ed6794b05708308ba8b729432f commit 23eed1d94187c2ed6794b05708308ba8b729432f Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Aug 18 02:42:31 2017 Remove legacy gfx::ImageSkia ctor that passes ownership by raw pointer. Bug: 736629 Change-Id: I553eb8f990d06824abebc141a9dfb6c47eced639 Reviewed-on: https://chromium-review.googlesource.com/612625 Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#495438} [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/ash/system/network/network_icon.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/ash/system/power/power_status.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/ash/wm/resize_shadow.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/chrome/browser/extensions/bookmark_app_helper.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/chrome/browser/extensions/chrome_app_icon.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/chrome/browser/profiles/profile_avatar_icon_util.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/chrome/browser/themes/browser_theme_pack.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/chrome/browser/ui/app_list/arc/arc_app_icon.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/chrome/browser/ui/app_list/arc/arc_app_icon.h [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/chrome/browser/ui/app_list/search/arc/arc_playstore_search_result.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/chrome/browser/ui/app_list/search/launcher_search/launcher_search_icon_image_loader_unittest.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/chrome/browser/ui/app_list/search/webstore/webstore_result.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/chrome/browser/ui/extensions/extension_action_view_controller.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/chrome/browser/ui/views/toolbar/app_menu.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/components/favicon_base/select_favicon_frames.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/extensions/browser/extension_icon_image.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/extensions/browser/extension_icon_image_unittest.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/extensions/browser/extension_icon_placeholder.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/ui/app_list/folder_image.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/ui/app_list/views/all_apps_tile_item_view.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/ui/app_list/views/tile_item_view.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/ui/gfx/image/canvas_image_source.h [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/ui/gfx/image/image_generic.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/ui/gfx/image/image_skia.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/ui/gfx/image/image_skia.h [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/ui/gfx/image/image_skia_operations.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/ui/gfx/image/image_skia_unittest.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/ui/gfx/image/mojo/image_traits_unittest.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/ui/gfx/paint_vector_icon.cc [modify] https://crrev.com/23eed1d94187c2ed6794b05708308ba8b729432f/ui/gfx/shadow_util.cc
Comment 1 by bugdroid1@chromium.org
, Jun 26 2017