Improve the "Add Source Map…" feature
Reported by
m...@nuragic.io,
Jun 24 2017
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36 Steps to reproduce the problem: Just try to add a source map for a "not so small" script, e.g. 1.5MB. What is the expected behavior? What went wrong? Currently, the process of adding an external source maps lacks of meaningful UI states, i.e. "loading, success, error". I think that is redundant to add more description on this... but basically, the app seems that is stuck, developers doesn't know if "is doing stuff, it worked, it crashed". ¯\_(ツ)_/¯ Additionally, I think that the first "modal" screen to add the URL could be improved, if a change to add these states is welcomed. Did this work before? N/A Chrome version: 58.0.3029.110 Channel: stable OS Version: OS X 10.10.5 Flash Version: Shockwave Flash 26.0 r0 I don't mind to work on this improvement, in fact it would be really cool for me; my only concern actually is that I'm not sure if this patch could be done totally on the front-end. If that is the case, then I'll definitely try to do it. Any help in the direction of finding the right files to touch, or whatever useful tip would be really appreciated. Thanks!
,
Jun 29 2017
Seems this is a feature request ,marking it as Untriaged to get more inputs from dev. Thanks..!!
,
Jul 3 2017
Thanks! Not really a feature IMHO, just improving an existing feature (not a bug tho so, well..). Anyway, let me know if you think I could start working on this. Cheers!
,
Jul 5 2017
,
Jul 5 2017
> I don't mind to work on this improvement, in fact it would be really cool for me; my only concern actually is that I'm not sure if this patch could be done totally on the front-end. This change would be front-end only. Sourcemaps are mainly managed here: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front_end/sdk/SourceMapManager.js?q=SourceMapManager&sq=package:chromium&dr=C&l=8 The progress for sourcemap loading could have been reported for all sourcemaps, not only the ones attached via the dialog. The modal dialog wouldn't be a good place to surface the progress then, SourceFrame's toolbar might be a better place. Let's start with some UI mocks which would satisfy everybody and then move in that direction.
,
Dec 6 2017
Looks like noone is interested in this anymore - closing for now.
,
Dec 16 2017
Oh :( I understand this is an old issue now, however I think it'd still be a really nice improvement... On my side I haven't made any progress yet... But I'd definitely like to give it a try as soon as I have some free time. Just moved this issue on top of my OSS contribution wish list for 2018 :) Thanks anyway! |
||||
►
Sign in to add a comment |
||||
Comment 1 by ranjitkan@chromium.org
, Jun 29 2017