New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736612 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference WRITE in gpu::ServiceDiscardableManager::OnTextureDeleted

Project Member Reported by ClusterFuzz, Jun 24 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4581327784640512

Fuzzer: libFuzzer_gpu_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Null-dereference WRITE
Crash Address: 0x000000000000
Crash State:
  gpu::ServiceDiscardableManager::OnTextureDeleted
  gpu::gles2::TextureRef::~TextureRef
  base::RefCounted<gpu::gles2::TextureRef>::Release
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=473011:473053

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4581327784640512


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: msrchandra@chromium.org
Components: Internals>GPU>Internals
Labels: M-60 Test-Predator-Correct-CLs
Owner: ericrk@chromium.org
Status: Assigned (was: Untriaged)
Assigning to the concern owner from Predator results --
The result is a list of CLs that change the crashed files. 

Author: ericrk
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src/+/dc5eeaa0a9a5a7f9ff83a82ab8896740736ffc6b
Time: Fri May 19 02:23:50 2017
Files service_discardable_manager.cc, texture_manager.cc are changed in this cl (and is part of stack frame #2, "gpu::ServiceDiscardableManager::OnTextureDeleted")
Minimum distance from crash line to modified line: 1. (file: texture_manager.cc, crashed on: 1899, modified: 1898).

@ericrk -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.

Comment 2 by piman@chromium.org, Jul 7 2017

Cc: piman@chromium.org
@ericrk: any idea?
I'll look into this more later today or on monday - nothing is obvious from a quick glance at the code.
Actually, this should be fixed with: https://chromium.googlesource.com/chromium/src/+/838072e44f3a5d5856660d48837689d51eb18100

same issue as  crbug.com/725101 

Does this need to merge to Beta?

Comment 5 by piman@chromium.org, Jul 7 2017

It looks like CF hasn't run this test case since 476905, which doesn't include your CL, so it may be that it is fixed and CF doesn't know yet. Worth checking manually if it doesn't close it.

Re merging: yes we should, since otherwise we would introduce a new security vulnerability.
Project Member

Comment 6 by ClusterFuzz, Jul 8 2017

ClusterFuzz has detected this issue as fixed in range 476905:485054.

Detailed report: https://clusterfuzz.com/testcase?key=4581327784640512

Fuzzer: libFuzzer_gpu_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Null-dereference WRITE
Crash Address: 0x000000000000
Crash State:
  gpu::ServiceDiscardableManager::OnTextureDeleted
  gpu::gles2::TextureRef::~TextureRef
  base::RefCounted<gpu::gles2::TextureRef>::Release
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=473011:473053
Fixed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=476905:485054

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4581327784640512


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Jul 8 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4581327784640512 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment