[Media Router] Clean up PresentationServiceDelegateImpl |
|||
Issue description- There are some method declarations that no longer have a definition. They should be removed. - We should get rid of PresentationFrameManager. The role of this object is just to delegate calls from PresentationServiceDelegateImpl to a PresentationFrame object. Moreover, the state of Presentation API on the WebContents level (e.g. default presentation request) is split across PSDImpl and PFM. We can get rid of a lot of boilerplate code if we combine them.
,
Jul 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22578daaf51705107a2519f0209e9ceec3358a38 commit 22578daaf51705107a2519f0209e9ceec3358a38 Author: imcheng <imcheng@chromium.org> Date: Tue Jul 11 23:09:11 2017 [Media Router] Move main frame check for SetDefaultPresentationUrls. Move the check to PSImpl since we are already doing a main frame check there and it's slightly simpler. BUG= 736557 Review-Url: https://codereview.chromium.org/2972933002 Cr-Commit-Position: refs/heads/master@{#485724} [modify] https://crrev.com/22578daaf51705107a2519f0209e9ceec3358a38/chrome/browser/media/router/presentation_service_delegate_impl.cc [modify] https://crrev.com/22578daaf51705107a2519f0209e9ceec3358a38/chrome/browser/media/router/presentation_service_delegate_impl.h [modify] https://crrev.com/22578daaf51705107a2519f0209e9ceec3358a38/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc [modify] https://crrev.com/22578daaf51705107a2519f0209e9ceec3358a38/content/browser/presentation/presentation_service_impl.cc [modify] https://crrev.com/22578daaf51705107a2519f0209e9ceec3358a38/content/browser/presentation/presentation_service_impl.h [modify] https://crrev.com/22578daaf51705107a2519f0209e9ceec3358a38/content/browser/presentation/presentation_service_impl_unittest.cc
,
Jul 12 2017
,
Sep 7 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jul 10 2017