New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736557 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Media Router] Clean up PresentationServiceDelegateImpl

Project Member Reported by imch...@chromium.org, Jun 24 2017

Issue description

- There are some method declarations that no longer have a definition. They should be removed.
- We should get rid of PresentationFrameManager. The role of this object is just to delegate calls from PresentationServiceDelegateImpl to a PresentationFrame object. Moreover, the state of Presentation API on the WebContents level (e.g. default presentation request) is split across PSDImpl and PFM. We can get rid of a lot of boilerplate code if we combine them. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f23b896efce3a6ea139d29efd791bc09974def9f

commit f23b896efce3a6ea139d29efd791bc09974def9f
Author: imcheng <imcheng@chromium.org>
Date: Mon Jul 10 23:01:56 2017

[MediaRouter] PresentationServiceDelegateImpl cleanup.

- Removed method declarations that are not defined.
- Removed PresentationFrameManager. There is not much reason to keep
  it since most of the logic is just delegating from PSDImpl.
- Push the URL validity check for screen availability to PSImpl.

BUG= 736557 

Review-Url: https://codereview.chromium.org/2958663002
Cr-Commit-Position: refs/heads/master@{#485437}

[modify] https://crrev.com/f23b896efce3a6ea139d29efd791bc09974def9f/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/f23b896efce3a6ea139d29efd791bc09974def9f/chrome/browser/media/router/presentation_service_delegate_impl.h
[modify] https://crrev.com/f23b896efce3a6ea139d29efd791bc09974def9f/content/browser/presentation/presentation_service_impl.cc

Status: Started (was: Untriaged)
Status: Fixed (was: Started)

Sign in to add a comment