Checkboxes changed alignment when checked vs unchecked |
||
Issue descriptionI remember encountering this bug when I first tried to make the CSS checkbox styles. I originally fixed this by making sure the text content of the checkbox existed even when the checkbox was unchecked. The check was hidden by being the same color as the background color of the checkbox. But that caused problems on Chrome OS because the font colors of the checks did not properly change. So now the alignment issue is back.
,
Jul 12 2017
The file you'd want to modify for this is som-input-styles, which contains the CSS for checkboxes (and other things): https://cs.chromium.org/chromium/infra/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-input-styles.html For reference, this is also the template where you see the unaligned checkbox: https://cs.chromium.org/chromium/infra/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-test-expectations/som-edit-expectation-form.html It's possible that you could solve this bug more quickly by adjusting the way the checkboxes are displayed on this form though editing the checkboxes themselves is preferable, so that the checkboxes don't work differently depending on how they're displayed.
,
Dec 14 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by zhangtiff@chromium.org
, Jul 12 2017