New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736539 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

MD scrollbar (overlayscrollbar) does not support RTL

Project Member Reported by osh...@chromium.org, Jun 23 2017

Issue description

looks like it's not supported yet?
 
VID_20170623_133259.mp4
6.2 MB View Download
Cc: bokan@chromium.org est...@chromium.org
Owner: tbuck...@chromium.org
+tbuckley@ please take a look - estade@ is OOO and I have not been following overlay scrollbar.

+bokan@ FYI.

Comment 2 by bokan@chromium.org, Jun 26 2017

Note that this is only in Views. Web content RTL scrollbars work as expected.

Comment 3 by est...@chromium.org, Jul 10 2017

Owner: est...@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1af288ffe243af44a563267836e44db8fa7e626

commit d1af288ffe243af44a563267836e44db8fa7e626
Author: Evan Stade <estade@chromium.org>
Date: Wed Jul 12 06:36:54 2017

Fix appearance of Views native overlay scrollbars for RTL.

Bug:  736539 
Change-Id: I7ae1d4f48f613fb5b2526755d7282ced7f424b23
Reviewed-on: https://chromium-review.googlesource.com/567200
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485879}
[modify] https://crrev.com/d1af288ffe243af44a563267836e44db8fa7e626/ui/views/controls/scrollbar/overlay_scroll_bar.cc

Comment 5 by est...@chromium.org, Jul 12 2017

Labels: M-60 Merge-Request-60
two line fix, should be safe to merge.
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 12 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by est...@chromium.org, Jul 13 2017

Cc: josa...@chromium.org
+josafat, wdyt?
Labels: -Merge-Review-60 Merge-Approved-60
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 17 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c69b6d2c58f0ea7cff0478d6aa9381f6821240ca

commit c69b6d2c58f0ea7cff0478d6aa9381f6821240ca
Author: Evan Stade <estade@chromium.org>
Date: Mon Jul 17 20:18:18 2017

Fix appearance of Views native overlay scrollbars for RTL.

TBR=estade@chromium.org

(cherry picked from commit d1af288ffe243af44a563267836e44db8fa7e626)

Bug:  736539 
Change-Id: I7ae1d4f48f613fb5b2526755d7282ced7f424b23
Reviewed-on: https://chromium-review.googlesource.com/567200
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#485879}
Reviewed-on: https://chromium-review.googlesource.com/575367
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#622}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/c69b6d2c58f0ea7cff0478d6aa9381f6821240ca/ui/views/controls/scrollbar/overlay_scroll_bar.cc

Status: Fixed (was: Assigned)

Comment 11 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment