Fix VR NFC flakiness in tests |
|||||
Issue descriptionOccasionally, VR end-to-end tests using NFC fail due to VrCore thinking that it's still in VR from the previous test. b/62959595 has been filed to fix this on VrCore's end, but in the meantime, @RetryOnFailure should be sufficient to prevent visible flakiness due to this.
,
Nov 17 2017
,
Feb 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b1109ab0cd74dabb255f79029326f1ddbae6349 commit 2b1109ab0cd74dabb255f79029326f1ddbae6349 Author: bsheedy <bsheedy@chromium.org> Date: Fri Feb 16 17:37:35 2018 Reduce VR NFC flakiness Adds simNfcScanUntilVrEntered, which in most cases, replaces simNfcScan. This is to deal with flakiness that stems from VrCore thinking that it's still in VR from a previous test and nooping when it receives an NFC scan in a following test. Bug: 736527, 812306 Change-Id: If7b135b99df03c463f5b393bfbe6290e06d0ee4e Reviewed-on: https://chromium-review.googlesource.com/923099 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#537342} [modify] https://crrev.com/2b1109ab0cd74dabb255f79029326f1ddbae6349/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTransitionTest.java [modify] https://crrev.com/2b1109ab0cd74dabb255f79029326f1ddbae6349/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTransitionTest.java [modify] https://crrev.com/2b1109ab0cd74dabb255f79029326f1ddbae6349/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/NfcSimUtils.java [modify] https://crrev.com/2b1109ab0cd74dabb255f79029326f1ddbae6349/chrome/test/data/vr/e2e_test_files/html/test_nfc_fires_vrdisplayactivate.html
,
Feb 16 2018
,
Jul 4
,
Aug 7
Removing Internals>VR component and remapping to Internals>XR
,
Aug 7
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jun 24 2017