New issue
Advanced search Search tips

Issue 736518 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: ----

Blocked on:
issue 736697

Blocking:
issue 575762



Sign in to add a comment

Remove old service_worker.service_worker/service_worker.service_worker_micro_benchmark

Project Member Reported by martiniss@chromium.org, Jun 23 2017

Issue description

service_worker.service_worker failing on chromium.perf/Android One Perf

Builders failed on: 
- Android One Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf


https://chromium-swarm.appspot.com/task?id=36ee1924a7805c10&refresh=10&show_raw=1 is a swarming task.

Screenshot shows what I assume is the page.

This exception is in the log:


Traceback (most recent call last):
  RunBenchmark at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py:398
    expectations=expectations, metadata=benchmark.GetMetadata())
  Run at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py:262
    _RunStoryAndProcessErrorIfNeeded(story, results, state, test)
  _RunStoryAndProcessErrorIfNeeded at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py:99
    state.RunStory(results)
  traced_function at /b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52
    return func(*args, **kwargs)
  RunStory at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py:298
    self._current_page, self._current_tab, results)
  traced_function at /b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:75
    return func(*args, **kwargs)
  ValidateAndMeasurePage at /b/swarming/w/ir/tools/perf/benchmarks/service_worker.py:132
    self._speed_index.Stop(page, tab)
  Stop at /b/swarming/w/ir/tools/perf/metrics/speedindex.py:50
    self._impl.Stop(tab)
  Stop at /b/swarming/w/ir/tools/perf/metrics/speedindex.py:171
    for time, image in video_capture.GetVideoFrameIter()
  GetVideoFrameIter at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/image_processing/video.py:55
    bmp, HIGHLIGHT_ORANGE_FRAME)
  _FindHighlightBoundingBox at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/image_processing/video.py:91
    raise BoundingBoxNotFoundException('Unexpectedly small tab contents.')
BoundingBoxNotFoundException: Unexpectedly small tab contents.


Disabling the story.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/692bb340fb882df919868851269cfec459aeb64b

commit 692bb340fb882df919868851269cfec459aeb64b
Author: Stephen Martinis <martiniss@chromium.org>
Date: Sat Jun 24 00:08:21 2017

Disable service worker perf test story

TBR=nednguyen

Bug:  736518 
Change-Id: I94648e6b76f802bf73f4ff7a132e011d0054cfae
Reviewed-on: https://chromium-review.googlesource.com/546860
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482083}
[modify] https://crrev.com/692bb340fb882df919868851269cfec459aeb64b/tools/perf/page_sets/service_worker.py

Comment 2 by horo@chromium.org, Jun 26 2017

Components: Blink>ServiceWorker

Comment 3 by horo@chromium.org, Jun 26 2017

Components: Speed>Benchmarks
Labels: -Pri-1 Pri-3
I don't know why speedindex is failing only on Android One....
Does anyone know?

But anyway, we Service Worker team is going to add new tests using FCP/FMP (first conteful/meanungful paint), and remove the test which is the only user of speedindex under tools/perf/benchmarks/.

Comment 4 by horo@chromium.org, Jun 26 2017

Cc: nednguyen@chromium.org
Created  Issue 736697  for adding new pref tests part.
Blockedon: 736697
Summary: Remove old service_worker.service_worker/service_worker.service_worker_micro_benchmark (was: service_worker.service_worker failing on chromium.perf/Android One Perf)
Finally we can remove the old perf tests.
Let me update the title of this issue.
Cc: -nednguyen@chromium.org falken@chromium.org shimazu@chromium.org horo@chromium.org
Owner: nedngu...@google.com
I will do the removal then.
Blocking: 575762
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0532cd6912926a6292fc99240116d5012e5673a1

commit 0532cd6912926a6292fc99240116d5012e5673a1
Author: Ned Nguyen <nednguyen@google.com>
Date: Tue Oct 03 11:41:22 2017

Remove legacy service_worker benchmarks

Bug:  736518 
Change-Id: I7bcfb394dd39c55dac1d1e11daf579ed02544e99
Reviewed-on: https://chromium-review.googlesource.com/695443
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#506009}
[modify] https://crrev.com/0532cd6912926a6292fc99240116d5012e5673a1/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/0532cd6912926a6292fc99240116d5012e5673a1/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/0532cd6912926a6292fc99240116d5012e5673a1/tools/perf/benchmark.csv
[delete] https://crrev.com/d347de2821e61cbbb5fc506681d54bb869a0efdf/tools/perf/benchmarks/service_worker.py
[delete] https://crrev.com/d347de2821e61cbbb5fc506681d54bb869a0efdf/tools/perf/page_sets/data/service_worker.json
[delete] https://crrev.com/d347de2821e61cbbb5fc506681d54bb869a0efdf/tools/perf/page_sets/data/service_worker_038.wprgo.sha1
[delete] https://crrev.com/d347de2821e61cbbb5fc506681d54bb869a0efdf/tools/perf/page_sets/data/service_worker_040.wprgo.sha1
[delete] https://crrev.com/d347de2821e61cbbb5fc506681d54bb869a0efdf/tools/perf/page_sets/data/service_worker_micro_benchmark_004.wprgo.sha1
[delete] https://crrev.com/d347de2821e61cbbb5fc506681d54bb869a0efdf/tools/perf/page_sets/service_worker.py

Status: Fixed (was: Assigned)

Sign in to add a comment