Remove old service_worker.service_worker/service_worker.service_worker_micro_benchmark |
|||||||||
Issue descriptionservice_worker.service_worker failing on chromium.perf/Android One Perf Builders failed on: - Android One Perf: https://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf https://chromium-swarm.appspot.com/task?id=36ee1924a7805c10&refresh=10&show_raw=1 is a swarming task. Screenshot shows what I assume is the page. This exception is in the log: Traceback (most recent call last): RunBenchmark at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py:398 expectations=expectations, metadata=benchmark.GetMetadata()) Run at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py:262 _RunStoryAndProcessErrorIfNeeded(story, results, state, test) _RunStoryAndProcessErrorIfNeeded at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py:99 state.RunStory(results) traced_function at /b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52 return func(*args, **kwargs) RunStory at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py:298 self._current_page, self._current_tab, results) traced_function at /b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:75 return func(*args, **kwargs) ValidateAndMeasurePage at /b/swarming/w/ir/tools/perf/benchmarks/service_worker.py:132 self._speed_index.Stop(page, tab) Stop at /b/swarming/w/ir/tools/perf/metrics/speedindex.py:50 self._impl.Stop(tab) Stop at /b/swarming/w/ir/tools/perf/metrics/speedindex.py:171 for time, image in video_capture.GetVideoFrameIter() GetVideoFrameIter at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/image_processing/video.py:55 bmp, HIGHLIGHT_ORANGE_FRAME) _FindHighlightBoundingBox at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/image_processing/video.py:91 raise BoundingBoxNotFoundException('Unexpectedly small tab contents.') BoundingBoxNotFoundException: Unexpectedly small tab contents. Disabling the story.
,
Jun 26 2017
,
Jun 26 2017
I don't know why speedindex is failing only on Android One.... Does anyone know? But anyway, we Service Worker team is going to add new tests using FCP/FMP (first conteful/meanungful paint), and remove the test which is the only user of speedindex under tools/perf/benchmarks/.
,
Jun 26 2017
,
Jun 26 2017
Created Issue 736697 for adding new pref tests part.
,
Jun 26 2017
,
Oct 2 2017
Finally we can remove the old perf tests. Let me update the title of this issue.
,
Oct 2 2017
I will do the removal then.
,
Oct 2 2017
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0532cd6912926a6292fc99240116d5012e5673a1 commit 0532cd6912926a6292fc99240116d5012e5673a1 Author: Ned Nguyen <nednguyen@google.com> Date: Tue Oct 03 11:41:22 2017 Remove legacy service_worker benchmarks Bug: 736518 Change-Id: I7bcfb394dd39c55dac1d1e11daf579ed02544e99 Reviewed-on: https://chromium-review.googlesource.com/695443 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#506009} [modify] https://crrev.com/0532cd6912926a6292fc99240116d5012e5673a1/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/0532cd6912926a6292fc99240116d5012e5673a1/testing/buildbot/chromium.perf.json [modify] https://crrev.com/0532cd6912926a6292fc99240116d5012e5673a1/tools/perf/benchmark.csv [delete] https://crrev.com/d347de2821e61cbbb5fc506681d54bb869a0efdf/tools/perf/benchmarks/service_worker.py [delete] https://crrev.com/d347de2821e61cbbb5fc506681d54bb869a0efdf/tools/perf/page_sets/data/service_worker.json [delete] https://crrev.com/d347de2821e61cbbb5fc506681d54bb869a0efdf/tools/perf/page_sets/data/service_worker_038.wprgo.sha1 [delete] https://crrev.com/d347de2821e61cbbb5fc506681d54bb869a0efdf/tools/perf/page_sets/data/service_worker_040.wprgo.sha1 [delete] https://crrev.com/d347de2821e61cbbb5fc506681d54bb869a0efdf/tools/perf/page_sets/data/service_worker_micro_benchmark_004.wprgo.sha1 [delete] https://crrev.com/d347de2821e61cbbb5fc506681d54bb869a0efdf/tools/perf/page_sets/service_worker.py
,
Oct 10 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Jun 24 2017