New issue
Advanced search Search tips

Issue 736514 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 746475
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove notion of "OverlayMode" from FullscreenManager.java

Project Member Reported by tguilbert@chromium.org, Jun 23 2017

Issue description

Currently, FullscreenManager.isOverlayVideoMode() is used in ContextualSearchManager and chromeFullscreenManager.shouldShowNotificationToast(). It appears as though the intended usage of isOverlayVideoMode() is to determine whether or not there is a fullscreen video being displayed onscreen.
However, what the method actually does is return whether or not we are using a ContentVideoView. This means that, when a div containing a video player is fullscreened (rather than fullscreening the player itself), ContextualSearchManager and shouldShowNotificationToast might not behave in the expected way.

The introduction of AndroidOverlays as a replacement to ContentVideoView means that isOverlayVideoMode() would no longer be useful at all.

This bug's goal is to identify the original intended usage of isOverlayVideoMode and to replace it with a more reliable signal
 
This bug also tracks changes to ChromeTabbedActivity.isFullscreenVideoPlaying()
Summary: Remove notion of "OverlayMode" from FullscreenManager.java (was: Update usage of isOverlayVideoMode)
This bug also tracks deprecating onToggleOverlayVideoMode()
Cc: liber...@chromium.org
Mergedinto: 746475
Status: Duplicate (was: Untriaged)

Sign in to add a comment