New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736499 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
OOO until 2019-01-24
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 712584



Sign in to add a comment

Remove restriction on CopyTexImage2D to RGB16F and RGB32F textures

Project Member Reported by kbr@chromium.org, Jun 23 2017

Issue description

In https://github.com/KhronosGroup/WebGL/pull/2426 the restriction on performing CopyTexImage to RGB16F and RGB32F textures is going to be lifted. (It was too stringent in the first place.) Need to remove this from the code.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/867f5de0dfe3bda722222177ad53c17f91568a4b

commit 867f5de0dfe3bda722222177ad53c17f91568a4b
Author: Ken Russell <kbr@chromium.org>
Date: Sat Jun 24 00:55:11 2017

Allow RGB16F and RGB32F in CopyTexImage2D with EXT_color_buffer_float.

BUG= 736499 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia76339e153b34814d5d491929cae46fd27e66df0
Reviewed-on: https://chromium-review.googlesource.com/547044
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482099}
[modify] https://crrev.com/867f5de0dfe3bda722222177ad53c17f91568a4b/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/867f5de0dfe3bda722222177ad53c17f91568a4b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a58703a885159856b5bce37a4c7798a7c481ae39

commit a58703a885159856b5bce37a4c7798a7c481ae39
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri Jul 07 04:31:43 2017

Roll WebGL 9ffa3b5..5e57726

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/9ffa3b5..5e57726

BUG= 731324 ,  735784 ,  736499 ,  739604 ,  angleproject:2095 
TBR=kainino@chromium.org
TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: Ie2ef09eaf2087059d1c3dd190c4098993cd7ec61
Reviewed-on: https://chromium-review.googlesource.com/562857
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484832}
[modify] https://crrev.com/a58703a885159856b5bce37a4c7798a7c481ae39/DEPS
[modify] https://crrev.com/a58703a885159856b5bce37a4c7798a7c481ae39/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/a58703a885159856b5bce37a4c7798a7c481ae39/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
[modify] https://crrev.com/a58703a885159856b5bce37a4c7798a7c481ae39/content/test/gpu/gpu_tests/webgl_conformance_revision.txt

Comment 3 by kbr@chromium.org, Jul 7 2017

Status: Fixed (was: Started)
The revised test is enabled, and passing everywhere.

Sign in to add a comment