It crashes at: https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofill_metrics.cc?sq=package:chromium&dr&l=1341

Reason to crash:
AutofillManager::Reset() is called before ukm logging.

Code reference:
Reset() will clear ukm_logger:
https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofill_manager.cc?sq=package:chromium&l=1565
Ultimately, UploadFormDataAsyncCallback() will call ukm_logger form submit:
https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofill_manager.cc?sq=package:chromium&dr&l=1526
Commons described that reset may call first:
https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofill_manager.cc?sq=package:chromium&dr&l=1516

introduced by https://codereview.chromium.org/2800853004/patch/260001/270006
working on a fix.

Looks like this is a DCHECK only, Shanfeng? Any other weird side effects for non-debug builds?

No user visible effect for non-debug builds. The only effect is: ukm MillisecondsSinceFormParsed will not be logged.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0

commit 8cb89860cd0ccf1c02373ab5ecd40a31f9020af0
Author: Shanfeng Zhang <szhangcs@google.com>
Date: Fri Jul 21 02:37:04 2017

Move form_parsed_timestamp out of autofill_metrics and put in form_structure.

This will issue of using FormInteractionsUkmLogger in AutofillManager: AutofillManager.Reset() may be called before logging the metrics, which will make FormParsedTimeStamp null when logging the metrics.
This fix will keep FormParsedTimeStamp in form_structure and explicitly pass the FormParsedTimeStamp in the callback.

We have to make full_card_request take form_parsed_timestamp and pass it back to autofill_manager.OnFullCardRequestSucceeded. Since the time stamp may be destructed or overrided by another form interaction.

Bug:  736495 
Change-Id: I0068db7bb8c3681937aac9736c1bad0d15b43928

TBR=jochen

Change-Id: I0068db7bb8c3681937aac9736c1bad0d15b43928
Reviewed-on: https://chromium-review.googlesource.com/549026
Commit-Queue: Shanfeng Zhang <szhangcs@google.com>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: mahmadi <mahmadi@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488558}
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/autofill_assistant.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/autofill_assistant.h
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/form_structure.h
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/payments/full_card_request.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/payments/full_card_request.h
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/payments/full_card_request_unittest.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/payments/content/payment_request_state_unittest.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/payments/core/BUILD.gn
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/payments/core/DEPS
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/payments/core/autofill_payment_instrument.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/payments/core/autofill_payment_instrument.h
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/payments/core/autofill_payment_instrument_unittest.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/payments/core/test_payment_request_delegate.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/payments/core/test_payment_request_delegate.h
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/ios/chrome/browser/ui/payments/full_card_requester_unittest.mm