New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736495 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Chromium crashes after form submit

Project Member Reported by szhangcs@google.com, Jun 23 2017

Issue description

Chrome Version: Chromium local build
OS: Android

What steps will reproduce the problem?
(1) Go to https://dump-truck.appspot.com/usecase-address_and_cc_on_same_page/address_and_cc.html
(2) Click on credit card number field and a dropdown of suggestions will show up. Click on one suggestion.
(3) Click submit

What is the expected result?
Chrome will not crash.

What happens instead?
Chrome crashes.

 

Comment 1 by szhangcs@google.com, Jun 23 2017

Description: Show this description

Comment 3 by szhangcs@google.com, Jun 23 2017

introduced by https://codereview.chromium.org/2800853004/patch/260001/270006
working on a fix.

Comment 4 by ma...@chromium.org, Jun 25 2017

Looks like this is a DCHECK only, Shanfeng? Any other weird side effects for non-debug builds?

Comment 5 by szhangcs@google.com, Jun 26 2017

No user visible effect for non-debug builds. The only effect is: ukm MillisecondsSinceFormParsed will not be logged.
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 12 2017

Labels: Hotlist-Google
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0

commit 8cb89860cd0ccf1c02373ab5ecd40a31f9020af0
Author: Shanfeng Zhang <szhangcs@google.com>
Date: Fri Jul 21 02:37:04 2017

Move form_parsed_timestamp out of autofill_metrics and put in form_structure.

This will issue of using FormInteractionsUkmLogger in AutofillManager: AutofillManager.Reset() may be called before logging the metrics, which will make FormParsedTimeStamp null when logging the metrics.
This fix will keep FormParsedTimeStamp in form_structure and explicitly pass the FormParsedTimeStamp in the callback.

We have to make full_card_request take form_parsed_timestamp and pass it back to autofill_manager.OnFullCardRequestSucceeded. Since the time stamp may be destructed or overrided by another form interaction.

Bug:  736495 
Change-Id: I0068db7bb8c3681937aac9736c1bad0d15b43928

TBR=jochen

Change-Id: I0068db7bb8c3681937aac9736c1bad0d15b43928
Reviewed-on: https://chromium-review.googlesource.com/549026
Commit-Queue: Shanfeng Zhang <szhangcs@google.com>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: mahmadi <mahmadi@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488558}
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/chrome/browser/autofill/android/personal_data_manager_android.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/autofill_assistant.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/autofill_assistant.h
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/form_structure.h
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/payments/full_card_request.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/payments/full_card_request.h
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/autofill/core/browser/payments/full_card_request_unittest.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/payments/content/payment_request_state_unittest.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/payments/core/BUILD.gn
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/payments/core/DEPS
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/payments/core/autofill_payment_instrument.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/payments/core/autofill_payment_instrument.h
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/payments/core/autofill_payment_instrument_unittest.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/payments/core/test_payment_request_delegate.cc
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/components/payments/core/test_payment_request_delegate.h
[modify] https://crrev.com/8cb89860cd0ccf1c02373ab5ecd40a31f9020af0/ios/chrome/browser/ui/payments/full_card_requester_unittest.mm

Comment 8 by szhangcs@google.com, Jan 11 2018

Status: Fixed (was: Started)

Sign in to add a comment