Long press on Link & Share -Share popup menu is not displayed |
||||||||||||
Issue descriptioniOS Version: 11 Device: iPad Only URL: NA App Version: 60.0.3112.42 beta Steps to reproduce: 1. Launch app 2. Navigate to the Google.com 3. Search for images 4. Tap on any images tab 5. Long Tap on any images 6. Tap on Share Mail or Share Notepad Observed results: Share popup menu is not displayed at all Expected results: Share popup should be displayed at all the times Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: No , Safari: No Bug reproducible on current stable build (App Version, iOS Version): Yes M59 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes M60 Link to video: iOS 11 Device: https://drive.google.com/a/google.com/file/d/0BwSBFDzHIX-mWUJFcS1BTDlWeDg/view iOS 10 Video: Image share: https://drive.google.com/a/google.com/file/d/0BwSBFDzHIX-mY04xV2N4WlRIWjg/view
,
Jun 28 2017
,
Jul 7 2017
I'm not sure what is correct here. Why does 'Add to Reading List' show up? Is this even the right context menu? eugenebut@ does this look correct?
,
Jul 7 2017
,
Jul 7 2017
Showing wrong context menu is not specific to iOS11. It is reproduced on iOS10 as well. Also note this context menu is only seen in the first page of the Google Image search results page. ie for example: Search "Tiger" in omnibox Tap on "Images" corpus Long tap on any image tile --> Wrong context menu Open any Image Scroll the page a little bit Now tap on any image tile in this page --> Correct context menu displayed.
,
Jul 7 2017
This image has -webkit-touch-callout CSS style set to none to explicitly suppress context menu, and Chrome respects that. However WKWebView ignores -webkit-touch-callout value and shows own context menu anyway. I believe that WKWebView works as intended because -webkit-touch-callout is a non-standard style and Chrome should ignore it as well: https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-touch-callout Danyao, do you think we should start ignoring -webkit-touch-callout for context menus?
,
Jul 12 2017
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d20784e63c9af1b0de4af1e35e1fc7b387b33a01 commit d20784e63c9af1b0de4af1e35e1fc7b387b33a01 Author: Eugene But <eugenebut@google.com> Date: Tue Jul 18 22:36:38 2017 Created constants for keys used in __gCrWeb.getElementFromPoint. Bug: 736480 Change-Id: Ia26ce365ebe41af525e74a805da1b139eb43dc85 Reviewed-on: https://chromium-review.googlesource.com/576145 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#487628} [modify] https://crrev.com/d20784e63c9af1b0de4af1e35e1fc7b387b33a01/ios/web/BUILD.gn [add] https://crrev.com/d20784e63c9af1b0de4af1e35e1fc7b387b33a01/ios/web/web_state/context_menu_constants.h [add] https://crrev.com/d20784e63c9af1b0de4af1e35e1fc7b387b33a01/ios/web/web_state/context_menu_constants.mm [modify] https://crrev.com/d20784e63c9af1b0de4af1e35e1fc7b387b33a01/ios/web/web_state/context_menu_params_utils.mm [modify] https://crrev.com/d20784e63c9af1b0de4af1e35e1fc7b387b33a01/ios/web/web_state/context_menu_params_utils_unittest.mm [modify] https://crrev.com/d20784e63c9af1b0de4af1e35e1fc7b387b33a01/ios/web/web_state/js/context_menu_js_unittest.mm [modify] https://crrev.com/d20784e63c9af1b0de4af1e35e1fc7b387b33a01/ios/web/web_state/ui/crw_context_menu_controller.mm
,
Jul 19 2017
This is actually a bug in Chrome for iOS code, which can be reproduced with this page:
<html>
<body>
<a href="https://www.chromium.org">
<img src="" style="width: 190px; height: 190px; display:block; -webkit-touch-callout:none;">
</a>
</body>
</html>
-webkit-touch-callout:none; is defined for an image, while Chrome still should present context menu for <a> tag.
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e1006abbefd607f3aa0c6708335746939640b5b commit 1e1006abbefd607f3aa0c6708335746939640b5b Author: Eugene But <eugenebut@google.com> Date: Thu Jul 20 21:52:10 2017 Fixed context menu handling for -webkit-touch-callout styled elements. Context menu is sometimes invoked for parent elements. f.e. a link can be a parent element of an image and even though user has pressed on the image, context menu is still shown for link, not for image. This CL checks -webkit-touch-callout style on element it is about to present a menu for (which can be a parent). Before the change -webkit-touch-callout was always checked for a parent causing system context menu to show up. Bug: 736480 Change-Id: I9239d75a1bfd9926dd67d1c742763c56837b0c38 Reviewed-on: https://chromium-review.googlesource.com/578215 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#488423} [modify] https://crrev.com/1e1006abbefd607f3aa0c6708335746939640b5b/ios/web/web_state/js/context_menu_js_unittest.mm [modify] https://crrev.com/1e1006abbefd607f3aa0c6708335746939640b5b/ios/web/web_state/js/resources/context_menu.js
,
Jul 20 2017
,
Jul 25 2017
Tested on latest M62.0.3166.0 canary build on iPad Air(iOS 11) and iPad (iOS 10). Followed the steps mentioned in Comment#0, the context menu displayed in first page (Google Image search results page) is different in iOS10 and iOS11. Please suggest which OS is displaying correct. iOS 9/10 Context menu items: Open in New Tab, Open in new Incognito Tab, Copy Link URL iOS 11 Context menu items: Open, Add to Reading List, Copy, Share Videos: iOS 10 behavior: https://drive.google.com/a/google.com/file/d/0B6nZ3QPCkSVcck44SEdwZVZkcVk/view?usp=sharing iOS 11 behavior: https://drive.google.com/a/google.com/file/d/0B6nZ3QPCkSVcdkR3THFuamdWbk0/view?usp=sharing
,
Jul 25 2017
Fixed for iOS 9/10 (Chrome menu is displayed). Still an issue for iOS 11 (OS menu is displayed). Mike, is iOS 11 behavior the same problem as crbug.com/736330 ?
,
Jul 28 2017
,
Aug 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3700a0865467ca4bcd08aa62f387cb4c597c2e37 commit 3700a0865467ca4bcd08aa62f387cb4c597c2e37 Author: Mike Dougherty <michaeldo@chromium.org> Date: Tue Aug 01 17:31:29 2017 Show the Chrome context menu when running on iOS 11. Bring back an old hack to prioritize our gesture recognizer over WKWebView's when running on iOS 11 or later. The hack was previously removed in https://codereview.chromium.org/2627093003/patch/160001/170008. Bug: 736330 , 736480 Change-Id: I669a3d530942e39db246f9b298a5f7a797e9754b Reviewed-on: https://chromium-review.googlesource.com/585672 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#491040} [modify] https://crrev.com/3700a0865467ca4bcd08aa62f387cb4c597c2e37/ios/web/web_state/ui/crw_context_menu_controller.mm
,
Aug 8 2017
Verified on canary build 62.0.3179.0 in iPad Air(iOS 11 beta4) and iPad (iOS 10.3.3) All iOS(9,10 & 11) are displaying the same context menu in first page (Google Image search results page) i.e. Context menu items displays: Open in New Tab, Open in new Incognito Tab, Copy Link URL
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d14fa398e0574893141b8a64b88b53a0664273b commit 7d14fa398e0574893141b8a64b88b53a0664273b Author: Mike Dougherty <michaeldo@chromium.org> Date: Wed Aug 09 18:05:06 2017 Show the Chrome context menu when running on iOS 11. Bring back an old hack to prioritize our gesture recognizer over WKWebView's when running on iOS 11 or later. The hack was previously removed in https://codereview.chromium.org/2627093003/patch/160001/170008. TBR=michaeldo@chromium.org (cherry picked from commit 3700a0865467ca4bcd08aa62f387cb4c597c2e37) Bug: 736330 , 736480 Change-Id: I669a3d530942e39db246f9b298a5f7a797e9754b Reviewed-on: https://chromium-review.googlesource.com/585672 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#491040} Reviewed-on: https://chromium-review.googlesource.com/608838 Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#405} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/7d14fa398e0574893141b8a64b88b53a0664273b/ios/web/web_state/ui/crw_context_menu_controller.mm
,
Aug 16 2017
Verified on 61.0.3163.47 beta build in iPad Air(iOS 11 beta6), iPad (iOS 10.3.2) and iPad Air(iOS All iOS(9,10 & 11) are displaying the same context menu in first page (Google Image search results page) i.e. Context menu items displays: Open in New Tab, Open in new Incognito Tab, Copy Link URL |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by srikanthg@chromium.org
, Jun 26 2017