New issue
Advanced search Search tips

Issue 736475 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Dec 2017
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature



Sign in to add a comment

Adding event constants for FeatureEngagementTracker

Project Member Reported by catherinechung@google.com, Jun 23 2017 
Previously, the FeatureEngagementTracker has been only on Android. Now that it
is cross-platform, event constants need to be added in C++. The constants are 
currently for the New Tab in-product help.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdf5c97837ed2d4f21440d78acd1b9a79a69395a

commit bdf5c97837ed2d4f21440d78acd1b9a79a69395a
Author: Catherine Chung <catherinechung@google.com>
Date: Mon Jun 26 20:50:56 2017

Added event constants in FeatureEngagementTracker

Previously, the FeatureEngagementTracker was only on Android, and now
that it is cross-platform, there must be event constants added in C++.
The constants are currently for the New Tab in-product help.

The event constants are used in this CL.
https://chromium-review.googlesource.com/c/549057

Bug:  736475 
Change-Id: I7cc677fa3af045648653368ced2f70332ec6e18a
Reviewed-on: https://chromium-review.googlesource.com/546699
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Catherine Chung <catherinechung@google.com>
Cr-Commit-Position: refs/heads/master@{#482389}
[modify] https://crrev.com/bdf5c97837ed2d4f21440d78acd1b9a79a69395a/components/feature_engagement_tracker/public/BUILD.gn
[add] https://crrev.com/bdf5c97837ed2d4f21440d78acd1b9a79a69395a/components/feature_engagement_tracker/public/event_constants.cc
[add] https://crrev.com/bdf5c97837ed2d4f21440d78acd1b9a79a69395a/components/feature_engagement_tracker/public/event_constants.h
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 12 2017

Labels: Hotlist-Google

Comment 3 by dtapu...@chromium.org, Dec 7 2017

Status: Fixed (was: Started)
►

Sign in to add a comment