The Cleaner UI needs to have a flow, for example a checkbox, to ask for permission to send logs to Google.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af4db795bb4122a7d352b69a3b7a715241562a6e commit af4db795bb4122a7d352b69a3b7a715241562a6e Author: alito <alito@chromium.org> Date: Fri Jun 23 21:27:11 2017 Chrome Cleaner UI: Add a new logs upload permission string BUG= 736465 TBR=grt@chromium.org Review-Url: https://codereview.chromium.org/2953293002 Cr-Commit-Position: refs/heads/master@{#482036} [modify] https://crrev.com/af4db795bb4122a7d352b69a3b7a715241562a6e/chrome/app/generated_resources.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13792b8b17e88e1ab36594a6592f4fed7ea824fe commit 13792b8b17e88e1ab36594a6592f4fed7ea824fe Author: alito <alito@chromium.org> Date: Sat Jun 24 00:17:21 2017 Chrome Cleaner UI: Add version of permission string with link place holder BUG= 736465 TBR=grt@chromium.org Review-Url: https://codereview.chromium.org/2956433005 Cr-Commit-Position: refs/heads/master@{#482087} [modify] https://crrev.com/13792b8b17e88e1ab36594a6592f4fed7ea824fe/chrome/app/generated_resources.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6056e1924f90559fbf4649692a78b12b93e7506 commit c6056e1924f90559fbf4649692a78b12b93e7506 Author: alito <alito@chromium.org> Date: Fri Jun 30 18:47:45 2017 Chrome Cleaner UI: Add logs upload permission checkbox to the dialog BUG= 736465 Review-Url: https://codereview.chromium.org/2966453002 Cr-Commit-Position: refs/heads/master@{#483777} [modify] https://crrev.com/c6056e1924f90559fbf4649692a78b12b93e7506/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win.cc [modify] https://crrev.com/c6056e1924f90559fbf4649692a78b12b93e7506/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win.h [modify] https://crrev.com/c6056e1924f90559fbf4649692a78b12b93e7506/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win_unittest.cc [modify] https://crrev.com/c6056e1924f90559fbf4649692a78b12b93e7506/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.cc [modify] https://crrev.com/c6056e1924f90559fbf4649692a78b12b93e7506/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.h [modify] https://crrev.com/c6056e1924f90559fbf4649692a78b12b93e7506/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_win.h [modify] https://crrev.com/c6056e1924f90559fbf4649692a78b12b93e7506/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win.cc [modify] https://crrev.com/c6056e1924f90559fbf4649692a78b12b93e7506/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win.h [modify] https://crrev.com/c6056e1924f90559fbf4649692a78b12b93e7506/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win_unittest.cc [modify] https://crrev.com/c6056e1924f90559fbf4649692a78b12b93e7506/chrome/browser/safe_browsing/chrome_cleaner/mock_chrome_cleaner_process_win.cc [modify] https://crrev.com/c6056e1924f90559fbf4649692a78b12b93e7506/chrome/browser/safe_browsing/chrome_cleaner/mock_chrome_cleaner_process_win.h [modify] https://crrev.com/c6056e1924f90559fbf4649692a78b12b93e7506/chrome/browser/ui/views/chrome_cleaner_dialog_browsertest_win.cc [modify] https://crrev.com/c6056e1924f90559fbf4649692a78b12b93e7506/chrome/browser/ui/views/chrome_cleaner_dialog_win.cc [modify] https://crrev.com/c6056e1924f90559fbf4649692a78b12b93e7506/chrome/browser/ui/views/chrome_cleaner_dialog_win.h [modify] https://crrev.com/c6056e1924f90559fbf4649692a78b12b93e7506/chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc [modify] https://crrev.com/c6056e1924f90559fbf4649692a78b12b93e7506/components/chrome_cleaner/public/interfaces/chrome_prompt.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9d3533f6baa7f4958089d651a2f927e4acc1c7d commit b9d3533f6baa7f4958089d651a2f927e4acc1c7d Author: proberge <proberge@chromium.org> Date: Fri Jul 07 14:09:10 2017 Cleanup Tool WebUI: Add logs upload checkbox and minor polishing As a follow-up to https://codereview.chromium.org/2966453002/, where we added a logs upload permission checkbox to the modal dialog, this change adds the same checkbox to the WebUI. The checkbox should be synchronized with the dialog and other opened settings pages. Also adds a "Learn More" link to Chrome Cleanup's help center article, minor fixes for RTL languages, repositions the "Show files to be removed" button and uses standard colors. BUG= 736465 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2971823002 Cr-Commit-Position: refs/heads/master@{#484917} [modify] https://crrev.com/b9d3533f6baa7f4958089d651a2f927e4acc1c7d/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html [modify] https://crrev.com/b9d3533f6baa7f4958089d651a2f927e4acc1c7d/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js [modify] https://crrev.com/b9d3533f6baa7f4958089d651a2f927e4acc1c7d/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_proxy.js [modify] https://crrev.com/b9d3533f6baa7f4958089d651a2f927e4acc1c7d/chrome/browser/resources/settings/chrome_cleanup_page/compiled_resources2.gyp [modify] https://crrev.com/b9d3533f6baa7f4958089d651a2f927e4acc1c7d/chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc [modify] https://crrev.com/b9d3533f6baa7f4958089d651a2f927e4acc1c7d/chrome/browser/ui/webui/settings/chrome_cleanup_handler.h [modify] https://crrev.com/b9d3533f6baa7f4958089d651a2f927e4acc1c7d/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/b9d3533f6baa7f4958089d651a2f927e4acc1c7d/chrome/common/url_constants.cc [modify] https://crrev.com/b9d3533f6baa7f4958089d651a2f927e4acc1c7d/chrome/common/url_constants.h [modify] https://crrev.com/b9d3533f6baa7f4958089d651a2f927e4acc1c7d/chrome/test/data/webui/settings/chrome_cleanup_page_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd97436907ba68cd47314b79225755001c24c180 commit fd97436907ba68cd47314b79225755001c24c180 Author: proberge <proberge@chromium.org> Date: Mon Aug 07 20:59:28 2017 Chrome Cleanup WebUI: properly test logs upload control I had left a TODO in https://codereview.chromium.org/2971823002/ to fix this. Turns out I needed to mock a tap on logsControl.$.control instead of just on logsControl. Bug: 736465 Change-Id: Ifdc0b45c48d90025951e6952ad7a16f14b1700d2 Reviewed-on: https://chromium-review.googlesource.com/603909 Commit-Queue: proberge <proberge@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#492402} [modify] https://crrev.com/fd97436907ba68cd47314b79225755001c24c180/chrome/test/data/webui/settings/chrome_cleanup_page_test.js
Comment 1 by bugdroid1@chromium.org
, Jun 23 2017