New issue
Advanced search Search tips

Issue 736449 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Thread Times UMA

Project Member Reported by tdres...@chromium.org, Jun 23 2017

Issue description

We need a per thread thread times UMA metric, as a proxy for power.

We have some data here on the main thread today, but nothing that works across threads.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f2691cc7756d599ce5622cb7c9fc854afcf3c57

commit 6f2691cc7756d599ce5622cb7c9fc854afcf3c57
Author: tdresser <tdresser@chromium.org>
Date: Wed Jun 28 17:53:34 2017

chrome://profiler infrastructure uses base time types.

Previously, chrome://profiler avoided base::TimeTicks and
base::TimeDelta because they're 64 bits.

At this point, that appears to be premature optimization. Switch to
using the base time types.

This is required for using chrome://profiler's infrastructure for
building thread time UMA metrics.

BUG= 736449 

Review-Url: https://codereview.chromium.org/2956683002
Cr-Commit-Position: refs/heads/master@{#483054}

[modify] https://crrev.com/6f2691cc7756d599ce5622cb7c9fc854afcf3c57/base/BUILD.gn
[modify] https://crrev.com/6f2691cc7756d599ce5622cb7c9fc854afcf3c57/base/debug/task_annotator.cc
[modify] https://crrev.com/6f2691cc7756d599ce5622cb7c9fc854afcf3c57/base/profiler/scoped_profile.h
[delete] https://crrev.com/a39debfb48a8b333cd989cfe1ff1649e39cd2fa7/base/profiler/tracked_time.cc
[delete] https://crrev.com/a39debfb48a8b333cd989cfe1ff1649e39cd2fa7/base/profiler/tracked_time.h
[delete] https://crrev.com/a39debfb48a8b333cd989cfe1ff1649e39cd2fa7/base/profiler/tracked_time_unittest.cc
[modify] https://crrev.com/6f2691cc7756d599ce5622cb7c9fc854afcf3c57/base/threading/worker_pool_posix.cc
[modify] https://crrev.com/6f2691cc7756d599ce5622cb7c9fc854afcf3c57/base/tracked_objects.cc
[modify] https://crrev.com/6f2691cc7756d599ce5622cb7c9fc854afcf3c57/base/tracked_objects.h
[modify] https://crrev.com/6f2691cc7756d599ce5622cb7c9fc854afcf3c57/base/tracked_objects_unittest.cc
[modify] https://crrev.com/6f2691cc7756d599ce5622cb7c9fc854afcf3c57/base/tracking_info.h
[modify] https://crrev.com/6f2691cc7756d599ce5622cb7c9fc854afcf3c57/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

Description: Show this description
Status: WontFix (was: Started)
We're punting this for now.

Comment 4 by dproy@chromium.org, Mar 16 2018

Labels: testlabel

Comment 5 by dproy@chromium.org, Mar 16 2018

Labels: -testlabel

Comment 6 by dproy@chromium.org, Mar 16 2018

Labels: -progressivewebmetrics

Sign in to add a comment