cros_ec_lpc: cros_ec_lpc_remove doesn't remove all acpi notify handlers |
|||
Issue descriptionSee Thierry's reply here: https://lkml.org/lkml/2017/6/23/126 "In the original patch (https://chromium-review.googlesource.com/c/358155/) ACPI_ALL_NOTIFY is passed to acpi_install_notify_handler() and ACPI_SYSTEM_NOTIFY to acpi_remove_notify_handler. I changed it for remove_notify call to unsure all handler references were removed." Change ACPI_SYSTEM_NOTIFY to ACPI_ALL_NOTIFY in cros_ec_lpc_remove.
,
Jun 23 2017
Quick fix adapted from Thierry's patch to upstream here: https://chromium-review.googlesource.com/c/546715/
,
Jun 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/5aac3631e5258f8deb51abfcfe46285f44670ed1 commit 5aac3631e5258f8deb51abfcfe46285f44670ed1 Author: Thierry Escande <thierry.escande@collabora.com> Date: Sat Jun 24 21:59:54 2017 CHROMIUM: platform/chrome: cros_ec_lpc: Pass ACPI_ALL_NOTIFY to acpi_remove_notify_handler In the original patch (https://chromium-review.googlesource.com/c/358155/) ACPI_ALL_NOTIFY is passed to acpi_install_notify_handler() and ACPI_SYSTEM_NOTIFY to acpi_remove_notify_handler. Change it for remove_notify call to ensure all handler references are removed. Signed-off-by: Thierry Escande <thierry.escande@collabora.com> Signed-off-by: Benson Leung <bleung@chromium.org> BUG= chromium:736433 TEST=build. Change-Id: I02a3b5d4958ce0ffe3a7a57923eef2b1c82a1cc9 Reviewed-on: https://chromium-review.googlesource.com/546715 Commit-Ready: Benson Leung <bleung@google.com> Tested-by: Benson Leung <bleung@google.com> Tested-by: Benson Leung <bleung@chromium.org> Reviewed-by: Gwendal Grignou <gwendal@google.com> [modify] https://crrev.com/5aac3631e5258f8deb51abfcfe46285f44670ed1/drivers/platform/chrome/cros_ec_lpc.c
,
Jun 24 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bleung@chromium.org
, Jun 23 2017