audiosource-premature-gc.html often times out on leak bot |
|||
Issue descriptionhttps://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=audiosource-premature-gc.html PTAL, or assign it to the right owner.
,
Jun 23 2017
sigbjornf@: PTAL this CL is probably responsible: https://codereview.chromium.org/2951903003/
,
Jun 26 2017
Any layout test with "gc" in its name is bound throw up interesting issues :-) I cannot reproduce locally, but I assume it is due to there sometimes being a test sequence which results in a longer (explicit) GC. Which can cause an offline rendering step never to run to completion; the test depends on that to happen for it to signal successful completion. Will go after that theory & attempt a fix.
,
Jun 26 2017
time out on Mac as well: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/35113
,
Jun 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2b0d186b1a158f9846cd4a131435f6fee2635ae commit f2b0d186b1a158f9846cd4a131435f6fee2635ae Author: Xida Chen <xidachen@chromium.org> Date: Mon Jun 26 17:04:19 2017 Mark audiosource-premature-gc.html timeout pass TBR=sigbjornf@opera.com NOTRY=true Bug: 736429 Change-Id: I826477447510d190ac851e2504a0d24ff031afc5 Reviewed-on: https://chromium-review.googlesource.com/548856 Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#482300} [modify] https://crrev.com/f2b0d186b1a158f9846cd4a131435f6fee2635ae/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83bd4101c86370d76a76a0e890d82ae66618f6ba commit 83bd4101c86370d76a76a0e890d82ae66618f6ba Author: sigbjornf <sigbjornf@opera.com> Date: Mon Jun 26 17:12:40 2017 Repost offline rendering task if GC prevents. R= BUG= 736429 Review-Url: https://codereview.chromium.org/2959663002 Cr-Commit-Position: refs/heads/master@{#482301} [modify] https://crrev.com/83bd4101c86370d76a76a0e890d82ae66618f6ba/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp
,
Jun 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b168fd9182f9752758ffb36559b5d3838d1c9e0 commit 8b168fd9182f9752758ffb36559b5d3838d1c9e0 Author: sigbjornf <sigbjornf@opera.com> Date: Mon Jun 26 21:06:33 2017 Retire audiosource-premature-gc.html test expectation. Not needed following r482301. TBR=xidachen@chromium.org NOTRY=true BUG= 736429 Review-Url: https://codereview.chromium.org/2960733002 Cr-Commit-Position: refs/heads/master@{#482395} [modify] https://crrev.com/8b168fd9182f9752758ffb36559b5d3838d1c9e0/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 26 2017
,
Jun 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/250ea0ea4174a17b0aa1c9a72a892df2b5aa5043 commit 250ea0ea4174a17b0aa1c9a72a892df2b5aa5043 Author: sigbjornf <sigbjornf@opera.com> Date: Mon Jun 26 21:36:54 2017 Simplify OfflineAudioDestinationNode::DoOfflineRendering(). No need to track is-suspended state. R=hongchan BUG= 736429 Review-Url: https://codereview.chromium.org/2959693002 Cr-Commit-Position: refs/heads/master@{#482417} [modify] https://crrev.com/250ea0ea4174a17b0aa1c9a72a892df2b5aa5043/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp [modify] https://crrev.com/250ea0ea4174a17b0aa1c9a72a892df2b5aa5043/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h |
|||
►
Sign in to add a comment |
|||
Comment 1 by xidac...@chromium.org
, Jun 23 2017