New issue
Advanced search Search tips

Issue 736413 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task



Sign in to add a comment

Support removing system apps from test_runner.py

Project Member Reported by bsheedy@chromium.org, Jun 23 2017

Issue description

The ability to temporarily remove system apps from swarmed devices was added to devil in https://codereview.chromium.org/2923443002/. However, there is currently no way to specify to the test runner that you want to run a test with an app removed.

WebView currently gets around this by wrapping their test in system_app.py https://codesearch.chromium.org/chromium/src/testing/buildbot/gn_isolate_map.pyl?rcl=3fc057c54155174850badc5c6b3bfd9b1ec2d955&l=922, but it would be cleaner for any test to just be able to specify a set of system apps to remove directly to the test runner.
 

Comment 1 by mmoss@chromium.org, Jun 26 2017

Components: -Infra Infra>Platform>Swarming
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39446b44eebc2a55f4a1192fd83b27181a5a17f3

commit 39446b44eebc2a55f4a1192fd83b27181a5a17f3
Author: bsheedy <bsheedy@chromium.org>
Date: Thu Jul 06 20:32:49 2017

Add replace-system-package option to test_runner

Adds an option to temporarily replace a system package during a test
run for use on swarming. Currently only supports replacing of a single
package.

Tested to work for VR instrumentation tests on the swarmed Pixel XL
devices.

Bug:  736413 
Change-Id: I1061a318c19a67b416984f78f660a1c4b62be019
Reviewed-on: https://chromium-review.googlesource.com/560676
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484731}
[modify] https://crrev.com/39446b44eebc2a55f4a1192fd83b27181a5a17f3/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/39446b44eebc2a55f4a1192fd83b27181a5a17f3/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/39446b44eebc2a55f4a1192fd83b27181a5a17f3/build/android/test_runner.py
[modify] https://crrev.com/39446b44eebc2a55f4a1192fd83b27181a5a17f3/build/android/test_runner.pydeps

Status: Fixed (was: Started)

Sign in to add a comment