New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 736409 link

Starred by 1 user
Status: Fixed
Owner:
█ jif@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 642702



Sign in to add a comment

Center buttons and add hairline divisor to Keyboard Accessory View

Project Member Reported by jif@chromium.org, Jun 23 2017 
Center buttons and add hairline divisor to Keyboard Accessory View
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c062aa92c26aad33f661601b1eb86b5b5c236e8

commit 0c062aa92c26aad33f661601b1eb86b5b5c236e8
Author: jif <jif@chromium.org>
Date: Tue Jun 27 14:16:23 2017

[iOS] Vertically center subviews in the Keyboard Accessory View and remove button background

BUG= 736409 

Review-Url: https://codereview.chromium.org/2951193006
Cr-Commit-Position: refs/heads/master@{#482618}

[modify] https://crrev.com/0c062aa92c26aad33f661601b1eb86b5b5c236e8/ios/chrome/browser/ui/toolbar/new_keyboard_accessory_view.mm
[modify] https://crrev.com/0c062aa92c26aad33f661601b1eb86b5b5c236e8/ios/chrome/browser/ui/toolbar/resources/keyboard_accessory_qr_scanner.png
[modify] https://crrev.com/0c062aa92c26aad33f661601b1eb86b5b5c236e8/ios/chrome/browser/ui/toolbar/resources/keyboard_accessory_qr_scanner@2x.png
[modify] https://crrev.com/0c062aa92c26aad33f661601b1eb86b5b5c236e8/ios/chrome/browser/ui/toolbar/resources/keyboard_accessory_qr_scanner@3x.png
[modify] https://crrev.com/0c062aa92c26aad33f661601b1eb86b5b5c236e8/ios/chrome/browser/ui/toolbar/resources/keyboard_accessory_voice_search.png
[modify] https://crrev.com/0c062aa92c26aad33f661601b1eb86b5b5c236e8/ios/chrome/browser/ui/toolbar/resources/keyboard_accessory_voice_search@2x.png
[modify] https://crrev.com/0c062aa92c26aad33f661601b1eb86b5b5c236e8/ios/chrome/browser/ui/toolbar/resources/keyboard_accessory_voice_search@3x.png

Comment 2 by jif@chromium.org, Jun 27 2017

Blocking: 642702
Status: Fu (was: Started)
What the Keyboard Accessory View looks like now.
Screen Shot 2017-06-27 at 11.16.22 AM.png
389 KB View Download

Comment 3 by jif@chromium.org, Jun 27 2017

Status: Fixed (was: Fu)
►

Sign in to add a comment