New issue
Advanced search Search tips

Issue 736402 link

Starred by 1 user
Status: Duplicate
Merged: issue 735724
Owner:
wzang@chromium.org
Closed: Jun 2017
Cc:
xiy...@chromium.org
r...@chromium.org
alemate@chromium.org
wzang@chromium.org
jdufault@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

ToT today: Can't login. Nothing shows up but the wallpaper

Project Member Reported by afakhry@chromium.org, Jun 23 2017 
Nothing shows up on reboot but the wallpaper. /var/log/ui/ui.LATEST shows the following JS errors:

"Uncaught ReferenceError: login is not defined".

"TypeError: Cannot read property 'classList' of undefined.
IMG_20170623_093636.jpg
1.4 MB View Download

Comment 1 by alemate@chromium.org, Jun 23 2017

Cc: wzang@chromium.org
This is somewhat known bug.
I think Colin is working on it.

(I am not sure if we should merge this into  issue 735724 , so I just added wzang@ to CC)

Comment 2 by r...@chromium.org, Jun 23 2017

Labels: M-61
Owner: wzang@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by xiy...@chromium.org, Jun 23 2017 

Saw similar errors when running ToT on dev box.

[12059:12059:0623/095524.531275:ERROR:CONSOLE(9356)] "TypeError: Cannot read property 'classList' of undefined
    at chrome://oobe/login.js:7119:32", source: chrome://oobe/login.js (9356)
[12059:12059:0623/095524.531805:ERROR:CONSOLE(7119)] "Uncaught TypeError: Cannot read property 'classList' of undefined", source: chrome://oobe/login.js (7119)

And line 7119 is this:
      setTimeout(function() {
        $('pod-row').classList.remove('images-loading');
===>        this.smallPodsContainer.classList.remove('images-loading');
        this.topMask.classList.remove('images-loading');
        this.bottomMask.classList.remove('images-loading');
      }, POD_ROW_IMAGES_LOAD_TIMEOUT_MS);

Culprit CL is: https://codereview.chromium.org/2931063004

We added "this" to a setTimeout function but did not do .bind(this).

Comment 4 by wzang@chromium.org, Jun 23 2017

Mergedinto: 735724
Status: Duplicate (was: Assigned)
I already prepared a CL on Wednesday but haven't landed it yet.
►

Sign in to add a comment