Photo Picker should only launch for image file types |
||
Issue descriptionWhen trying to select files for the following HTML snippet (extracted from the Vuze Web Remote plugin) I get the new photo picker as opposed to a file picker. (Demo @ https://tests.peter.sh/random/vuze-file-picker.html) <input type="file" name="files[]" id="upload_file" multiple="multiple" /> If I add an @accept attribute to the <input> with a random extension or mime type it does show the file picker, so it looks like we default to the photo picker for missing @accept attributes. Would you mind changing that back to defaulting to the file picker, Finnur?
,
Jun 26 2017
Fix in review: https://codereview.chromium.org/2955793003/
,
Jun 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4048203f6fe6e2a36373df647d1a89aa11b4b9e commit f4048203f6fe6e2a36373df647d1a89aa11b4b9e Author: finnur <finnur@chromium.org> Date: Mon Jun 26 17:59:51 2017 Photo Picker dialog: Don't show when no accept tags are specified. BUG= 736394 , 656015 Review-Url: https://codereview.chromium.org/2955793003 Cr-Commit-Position: refs/heads/master@{#482316} [modify] https://crrev.com/f4048203f6fe6e2a36373df647d1a89aa11b4b9e/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java [modify] https://crrev.com/f4048203f6fe6e2a36373df647d1a89aa11b4b9e/ui/android/junit/src/org/chromium/ui/base/SelectFileDialogTest.java
,
Jun 27 2017
Thank you Finnur! Verified in 61.0.3142.0 :). |
||
►
Sign in to add a comment |
||
Comment 1 by amineer@chromium.org
, Jun 23 2017