New issue
Advanced search Search tips

Issue 736362 link

Starred by 1 user
Status: Fixed
Owner:
kinuko@chromium.org
Closed: Jun 2017
Cc:
scottmg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-Servicification



Sign in to add a comment

Failure in content_browertests on network service bot

Project Member Reported by rdsmith@chromium.org, Jun 23 2017 
See https://build.chromium.org/p/chromium.fyi/builders/Mojo%20Linux/builds/2397.  The following failures occurred.

network_service_content_browsertests network_service_content_browsertests
Run on OS: 'Ubuntu-14.04'
swarming pending 57s
failures:
ServiceWorkerVersionBrowserTest.Activate_Rejected
ServiceWorkerVersionBrowserTest.FetchEvent_Response
ServiceWorkerVersionBrowserTest.Activate_NoEventListener
ServiceWorkerVersionBrowserTest.FetchEvent_ResponseViaCache
ServiceWorkerVersionBrowserTest.FetchEvent_respondWithRejection

swarming pending 57s ( 0 secs )

Scanning the blamelist, my strong guess is that this is due to 

Change #91447

Changed by	kinuko@chromium.org
Changed at	Fri 23 Jun 2017 03:07:15
Repository	https://chromium.googlesource.com/chromium/src
Project	chromium
Branch	master
Revision	a0b7787a076e2a83f6b60853dc80d31ed99c7be3
Comments

SW Servicification: Hook ScriptURLLoader only for script installation

Add some more code from ServiceWorkerContextRequestHandler to
ScriptURLLoaderFactory.  Also added small cleanup around IsInstalled.

BUG= 715640 

patch from issue 2953763002 at patchset 1 (http://crrev.com/2953763002#ps1)

Change-Id: Ib0b578378a957e911bf7a36b2929d2723e0b35f7
Reviewed-on: https://chromium-review.googlesource.com/544720
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481842}

Kinuko, could you take a look?

Comment 2 by kinuko@chromium.org, Jun 26 2017

Components: Blink>ServiceWorker Internals>Network>Service
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46a89e2b08fbc0026635f9e4ee3dad2816bc3257

commit 46a89e2b08fbc0026635f9e4ee3dad2816bc3257
Author: Kinuko Yasuda <kinuko@chromium.org>
Date: Mon Jun 26 11:43:55 2017

Fix failing ServiceWorkerVersionBrowserTest on Network Service bots

We needed some work-around as we're giving a loading request associated
with EmbeddedWorkerClient to Network Service's URLLoaderFactory.

BUG= 736362 

Change-Id: I2e64a93b1699b34146d414f64ee00bc50d5455bc
Reviewed-on: https://chromium-review.googlesource.com/547160
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482244}
[modify] https://crrev.com/46a89e2b08fbc0026635f9e4ee3dad2816bc3257/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/46a89e2b08fbc0026635f9e4ee3dad2816bc3257/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Comment 4 by kinuko@chromium.org, Jun 26 2017

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/906dd0aca03c3db8e9f4b8c0d0626462c58d021a

commit 906dd0aca03c3db8e9f4b8c0d0626462c58d021a
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Tue Jun 27 02:00:48 2017

Revert "Fix failing ServiceWorkerVersionBrowserTest on Network Service bots"

This reverts commit 46a89e2b08fbc0026635f9e4ee3dad2816bc3257.

Reason for revert: 
This patch depends on https://crrev.com/1ebf3cb which is being reverted. 
See also the bug: https://crbug.com/736649

Original change's description:
> Fix failing ServiceWorkerVersionBrowserTest on Network Service bots
> 
> We needed some work-around as we're giving a loading request associated
> with EmbeddedWorkerClient to Network Service's URLLoaderFactory.
> 
> BUG= 736362 
> 
> Change-Id: I2e64a93b1699b34146d414f64ee00bc50d5455bc
> Reviewed-on: https://chromium-review.googlesource.com/547160
> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#482244}

TBR=falken@chromium.org,kinuko@chromium.org,yzshen@chromium.org,shimazu@chromium.org

Change-Id: I8bc6dab815c8e4f1834a3f2cbe43d078b46d56fb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  736362 , 736649
Reviewed-on: https://chromium-review.googlesource.com/549596
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482512}
[modify] https://crrev.com/906dd0aca03c3db8e9f4b8c0d0626462c58d021a/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/906dd0aca03c3db8e9f4b8c0d0626462c58d021a/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Comment 6 by kinuko@chromium.org, Jun 27 2017 

(Note: the patch that introduced the breakage is also reverted, and we're going to reland them together so that they won't break again)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 27 2017

Labels: merge-merged-3142
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/451198c115a46ca0b20988954370b743d6acf301

commit 451198c115a46ca0b20988954370b743d6acf301
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Tue Jun 27 13:45:19 2017

[merge to 3142] Revert "Fix failing ServiceWorkerVersionBrowserTest on Network Service bots"

This reverts commit 46a89e2b08fbc0026635f9e4ee3dad2816bc3257.

Reason for revert:
This patch depends on https://crrev.com/1ebf3cb which is being reverted.
See also the bug: https://crbug.com/736649

Original change's description:
> Fix failing ServiceWorkerVersionBrowserTest on Network Service bots
>
> We needed some work-around as we're giving a loading request associated
> with EmbeddedWorkerClient to Network Service's URLLoaderFactory.
>
> BUG= 736362 
>
> Change-Id: I2e64a93b1699b34146d414f64ee00bc50d5455bc
> Reviewed-on: https://chromium-review.googlesource.com/547160
> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#482244}

TBR=falken@chromium.org,kinuko@chromium.org,yzshen@chromium.org,shimazu@chromium.org

Change-Id: I8bc6dab815c8e4f1834a3f2cbe43d078b46d56fb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  736362 , 736649
Reviewed-on: https://chromium-review.googlesource.com/549596
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#482512}
Review-Url: https://codereview.chromium.org/2956073002 .
Cr-Commit-Position: refs/branch-heads/3142@{#3}
Cr-Branched-From: 58a8bea874fcfa2c18749645f087d0b21b8a21a0-refs/heads/master@{#482491}

[modify] https://crrev.com/451198c115a46ca0b20988954370b743d6acf301/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/451198c115a46ca0b20988954370b743d6acf301/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Comment 8 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
►

Sign in to add a comment