[VR] Fix Screen Share icon |
|||||
Issue descriptionChrome in VR is using a screen_capture icon that has a 1x version and is designed to look good on a specific size. This icon must be replaced with the general one. Moreover, the icon must go back to its old location
,
Jun 24 2017
Is this needed for M61?
,
Jun 26 2017
Yes, it needs to be done for M61.
,
Jun 26 2017
,
Jun 26 2017
,
Jul 14 2017
,
Jul 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbf508f8180fc7dff9c5cf0aad349bc5be6d3f7e commit dbf508f8180fc7dff9c5cf0aad349bc5be6d3f7e Author: Amirhossein Simjour <asimjour@chromium.org> Date: Sat Jul 15 13:05:51 2017 Fix Screen Share icon screen_share.icon is moved back to ash/resources/vector_icons. As a result VrShell is no longer using the 1x version of this icon. BUG= 736350 Change-Id: Iaa9934fa99345e58acd60d7e3250b58b80ba170f Reviewed-on: https://chromium-review.googlesource.com/565546 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#486991} [modify] https://crrev.com/dbf508f8180fc7dff9c5cf0aad349bc5be6d3f7e/ash/BUILD.gn [modify] https://crrev.com/dbf508f8180fc7dff9c5cf0aad349bc5be6d3f7e/ash/DEPS [modify] https://crrev.com/dbf508f8180fc7dff9c5cf0aad349bc5be6d3f7e/ash/resources/vector_icons/BUILD.gn [rename] https://crrev.com/dbf508f8180fc7dff9c5cf0aad349bc5be6d3f7e/ash/resources/vector_icons/system_tray_screen_share.1x.icon [add] https://crrev.com/dbf508f8180fc7dff9c5cf0aad349bc5be6d3f7e/ash/resources/vector_icons/system_tray_screen_share.icon [modify] https://crrev.com/dbf508f8180fc7dff9c5cf0aad349bc5be6d3f7e/ash/system/screen_security/screen_tray_item.cc [modify] https://crrev.com/dbf508f8180fc7dff9c5cf0aad349bc5be6d3f7e/components/vector_icons/BUILD.gn
,
Jul 17 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tdander...@chromium.org
, Jun 23 2017