New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 736343 link

Starred by 1 user
Status: WontFix
Owner:
zea@chromium.org
Closed: Jun 2017
Cc:
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Missing Tests]: Referrer not being properly recorded in tab sync for certain domains?

Project Member Reported by msrchandra@chromium.org, Jun 23 2017 
Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
https://chromium.googlesource.com/chromium/src.git/+/7efeed1496d352d1099c86f456550e54964bb215

Ref Bug: 
https://bugs.chromium.org/p/chromium/issues/detail?id=729713

Thank You.

Comment 1 by msrchandra@chromium.org, Jun 23 2017 

Apologies for the typo in CL and Ref Bug
Please find the correct CL and Ref Bug below --

There is no bugdroid update in the reference issue but providing the Revert 
https://codereview.chromium.org/2921883003/

Ref Bug: 
https://bugs.chromium.org/p/chromium/issues/detail?id=729159

Please let me know if the bug is wrongly updated.

Thank You.

Comment 2 by zea@chromium.org, Jun 23 2017

Status: WontFix (was: Assigned)
That CL just removes unnecessary complexity. There were basic unit tests already in place and they now correctly test the code in question. (see SerializedNavigationEntryTest.ToSyncData and FromSyncData)
►

Sign in to add a comment