New issue
Advanced search Search tips

Issue 736341 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

[Missing Tests]: AppShell: Move chrome.fileSystem API to //extensions

Project Member Reported by msrchandra@chromium.org, Jun 23 2017 
Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
https://chromium.googlesource.com/chromium/src.git/+/7efeed1496d352d1099c86f456550e54964bb215

Ref Bug: 
https://bugs.chromium.org/p/chromium/issues/detail?id=729713

Thank You.

Comment 1 by michae...@chromium.org, Jun 23 2017 

This was a small, mechanical change. GetSiteForExtensionId is already used in several classes which are tested. We have been moving lots of code from //extensions to //chrome without changing its implementation; for small changes like this one I doubt a regression is likely.

Can you clarify what the concern is here? When the chrome.fileSystem API is usable from //extensions, we'll test it there, but as you can see the bug is not marked Fixed yet.

Comment 2 by michae...@chromium.org, Jun 23 2017

Labels: Needs-Feedback
Owner: msrchandra@chromium.org

Comment 3 by msrchandra@chromium.org, Jun 27 2017

Labels: -Needs-Feedback
Owner: ----
Status: WontFix (was: Assigned)
@michaelpg -- Thank You for the update. Apologies for the issue.
Marking the issue as Won't Fix as per Comment# 2.
Thank You.
►

Sign in to add a comment