Issue metadata
Sign in to add a comment
|
1.3% regression in memory.top_10_mobile at 481552:481580 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jun 23 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8975991258985641936
,
Jun 23 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8975991251247011072
,
Jun 23 2017
=== Auto-CCing suspected CL author sunxd@chromium.org === Hi sunxd@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : sunxd Commit : 83daa38b5aff9382a35bb3f21198c1248d030a8a Date : Thu Jun 22 16:47:02 2017 Subject: cc: Enable mask tiling Bisect Details Configuration: android_webview_arm64_aosp_perf_bisect Benchmark : memory.top_10_mobile Metric : memory:webview:all_processes:reported_by_chrome:cc:effective_size_avg/background/after_https_www_google_co_uk_hl_en_q_science Change : 1.28% | 9382464.0 -> 9502720.0 Revision Result N chromium@481551 9382464 +- 0.0 6 good chromium@481559 9382464 +- 0.0 6 good chromium@481561 9382464 +- 0.0 6 good chromium@481562 9382464 +- 0.0 6 good chromium@481563 9502720 +- 0.0 6 bad <-- chromium@481566 9502720 +- 0.0 6 bad chromium@481580 9502720 +- 0.0 6 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8975991258985641936 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=4996283678326784 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jun 23 2017
=== BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : sunxd Commit : 83daa38b5aff9382a35bb3f21198c1248d030a8a Date : Thu Jun 22 16:47:02 2017 Subject: cc: Enable mask tiling Bisect Details Configuration: android_webview_arm64_aosp_perf_bisect Benchmark : memory.top_10_mobile Metric : memory:webview:all_processes:reported_by_chrome:cc:effective_size_avg/background/after_https_www_google_co_uk_hl_en_q_science Change : 1.28% | 9382464.0 -> 9502720.0 Revision Result N chromium@481551 9382464 +- 0.0 6 good chromium@481559 9382464 +- 0.0 6 good chromium@481561 9382464 +- 0.0 6 good chromium@481562 9382464 +- 0.0 6 good chromium@481563 9502720 +- 0.0 6 bad <-- chromium@481566 9502720 +- 0.0 6 bad chromium@481580 9502720 +- 0.0 6 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8975991251247011072 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5574152603303936 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jul 27 2017
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md We're looking for one of the following: 1. Justification via explanation 2. Plan to revert or fix 3. Angry rage throwing of equipment at my head Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it. Note: This was a bulk edit message and not very personal.
,
Jul 27 2017
The regressed page has a mask layer applied due to ancestor border-radius (the div above the text area whose class is sbtc). This is a small div so it won't benefit from mask tiling in terms of memory usage, but it is expected to take more memory than before, as we now have to store more tile info.
,
Aug 4 2017
I suspect a bad bisect, the table- shaped graph shows something (else) was landed and reverted. We can close this. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by kraynov@chromium.org
, Jun 23 2017