New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736314 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Page number tooltip is not seen after scolling pages in print preview.

Reported by avsha...@etouch.net, Jun 23 2017

Issue description

Chrome Version : 61.0.3139.0 (Official Build) 2dd0ea84298d45e0962c595c591529bc84dd0ebd-refs/heads/master@{#481757} 32/64 bit
OS : Windows(7,8,10), Linux(14.04 LTS), Mac(10.12.3, 10.11.6)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://terms page.
2. Give print command using Ctrl + P keys and scroll down the print preview contents, observe the page number tooltip in RHS. 
 
Actual Result : Page number tool tip is not seen after scolling pages in print preview.

Expected Result : Page number tool tip should be seen for all pages in print preview.

This is a regression issue broken in ‘M-61’, below is the Manual Regression range and will soon update other info.
Good build : 61.0.3137.0
Bad build : 61.0.3138.0

Note : Above issue can be seen on any document having multiple pages.
 
Actual_Page_tooltip.mp4
3.0 MB View Download
Expected_Page_tooltip.mp4
1.6 MB View Download
Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: dtapu...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:61.0.3137.0(Revision:481057).
Bad build:61.0.3138.0(Revision:481386).

You are probably looking for a change made after 481206 (known good), but no later than 481208 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/b2e101299180938b571c5779f11105b767c0e70b..4cef659a8009c5cb4f5708336ae37654d23653b3

From the CL above, assigning the issue to the concern owner

@dtapuska: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Reviewed-on: https://chromium-review.googlesource.com/527917
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3138.0
Adding Release Block-Stable for this issue.Please remove if not the case.
Fix posted for review here: https://chromium-review.googlesource.com/c/544200/
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/482c293107ddcf4d7028b5033604b0ee26288e51

commit 482c293107ddcf4d7028b5033604b0ee26288e51
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Mon Jun 26 14:23:55 2017

Use the scrollingElement as the element for looking up scroll dimensions

Previously the body was used but the scrollingElement is the correct
element to use. Because with scrollLeftTopInterop feature on then
scrolling element is the document element not the body.

BUG= 736314 

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib37c5d1a41c8bd2429fb89197a5db7c870c601dc
Reviewed-on: https://chromium-review.googlesource.com/544200
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482268}
[modify] https://crrev.com/482c293107ddcf4d7028b5033604b0ee26288e51/chrome/browser/resources/pdf/elements/viewer-page-indicator/viewer-page-indicator.js

Status: Fixed (was: Started)

Sign in to add a comment