--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e72dd2c5ec6d69fbe57136abd7551942f53322e

commit 0e72dd2c5ec6d69fbe57136abd7551942f53322e
Author: David Roger <droger@chromium.org>
Date: Thu Aug 24 10:44:35 2017

[signin] Histograms for Dice responses

Bug:  736310 
Change-Id: I92f9d7d7818dba27c1be26780693b441dc577e45
Reviewed-on: https://chromium-review.googlesource.com/623750
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496999}
[modify] https://crrev.com/0e72dd2c5ec6d69fbe57136abd7551942f53322e/chrome/browser/signin/dice_response_handler.cc
[modify] https://crrev.com/0e72dd2c5ec6d69fbe57136abd7551942f53322e/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/0e72dd2c5ec6d69fbe57136abd7551942f53322e/tools/metrics/histograms/histograms.xml

--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

We should have metrics to check how often we do a logout during the reconcile. If it turns out we do it too often, that could be a bug or we might want to do more work to avoid doing that.

There are already metrics somewhat covering this:
Signin.Reconciler.AddedToCookieJar.*
Signin.Reconciler.RemovedFromCookieJar.*
Signin.Reconciler.DifferentPrimaryAccounts.*

It may be good enough, however they are called during FinishReconcile, which can be called multiple times per reconcile (called after ListAccounts and then for each MergeSessions).

+1 to David's points in c#6, those seem like important metrics to track.

--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03664c4cde9db35f560f25d8a6372637369d29f5

commit 03664c4cde9db35f560f25d8a6372637369d29f5
Author: David Roger <droger@chromium.org>
Date: Tue Jan 30 09:46:24 2018

[Dice] Improve the Signin.DiceResponseHeader histogram

- Now records "EnableSync" responses
- Now records "SignoutPrimary" correctly during Dice migration

Bug:  736310 
Change-Id: I5b4e8e60ecaab18cac2454986f5849565529976a
Reviewed-on: https://chromium-review.googlesource.com/891220
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532823}
[modify] https://crrev.com/03664c4cde9db35f560f25d8a6372637369d29f5/chrome/browser/signin/dice_response_handler.cc
[modify] https://crrev.com/03664c4cde9db35f560f25d8a6372637369d29f5/tools/metrics/histograms/enums.xml

David - do we need to merge this to 65 for M2, or is this only relevant for M3?

Friendly ping for David

I don't think this is required for M2.

For Sync rates, Signin.ChromePrimaryAccountStateOnWebSignout can be use on M2 and gives the same information (and even more).

Great, sounds good. Can we mark this as Fixed, or are there other metrics you're tracking in the scope of this bug? There may be other metrics I want to track for M3/M4, but I'll file separate bugs for them.

This was a generic bug that I filed before we really defined our metrics. We can now close this and have more specific bugs when we want to add new metrics.