New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736308 link

Starred by 15 users

Out-of-Blink web security implementation (e.g. CORS)

Project Member Reported by tyoshino@chromium.org, Jun 23 2017

Issue description

The plan hasn't yet been finalized.

This bug is an umbrella to capture potentially related efforts.

We're aiming that we move these into Network service at some point.
 
Showing comments 36 - 135 of 135 Older
Project Member

Comment 36 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b463fdc0bafb4e9e3a1da7f78a7fad74ebf0e06b

commit b463fdc0bafb4e9e3a1da7f78a7fad74ebf0e06b
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Thu Nov 02 08:11:15 2017

CORSURLLoader: Implement CORS response header checks

Implement CORSURLLoader::OnReceiveResponse to handle CORS
access checks in CORSURLLoader. This initial implementation
does not handle service worker cases yet.

To prepare for passing CORS related errors from CORSURLLoader
to Blink, this patch also adds CORSError information to
ResourceRequestCompletionStatus.

Bug: 736308
Change-Id: I2ff7af8dc54cf1c519e9c0b44478dace80b8f155
Reviewed-on: https://chromium-review.googlesource.com/735242
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513425}
[modify] https://crrev.com/b463fdc0bafb4e9e3a1da7f78a7fad74ebf0e06b/content/common/resource_messages.h
[modify] https://crrev.com/b463fdc0bafb4e9e3a1da7f78a7fad74ebf0e06b/content/public/common/resource_request_completion_status.cc
[modify] https://crrev.com/b463fdc0bafb4e9e3a1da7f78a7fad74ebf0e06b/content/public/common/resource_request_completion_status.h
[modify] https://crrev.com/b463fdc0bafb4e9e3a1da7f78a7fad74ebf0e06b/content/renderer/loader/cors_url_loader.cc
[modify] https://crrev.com/b463fdc0bafb4e9e3a1da7f78a7fad74ebf0e06b/content/renderer/loader/cors_url_loader.h
[modify] https://crrev.com/b463fdc0bafb4e9e3a1da7f78a7fad74ebf0e06b/content/renderer/loader/cors_url_loader_unittest.cc
[modify] https://crrev.com/b463fdc0bafb4e9e3a1da7f78a7fad74ebf0e06b/third_party/WebKit/LayoutTests/TestExpectations

Components: Internals>Network>Service
Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
Project Member

Comment 39 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f871692341367e4bf47d1204619aa8e50b15447b

commit f871692341367e4bf47d1204619aa8e50b15447b
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Wed Nov 08 04:40:58 2017

Use ResourceRequestCompletionStatus in callbacks too

Now we have CORS error details in ResourceRequestCompletionStatus,
and need to plumb these information to Blink.

We could pass them as extra callback arguments, but we prefer
to pass ResourceRequestCompletionStatus directly.

In the near future, ResourceRequestCompletionStatus will replace
WebURLError in Blink.

Bug: 736308
Change-Id: I6ab250d1a0be4ae33c8732e02fd5950979df87c9
Reviewed-on: https://chromium-review.googlesource.com/756102
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514739}
[modify] https://crrev.com/f871692341367e4bf47d1204619aa8e50b15447b/chrome/renderer/extensions/extension_localization_peer.cc
[modify] https://crrev.com/f871692341367e4bf47d1204619aa8e50b15447b/chrome/renderer/extensions/extension_localization_peer.h
[modify] https://crrev.com/f871692341367e4bf47d1204619aa8e50b15447b/chrome/renderer/extensions/extension_localization_peer_unittest.cc
[modify] https://crrev.com/f871692341367e4bf47d1204619aa8e50b15447b/chrome/renderer/security_filter_peer.cc
[modify] https://crrev.com/f871692341367e4bf47d1204619aa8e50b15447b/chrome/renderer/security_filter_peer.h
[modify] https://crrev.com/f871692341367e4bf47d1204619aa8e50b15447b/content/public/common/resource_request_completion_status.cc
[modify] https://crrev.com/f871692341367e4bf47d1204619aa8e50b15447b/content/public/common/resource_request_completion_status.h
[modify] https://crrev.com/f871692341367e4bf47d1204619aa8e50b15447b/content/public/renderer/request_peer.h
[modify] https://crrev.com/f871692341367e4bf47d1204619aa8e50b15447b/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/f871692341367e4bf47d1204619aa8e50b15447b/content/renderer/loader/resource_dispatcher_unittest.cc
[modify] https://crrev.com/f871692341367e4bf47d1204619aa8e50b15447b/content/renderer/loader/sync_load_context.cc
[modify] https://crrev.com/f871692341367e4bf47d1204619aa8e50b15447b/content/renderer/loader/sync_load_context.h
[modify] https://crrev.com/f871692341367e4bf47d1204619aa8e50b15447b/content/renderer/loader/test_request_peer.cc
[modify] https://crrev.com/f871692341367e4bf47d1204619aa8e50b15447b/content/renderer/loader/test_request_peer.h
[modify] https://crrev.com/f871692341367e4bf47d1204619aa8e50b15447b/content/renderer/loader/url_response_body_consumer_unittest.cc
[modify] https://crrev.com/f871692341367e4bf47d1204619aa8e50b15447b/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/f871692341367e4bf47d1204619aa8e50b15447b/content/renderer/loader/web_url_loader_impl_unittest.cc

Project Member

Comment 40 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f9885309f1379e6e189faf292610505c0df20c7

commit 8f9885309f1379e6e189faf292610505c0df20c7
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Mon Nov 13 07:32:37 2017

Move ResourceRequestCompletionStatus to services/network/public/cpp

This patch moves content::ResourceRequestCompletionStatus from
content/public/common/ to services/network/public/cpp, and renames
it to URLLoaderStatus so to be consistent with mojom mapped type name.

TBR: jam@chromium.org, mkwst@chromium.org
Bug: 736308, 748491
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I7608eba2a3c0419b1cbc1cf08313ac71eeb2e9c3
Reviewed-on: https://chromium-review.googlesource.com/756822
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515897}
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/chrome/browser/net/network_context_configuration_browsertest.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/chrome/renderer/DEPS
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/chrome/renderer/extensions/DEPS
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/chrome/renderer/extensions/extension_localization_peer.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/chrome/renderer/extensions/extension_localization_peer.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/chrome/renderer/extensions/extension_localization_peer_unittest.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/chrome/renderer/security_filter_peer.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/chrome/renderer/security_filter_peer.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/appcache/appcache_subresource_url_factory.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/appcache/appcache_update_job_unittest.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/appcache/appcache_update_url_loader_request.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/appcache/appcache_update_url_loader_request.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/appcache/appcache_url_loader_job.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/blob_storage/blob_internals_url_loader.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/blob_storage/blob_url_loader_factory.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/blob_storage/blob_url_unittest.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/devtools/service_worker_devtools_agent_host.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/devtools/service_worker_devtools_agent_host.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/download/download_response_handler.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/download/download_response_handler.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/download/resource_downloader.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/file_url_loader_factory.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/histogram_internals_url_loader.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/loader/async_resource_handler.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/loader/async_resource_handler_unittest.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/loader/mojo_async_resource_handler.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/loader/mojo_async_resource_handler_unittest.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/loader/navigation_url_loader.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/loader/navigation_url_loader_network_service.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/loader/url_loader_factory_impl_unittest.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/service_worker/service_worker_script_url_loader.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/service_worker/service_worker_script_url_loader.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/service_worker/service_worker_script_url_loader_unittest.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/service_worker/service_worker_url_loader_job.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/service_worker/service_worker_url_loader_job.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/webui/network_error_url_loader.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/browser/webui/web_ui_url_loader_factory.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/common/DEPS
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/common/resource_messages.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/common/throttling_url_loader.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/common/throttling_url_loader.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/common/throttling_url_loader_unittest.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/network/cache_url_loader.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/network/network_service_unittest.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/network/url_loader.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/network/url_loader_unittest.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/public/common/BUILD.gn
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/public/common/DEPS
[delete] https://crrev.com/2f7f096d5b9fb46ee45b77b1101bbae07301e392/content/public/common/resource_request_completion_status.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/public/common/simple_url_loader.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/public/common/simple_url_loader_unittest.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/public/common/url_loader.mojom
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/public/common/url_loader_status.typemap
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/public/renderer/request_peer.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/public/test/DEPS
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/public/test/test_url_loader_client.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/public/test/test_url_loader_client.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/fetchers/resource_fetcher_impl.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/loader/cors_url_loader.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/loader/cors_url_loader.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/loader/cors_url_loader_unittest.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/loader/resource_dispatcher.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/loader/resource_dispatcher_unittest.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/loader/sync_load_context.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/loader/sync_load_context.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/loader/test_request_peer.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/loader/test_request_peer.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/loader/url_loader_client_impl.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/loader/url_loader_client_impl.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/loader/url_loader_client_impl_unittest.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/loader/url_response_body_consumer.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/loader/url_response_body_consumer.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/loader/url_response_body_consumer_unittest.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/loader/web_url_loader_impl_unittest.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/service_worker/service_worker_subresource_loader.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/extensions/browser/DEPS
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/extensions/browser/extension_protocols.cc
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/services/network/public/cpp/BUILD.gn
[add] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/services/network/public/cpp/url_loader_status.cc
[rename] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/services/network/public/cpp/url_loader_status.h
[modify] https://crrev.com/8f9885309f1379e6e189faf292610505c0df20c7/third_party/WebKit/public/BUILD.gn

Project Member

Comment 41 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02dfc19620b23ac7ea313f15469eb47674b802fe

commit 02dfc19620b23ac7ea313f15469eb47674b802fe
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Thu Nov 16 11:27:47 2017

CORSURLLoader: Implement simple FetchRequestMode check

Implement simple FetchRequestMode check in CORSURLLoader, and add
kDisallowedByMode CORSError to pass the error type to Blink.

CORSError::GetErrorString() supports the kDisallowedByMode error
and DocumentThreadableLoader uses it to generate console errors.

TBR: mkwst@chromium.org
Bug: 736308
Change-Id: I0b3a5f77732e00598b729648aeb18d9c969d696b
Reviewed-on: https://chromium-review.googlesource.com/743883
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517056}
[modify] https://crrev.com/02dfc19620b23ac7ea313f15469eb47674b802fe/content/renderer/loader/cors_url_loader.cc
[modify] https://crrev.com/02dfc19620b23ac7ea313f15469eb47674b802fe/content/renderer/loader/cors_url_loader_unittest.cc
[modify] https://crrev.com/02dfc19620b23ac7ea313f15469eb47674b802fe/services/network/public/interfaces/cors.mojom
[modify] https://crrev.com/02dfc19620b23ac7ea313f15469eb47674b802fe/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/02dfc19620b23ac7ea313f15469eb47674b802fe/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/02dfc19620b23ac7ea313f15469eb47674b802fe/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
[modify] https://crrev.com/02dfc19620b23ac7ea313f15469eb47674b802fe/third_party/WebKit/Source/platform/exported/WebCORS.cpp

Project Member

Comment 42 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09bdfef5e33dfc105ab57f0d25598a4bd409e1a3

commit 09bdfef5e33dfc105ab57f0d25598a4bd409e1a3
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Thu Nov 16 12:37:07 2017

CORSURLLoaderTest: submit remaining tests that the original CL had

This patch imports all remaining tests that the original CL below had.
https://chromium-review.googlesource.com/c/chromium/src/+/558226

Bug: 736308
Change-Id: I9cfad08f695d63a440f395bdf51c9b072fc812ba
Reviewed-on: https://chromium-review.googlesource.com/763148
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517065}
[modify] https://crrev.com/09bdfef5e33dfc105ab57f0d25598a4bd409e1a3/content/renderer/loader/cors_url_loader.h
[modify] https://crrev.com/09bdfef5e33dfc105ab57f0d25598a4bd409e1a3/content/renderer/loader/cors_url_loader_unittest.cc

Project Member

Comment 43 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/961944cea6c9349489a9be3d629334e57e5cd1f4

commit 961944cea6c9349489a9be3d629334e57e5cd1f4
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Thu Nov 16 15:33:40 2017

Use network::mojom::CORSPreflightPolicy in Blink

To expose the CORS preflight policy, this patch introduces
network::mojom::CORSPreflightPolicy to be used in
content::ResourceRequest, and everywhere in Blink.

This will replace ThreadableLoaderOptions::PreflightPolicy
and WebAssociatedURLLoaderOptions::PreflightPolicy.

Tbr: dalecurtis@chromium.org
Bug: 736308
Change-Id: I5066b05527d9d875cec9f20579470114e6841f11
Reviewed-on: https://chromium-review.googlesource.com/766087
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517089}
[modify] https://crrev.com/961944cea6c9349489a9be3d629334e57e5cd1f4/content/public/common/resource_request.h
[modify] https://crrev.com/961944cea6c9349489a9be3d629334e57e5cd1f4/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/961944cea6c9349489a9be3d629334e57e5cd1f4/media/blink/resource_multibuffer_data_provider.cc
[modify] https://crrev.com/961944cea6c9349489a9be3d629334e57e5cd1f4/services/network/public/interfaces/cors.mojom
[modify] https://crrev.com/961944cea6c9349489a9be3d629334e57e5cd1f4/third_party/WebKit/Source/core/exported/WebAssociatedURLLoaderImpl.cpp
[modify] https://crrev.com/961944cea6c9349489a9be3d629334e57e5cd1f4/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/961944cea6c9349489a9be3d629334e57e5cd1f4/third_party/WebKit/Source/core/loader/ThreadableLoader.h
[modify] https://crrev.com/961944cea6c9349489a9be3d629334e57e5cd1f4/third_party/WebKit/Source/modules/eventsource/EventSource.cpp
[modify] https://crrev.com/961944cea6c9349489a9be3d629334e57e5cd1f4/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp
[modify] https://crrev.com/961944cea6c9349489a9be3d629334e57e5cd1f4/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/961944cea6c9349489a9be3d629334e57e5cd1f4/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.cpp
[modify] https://crrev.com/961944cea6c9349489a9be3d629334e57e5cd1f4/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h
[modify] https://crrev.com/961944cea6c9349489a9be3d629334e57e5cd1f4/third_party/WebKit/public/platform/DEPS
[modify] https://crrev.com/961944cea6c9349489a9be3d629334e57e5cd1f4/third_party/WebKit/public/platform/WebURLRequest.h
[modify] https://crrev.com/961944cea6c9349489a9be3d629334e57e5cd1f4/third_party/WebKit/public/web/DEPS
[modify] https://crrev.com/961944cea6c9349489a9be3d629334e57e5cd1f4/third_party/WebKit/public/web/WebAssociatedURLLoaderOptions.h

Cc: tyoshino@chromium.org
Owner: toyoshim@chromium.org
Project Member

Comment 45 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0326c088ba772ae53bd426f0eb4ef478053b88d3

commit 0326c088ba772ae53bd426f0eb4ef478053b88d3
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Fri Nov 17 13:03:05 2017

Plumb extra errors from ResourceRequestCompletionStatus to Blink

This patch plumbs CORSError and HTTP response headers
from ResourceRequestCompletinoStatus to Blink's ResourceError.

Test: ./Tools/Scripts/run-webkit-tests virtual/outofblink-cors
Bug: 736308
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I20e4ec9a2e7ca93ce692a5a8312dadf59eb0f345
Reviewed-on: https://chromium-review.googlesource.com/749024
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517388}
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/content/common/resource_messages.h
[add] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/content/public/common/cors_error_status.typemap
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/content/public/common/typemaps.gni
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/content/public/common/url_loader.mojom
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/content/renderer/loader/cors_url_loader.cc
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/content/renderer/loader/cors_url_loader_unittest.cc
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/content/renderer/loader/sync_load_context.cc
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/content/renderer/loader/sync_load_response.h
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/services/network/public/cpp/BUILD.gn
[add] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/services/network/public/cpp/cors_error_status.cc
[add] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/services/network/public/cpp/cors_error_status.h
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/services/network/public/cpp/url_loader_status.cc
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/services/network/public/cpp/url_loader_status.h
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/third_party/WebKit/Source/platform/DEPS
[add] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/third_party/WebKit/Source/platform/exported/WebURLError.cpp
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/third_party/WebKit/Source/platform/loader/BUILD.gn
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/third_party/WebKit/Source/platform/loader/DEPS
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/third_party/WebKit/Source/platform/loader/fetch/ResourceError.cpp
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/third_party/WebKit/Source/platform/loader/fetch/ResourceError.h
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/third_party/WebKit/public/platform/DEPS
[modify] https://crrev.com/0326c088ba772ae53bd426f0eb4ef478053b88d3/third_party/WebKit/public/platform/WebURLError.h

Project Member

Comment 46 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca15bd417b260827f982762c966ccbc5f888df3e

commit ca15bd417b260827f982762c966ccbc5f888df3e
Author: Guido Urdaneta <guidou@chromium.org>
Date: Fri Nov 17 16:40:39 2017

Revert "Plumb extra errors from ResourceRequestCompletionStatus to Blink"

This reverts commit 0326c088ba772ae53bd426f0eb4ef478053b88d3.

Reason for revert: Suspect of causing virtual/outofblink-cors/external/wpt/service-workers/service-worker/fetch-request-fallback.https.html to fail on several Mac and Linux bots.

See for example
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.12/builds/7923

Original change's description:
> Plumb extra errors from ResourceRequestCompletionStatus to Blink
> 
> This patch plumbs CORSError and HTTP response headers
> from ResourceRequestCompletinoStatus to Blink's ResourceError.
> 
> Test: ./Tools/Scripts/run-webkit-tests virtual/outofblink-cors
> Bug: 736308
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: I20e4ec9a2e7ca93ce692a5a8312dadf59eb0f345
> Reviewed-on: https://chromium-review.googlesource.com/749024
> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517388}

TBR=kinuko@chromium.org,toyoshim@chromium.org,tyoshino@chromium.org,yhirano@chromium.org,mkwst@chromium.org

Change-Id: Ib973ef76eaab93e4c4dbf9b08712bbd560eac368
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 736308
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/776913
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517426}
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/content/common/resource_messages.h
[delete] https://crrev.com/6c949ae1df12323ece291785ec942d7ac51729d9/content/public/common/cors_error_status.typemap
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/content/public/common/typemaps.gni
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/content/public/common/url_loader.mojom
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/content/renderer/loader/cors_url_loader.cc
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/content/renderer/loader/cors_url_loader_unittest.cc
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/content/renderer/loader/sync_load_context.cc
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/content/renderer/loader/sync_load_response.h
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/services/network/public/cpp/BUILD.gn
[delete] https://crrev.com/6c949ae1df12323ece291785ec942d7ac51729d9/services/network/public/cpp/cors_error_status.cc
[delete] https://crrev.com/6c949ae1df12323ece291785ec942d7ac51729d9/services/network/public/cpp/cors_error_status.h
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/services/network/public/cpp/url_loader_status.cc
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/services/network/public/cpp/url_loader_status.h
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/third_party/WebKit/Source/platform/DEPS
[delete] https://crrev.com/6c949ae1df12323ece291785ec942d7ac51729d9/third_party/WebKit/Source/platform/exported/WebURLError.cpp
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/third_party/WebKit/Source/platform/loader/BUILD.gn
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/third_party/WebKit/Source/platform/loader/DEPS
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/third_party/WebKit/Source/platform/loader/fetch/ResourceError.cpp
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/third_party/WebKit/Source/platform/loader/fetch/ResourceError.h
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/third_party/WebKit/public/platform/DEPS
[modify] https://crrev.com/ca15bd417b260827f982762c966ccbc5f888df3e/third_party/WebKit/public/platform/WebURLError.h

Project Member

Comment 47 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccd0bd543ffb5679824313b8a6918e3a021cdcaa

commit ccd0bd543ffb5679824313b8a6918e3a021cdcaa
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Mon Nov 20 05:47:54 2017

Reland "Plumb extra errors from ResourceRequestCompletionStatus to Blink"

Update TestExpectations to mark fetch-request-fallback.https.html
as [ Crash Failure ] rather than [ Crash ].

This is a reland of 0326c088ba772ae53bd426f0eb4ef478053b88d3
Original change's description:
> Plumb extra errors from ResourceRequestCompletionStatus to Blink
>
> This patch plumbs CORSError and HTTP response headers
> from ResourceRequestCompletinoStatus to Blink's ResourceError.
>
> Test: ./Tools/Scripts/run-webkit-tests virtual/outofblink-cors
> Bug: 736308
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: I20e4ec9a2e7ca93ce692a5a8312dadf59eb0f345
> Reviewed-on: https://chromium-review.googlesource.com/749024
> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517388}

Bug: 736308
Change-Id: I8439662f9363e180839060c5245d2327324d1583
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Tbr: kinuko@chromium.org, tyoshino@chromium.org, yhirano@chromium.org, mkwst@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/778220
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517759}
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/content/common/resource_messages.h
[add] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/content/public/common/cors_error_status.typemap
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/content/public/common/typemaps.gni
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/content/public/common/url_loader.mojom
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/content/renderer/loader/cors_url_loader.cc
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/content/renderer/loader/cors_url_loader_unittest.cc
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/content/renderer/loader/sync_load_context.cc
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/content/renderer/loader/sync_load_response.h
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/services/network/public/cpp/BUILD.gn
[add] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/services/network/public/cpp/cors_error_status.cc
[add] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/services/network/public/cpp/cors_error_status.h
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/services/network/public/cpp/url_loader_status.cc
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/services/network/public/cpp/url_loader_status.h
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/third_party/WebKit/Source/platform/DEPS
[add] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/third_party/WebKit/Source/platform/exported/WebURLError.cpp
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/third_party/WebKit/Source/platform/loader/BUILD.gn
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/third_party/WebKit/Source/platform/loader/DEPS
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/third_party/WebKit/Source/platform/loader/fetch/ResourceError.cpp
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/third_party/WebKit/Source/platform/loader/fetch/ResourceError.h
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/third_party/WebKit/public/platform/DEPS
[modify] https://crrev.com/ccd0bd543ffb5679824313b8a6918e3a021cdcaa/third_party/WebKit/public/platform/WebURLError.h

Project Member

Comment 48 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa27866ffee152f4c9bc36723c4f722cff0d3944

commit aa27866ffee152f4c9bc36723c4f722cff0d3944
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Mon Nov 20 11:11:26 2017

Rename network::URLLoaderStatus to network::URLLoaderCompletionStatus

URLLoaderStatus is used in URLLoaderClient::OnComplete to notify
the loader's completion status. In comparison with other types used
in other callback arguments in URLLoaderClient, the name "URLLoaderStatus"
is too generic, and does not explain what it actually represents.

This patch renames it to URLLoaderCompletionStatus. Since the native
struct was named as ResourceRequestCompletionStatus, it should sound
reasonable.

Bug: 736308
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic6aea2a31fab18f102d2f7f56183eaa016e07583
Reviewed-on: https://chromium-review.googlesource.com/776016
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517794}
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/chrome/browser/net/network_context_configuration_browsertest.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/chrome/renderer/extensions/extension_localization_peer.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/chrome/renderer/extensions/extension_localization_peer.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/chrome/renderer/extensions/extension_localization_peer_unittest.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/chrome/renderer/security_filter_peer.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/chrome/renderer/security_filter_peer.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/appcache/appcache_subresource_url_factory.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/appcache/appcache_update_job_unittest.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/appcache/appcache_update_url_loader_request.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/appcache/appcache_update_url_loader_request.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/appcache/appcache_url_loader_job.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/blob_storage/blob_internals_url_loader.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/blob_storage/blob_url_loader_factory.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/blob_storage/blob_url_unittest.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/devtools/service_worker_devtools_agent_host.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/devtools/service_worker_devtools_agent_host.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/download/download_manager_impl.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/download/download_response_handler.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/download/download_response_handler.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/download/resource_downloader.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/download/resource_downloader.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/file_url_loader_factory.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/histogram_internals_url_loader.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/loader/async_resource_handler.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/loader/async_resource_handler_unittest.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/loader/mojo_async_resource_handler.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/loader/mojo_async_resource_handler_unittest.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/loader/navigation_url_loader.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/loader/navigation_url_loader_network_service.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/loader/url_loader_factory_impl_unittest.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/service_worker/service_worker_script_url_loader.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/service_worker/service_worker_script_url_loader.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/service_worker/service_worker_script_url_loader_unittest.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/service_worker/service_worker_url_loader_job.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/service_worker/service_worker_url_loader_job.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/webui/network_error_url_loader.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/browser/webui/web_ui_url_loader_factory.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/common/resource_messages.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/common/throttling_url_loader.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/common/throttling_url_loader.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/common/throttling_url_loader_unittest.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/network/cache_url_loader.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/network/network_service_unittest.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/network/url_loader.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/network/url_loader_unittest.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/public/common/simple_url_loader.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/public/common/simple_url_loader_unittest.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/public/common/typemaps.gni
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/public/common/url_loader.mojom
[rename] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/public/common/url_loader_completion_status.typemap
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/public/renderer/request_peer.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/public/test/test_url_loader_client.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/public/test/test_url_loader_client.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/fetchers/resource_fetcher_impl.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/loader/cors_url_loader.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/loader/cors_url_loader.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/loader/cors_url_loader_unittest.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/loader/resource_dispatcher.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/loader/resource_dispatcher.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/loader/resource_dispatcher_unittest.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/loader/sync_load_context.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/loader/sync_load_context.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/loader/test_request_peer.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/loader/test_request_peer.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/loader/url_loader_client_impl.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/loader/url_loader_client_impl.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/loader/url_loader_client_impl_unittest.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/loader/url_response_body_consumer.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/loader/url_response_body_consumer.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/loader/url_response_body_consumer_unittest.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/loader/web_url_loader_impl_unittest.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/service_worker/service_worker_subresource_loader.h
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/extensions/browser/extension_protocols.cc
[modify] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/services/network/public/cpp/BUILD.gn
[add] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/services/network/public/cpp/url_loader_completion_status.cc
[rename] https://crrev.com/aa27866ffee152f4c9bc36723c4f722cff0d3944/services/network/public/cpp/url_loader_completion_status.h
[delete] https://crrev.com/ef11aff0688d84898e71c7d6021f0e51109d416e/services/network/public/cpp/url_loader_status.cc

Project Member

Comment 49 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0d92c5d1765633b60e397df001cad5894935467

commit d0d92c5d1765633b60e397df001cad5894935467
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Tue Nov 28 08:12:29 2017

Move redirect ResourceRequest creation code to ResourceRequest

ResourceLoader had a code that constructs a new ResourceRequest
for a redirect, and setup properties based on the last ResourceRequest.

This code will be broken easily when people add new items to
ResourceRequest because it's hard to notice that we also need to
copy the new items even in ResourceLoader for redirection.

This patch moves the creation code to ResourceRequest so that
people who are going to change ResourceRequest can easily notice
the requirement.

Bug: 736308, 787704
Change-Id: I605b4c20f14b02fc5418878aa329687dce3638a4
Reviewed-on: https://chromium-review.googlesource.com/776407
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519604}
[modify] https://crrev.com/d0d92c5d1765633b60e397df001cad5894935467/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/d0d92c5d1765633b60e397df001cad5894935467/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.cpp
[modify] https://crrev.com/d0d92c5d1765633b60e397df001cad5894935467/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h

Blocking: 665766
Project Member

Comment 51 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3051c20769d3ff4bff3ac508541b684ee48367e

commit e3051c20769d3ff4bff3ac508541b684ee48367e
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Fri Dec 08 12:48:05 2017

upload-progress-events.html is flaky

This CL add Pass and Timeout to the test expectations.

Example of failure https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/65069

webkit_layout_tests
Run on OS: 'Windows-7-SP1'
Max shard duration: 0:34:44.139080 (shard #9)
Total tests: 68294
* Passed: 55081 (54978 expected, 103 unexpected)
* Skipped: 11614 (11614 expected, 0 unexpected)
* Failed: 1547 (1546 expected, >>>1 unexpected<<<)
* Flaky: 52 (51 expected, >>>1 unexpected<<<)

Unexpected Failures:
* http/tests/devtools/sources/debugger-ui/reveal-not-skipped.js

Unexpected Flakes:
* virtual/outofblink-cors/http/tests/xmlhttprequest/upload-progress-events.html

TBR=toyoshim@chromium.org, tyoshino@chromium.org, mkwst@chromium.org

Bug: 736308
Change-Id: I5ccd884031a1ed2873cf911c48675ff93b45a7c1
Reviewed-on: https://chromium-review.googlesource.com/817074
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522767}
[modify] https://crrev.com/e3051c20769d3ff4bff3ac508541b684ee48367e/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 52 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33b51456ca63f428c450b877e75d733b0d6faaff

commit 33b51456ca63f428c450b877e75d733b0d6faaff
Author: Chris Mumford <cmumford@chromium.org>
Date: Tue Dec 19 01:36:26 2017

Fixed completion_status comment for TestURLLoaderClient.

Updated a comment that was not updated when status() was renamed
to completion_status() in aa27866ffee152f4c9.

TBR=sky@chromium.org, toyoshim@chromium.org

Bug: 736308
Change-Id: I62a8f9f7322eee6d1bd7d500b11330e77057fa47
Reviewed-on: https://chromium-review.googlesource.com/833337
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524898}
[modify] https://crrev.com/33b51456ca63f428c450b877e75d733b0d6faaff/content/public/test/test_url_loader_client.h

Blocking: 792154
Blockedon: -427429 -730912
Blocking: 427429 730912
update blocked/blocking relationships to reflect current dependencies.
Blockedon: 800669
Project Member

Comment 56 by bugdroid1@chromium.org, Jan 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/813bf659ea6172e773b9a5dff7f75843ef65cbca

commit 813bf659ea6172e773b9a5dff7f75843ef65cbca
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Tue Jan 16 02:32:06 2018

OOR-CORS: Implements network service version of CheckAccess()

This patch implements an equivalent of blink::WebCORS::CheckAccess() in
network service, and use it in CORSURLLloader. This will make the
CORSURLLoader ready to be moved into content/network.

Bug: 736308
Change-Id: If8acc31a74f9680518ea319a4e25c0843bc9521d
Reviewed-on: https://chromium-review.googlesource.com/858638
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529357}
[modify] https://crrev.com/813bf659ea6172e773b9a5dff7f75843ef65cbca/content/renderer/loader/cors_url_loader.cc
[modify] https://crrev.com/813bf659ea6172e773b9a5dff7f75843ef65cbca/services/network/public/cpp/BUILD.gn
[add] https://crrev.com/813bf659ea6172e773b9a5dff7f75843ef65cbca/services/network/public/cpp/cors/cors.cc
[add] https://crrev.com/813bf659ea6172e773b9a5dff7f75843ef65cbca/services/network/public/cpp/cors/cors.h
[add] https://crrev.com/813bf659ea6172e773b9a5dff7f75843ef65cbca/services/network/public/cpp/cors/cors_unittest.cc

Project Member

Comment 57 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/baa086e6ce88ffd04dff6d76480ef4652181d677

commit baa086e6ce88ffd04dff6d76480ef4652181d677
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Wed Jan 17 04:35:35 2018

OOR-CORS: move cors_error_status.{cc|h} to cors sub-directory

This is a mechanical change to move cors_error_status.{cc|h} in
services/network/public/cpp to the cors sub-directory.

Bug: 736308
Change-Id: I5ed6378fd5650e7a47ec2fead716a03d7a169589
Reviewed-on: https://chromium-review.googlesource.com/867825
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529607}
[modify] https://crrev.com/baa086e6ce88ffd04dff6d76480ef4652181d677/content/public/common/cors_error_status.typemap
[modify] https://crrev.com/baa086e6ce88ffd04dff6d76480ef4652181d677/services/network/public/cpp/BUILD.gn
[rename] https://crrev.com/baa086e6ce88ffd04dff6d76480ef4652181d677/services/network/public/cpp/cors/cors_error_status.cc
[rename] https://crrev.com/baa086e6ce88ffd04dff6d76480ef4652181d677/services/network/public/cpp/cors/cors_error_status.h
[modify] https://crrev.com/baa086e6ce88ffd04dff6d76480ef4652181d677/services/network/public/cpp/network_param_ipc_traits.h
[modify] https://crrev.com/baa086e6ce88ffd04dff6d76480ef4652181d677/services/network/public/cpp/url_loader_completion_status.h
[modify] https://crrev.com/baa086e6ce88ffd04dff6d76480ef4652181d677/third_party/WebKit/Source/platform/loader/fetch/ResourceError.h
[modify] https://crrev.com/baa086e6ce88ffd04dff6d76480ef4652181d677/third_party/WebKit/public/platform/DEPS
[modify] https://crrev.com/baa086e6ce88ffd04dff6d76480ef4652181d677/third_party/WebKit/public/platform/WebURLError.h

Project Member

Comment 58 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/346b829734749ae3a31a2a07bfd66e5b3fd87a8d

commit 346b829734749ae3a31a2a07bfd66e5b3fd87a8d
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Wed Jan 17 10:57:12 2018

OOR-CORS: merge all FetchRedirectMode into one Mojo enum

We have three equivalents of FetchRedirectMode in content,
blink::WebURLRequest, and blink::mojom. This patch introduces
network::mojom::FetchRedirectMode that can be accessible from
all places, and merge these three enums into one.

Bug: 736308
Change-Id: Ie0d94f983d7c00f2c2ab4a2b7653981e74b639d5
Reviewed-on: https://chromium-review.googlesource.com/870012
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529701}
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/browser/loader/navigation_url_loader_network_service.cc
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/browser/service_worker/service_worker_context_request_handler_unittest.cc
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/browser/service_worker/service_worker_controllee_request_handler.cc
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/browser/service_worker/service_worker_controllee_request_handler.h
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/browser/service_worker/service_worker_data_pipe_reader_unittest.cc
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/browser/service_worker/service_worker_provider_host.cc
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/browser/service_worker/service_worker_provider_host.h
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/browser/service_worker/service_worker_request_handler.cc
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/browser/service_worker/service_worker_request_handler.h
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/browser/service_worker/service_worker_request_handler_unittest.cc
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/browser/service_worker/service_worker_url_loader_job.cc
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/browser/service_worker/service_worker_url_request_job.cc
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/browser/service_worker/service_worker_url_request_job.h
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/common/resource_messages.h
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/common/service_worker/service_worker_fetch_request.typemap
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/common/service_worker/service_worker_fetch_request_struct_traits.cc
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/common/service_worker/service_worker_fetch_request_struct_traits.h
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/common/service_worker/service_worker_loader_helpers.cc
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/common/service_worker/service_worker_types.h
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/public/common/service_worker_modes.h
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/public/common/service_worker_modes.typemap
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/renderer/loader/web_url_request_util.cc
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/renderer/loader/web_url_request_util.h
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/services/network/public/cpp/resource_request.h
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/services/network/public/interfaces/fetch_api.mojom
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/Source/core/fetch/FetchManager.cpp
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/Source/core/fetch/FetchRequestData.cpp
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/Source/core/fetch/FetchRequestData.h
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/Source/core/fetch/Request.cpp
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/Source/core/fetch/RequestTest.cpp
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/Source/core/loader/FrameLoadRequest.cpp
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/Source/core/loader/PingLoader.cpp
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.cpp
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.h
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/Source/platform/exported/WebServiceWorkerRequest.cpp
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.cpp
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/Source/platform/mojo/FetchAPIRequestStructTraits.cpp
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/Source/platform/mojo/FetchAPIRequestStructTraits.h
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/public/platform/WebURLRequest.h
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/public/platform/modules/fetch/FetchAPIRequest.typemap
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/public/platform/modules/fetch/fetch_api_request.mojom
[modify] https://crrev.com/346b829734749ae3a31a2a07bfd66e5b3fd87a8d/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRequest.h

Project Member

Comment 59 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13b9fae4754806a5a72df14b71cc409f73caa8d2

commit 13b9fae4754806a5a72df14b71cc409f73caa8d2
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Thu Jan 18 10:56:26 2018

OOR-CORS: Replace WebCORS::CheckAccess implementation

Replace WebCORS::CheckAccess() with network::cors::CheckAccess().
This is done behind a thin CORS::CheckAccess() wrapper to avoid
Blink dependency violations.

Bug: 736308
Change-Id: I60c3772b577df5806490649ac18cdaac298d9dee
Reviewed-on: https://chromium-review.googlesource.com/866617
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530116}
[modify] https://crrev.com/13b9fae4754806a5a72df14b71cc409f73caa8d2/services/network/public/cpp/cors/cors.cc
[modify] https://crrev.com/13b9fae4754806a5a72df14b71cc409f73caa8d2/services/network/public/cpp/cors/cors_unittest.cc
[modify] https://crrev.com/13b9fae4754806a5a72df14b71cc409f73caa8d2/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/43-expected.txt
[modify] https://crrev.com/13b9fae4754806a5a72df14b71cc409f73caa8d2/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/13b9fae4754806a5a72df14b71cc409f73caa8d2/third_party/WebKit/Source/platform/exported/WebCORS.cpp
[modify] https://crrev.com/13b9fae4754806a5a72df14b71cc409f73caa8d2/third_party/WebKit/Source/platform/loader/BUILD.gn
[modify] https://crrev.com/13b9fae4754806a5a72df14b71cc409f73caa8d2/third_party/WebKit/Source/platform/loader/README.md
[add] https://crrev.com/13b9fae4754806a5a72df14b71cc409f73caa8d2/third_party/WebKit/Source/platform/loader/cors/CORS.cpp
[add] https://crrev.com/13b9fae4754806a5a72df14b71cc409f73caa8d2/third_party/WebKit/Source/platform/loader/cors/CORS.h
[modify] https://crrev.com/13b9fae4754806a5a72df14b71cc409f73caa8d2/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/13b9fae4754806a5a72df14b71cc409f73caa8d2/third_party/WebKit/public/platform/WebCORS.h

Project Member

Comment 60 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3cfc6644042d8874b23304138b3f2f437ac731b

commit d3cfc6644042d8874b23304138b3f2f437ac731b
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Thu Jan 18 12:34:40 2018

OOR-CORS: move WebCORS::GetErrorString() to CORS::GetErrorString()

This function is not and will not be used outside Blink, and should not
be in the Blink public API.

Bug: 736308
Change-Id: I4ae0ba067f89b7d7e681be6f2cf82baabc0c6270
Reviewed-on: https://chromium-review.googlesource.com/866653
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530124}
[modify] https://crrev.com/d3cfc6644042d8874b23304138b3f2f437ac731b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/d3cfc6644042d8874b23304138b3f2f437ac731b/third_party/WebKit/Source/platform/exported/WebCORS.cpp
[modify] https://crrev.com/d3cfc6644042d8874b23304138b3f2f437ac731b/third_party/WebKit/Source/platform/loader/cors/CORS.cpp
[modify] https://crrev.com/d3cfc6644042d8874b23304138b3f2f437ac731b/third_party/WebKit/Source/platform/loader/cors/CORS.h
[modify] https://crrev.com/d3cfc6644042d8874b23304138b3f2f437ac731b/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/d3cfc6644042d8874b23304138b3f2f437ac731b/third_party/WebKit/public/platform/WebCORS.h

Project Member

Comment 61 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf046945877b6dbe27f96e3f80fbc317b073f0fa

commit cf046945877b6dbe27f96e3f80fbc317b073f0fa
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Thu Jan 18 14:48:31 2018

OOR-CORS: use network::cors version of CheckRedirectLocation

The legacy implementation depends on Blink APIs that allow
embedders to add more schemes to pass the redirect location check.

This patch still holds the original scheme check that counts in
embedders' desired schemes in the legacy mode, but ignore them
in the out-of-blink CORS support mode.

Bug: 736308, 800669
Change-Id: I764126014c90fb5b14ee06393704269970be5639
Reviewed-on: https://chromium-review.googlesource.com/867828
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530140}
[modify] https://crrev.com/cf046945877b6dbe27f96e3f80fbc317b073f0fa/services/network/public/cpp/cors/cors.cc
[modify] https://crrev.com/cf046945877b6dbe27f96e3f80fbc317b073f0fa/services/network/public/cpp/cors/cors.h
[modify] https://crrev.com/cf046945877b6dbe27f96e3f80fbc317b073f0fa/services/network/public/cpp/cors/cors_unittest.cc
[modify] https://crrev.com/cf046945877b6dbe27f96e3f80fbc317b073f0fa/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/cf046945877b6dbe27f96e3f80fbc317b073f0fa/third_party/WebKit/Source/platform/exported/WebCORS.cpp
[modify] https://crrev.com/cf046945877b6dbe27f96e3f80fbc317b073f0fa/third_party/WebKit/Source/platform/loader/cors/CORS.cpp
[modify] https://crrev.com/cf046945877b6dbe27f96e3f80fbc317b073f0fa/third_party/WebKit/Source/platform/loader/cors/CORS.h
[modify] https://crrev.com/cf046945877b6dbe27f96e3f80fbc317b073f0fa/third_party/WebKit/public/platform/WebCORS.h

Project Member

Comment 62 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd89f40d4bdc5f8bcdbe1582adb1cbadb4ff4d7a

commit cd89f40d4bdc5f8bcdbe1582adb1cbadb4ff4d7a
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Thu Jan 18 20:50:20 2018

OOR-CORS: use network::cors version of Check[External]Preflight()

Bug: 736308
Change-Id: I88c2bebb8ef8fdb60dab1bbcdd385211448bd004
Reviewed-on: https://chromium-review.googlesource.com/867808
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530260}
[modify] https://crrev.com/cd89f40d4bdc5f8bcdbe1582adb1cbadb4ff4d7a/services/network/public/cpp/cors/cors.cc
[modify] https://crrev.com/cd89f40d4bdc5f8bcdbe1582adb1cbadb4ff4d7a/services/network/public/cpp/cors/cors.h
[modify] https://crrev.com/cd89f40d4bdc5f8bcdbe1582adb1cbadb4ff4d7a/services/network/public/cpp/cors/cors_unittest.cc
[modify] https://crrev.com/cd89f40d4bdc5f8bcdbe1582adb1cbadb4ff4d7a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/cd89f40d4bdc5f8bcdbe1582adb1cbadb4ff4d7a/third_party/WebKit/Source/platform/exported/WebCORS.cpp
[modify] https://crrev.com/cd89f40d4bdc5f8bcdbe1582adb1cbadb4ff4d7a/third_party/WebKit/Source/platform/loader/cors/CORS.cpp
[modify] https://crrev.com/cd89f40d4bdc5f8bcdbe1582adb1cbadb4ff4d7a/third_party/WebKit/Source/platform/loader/cors/CORS.h
[modify] https://crrev.com/cd89f40d4bdc5f8bcdbe1582adb1cbadb4ff4d7a/third_party/WebKit/public/platform/WebCORS.h

Blockedon: 803672
Blockedon: 803766
Project Member

Comment 65 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9334ced0cb384575504683dfa3016717b99c5a2

commit a9334ced0cb384575504683dfa3016717b99c5a2
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Jan 19 06:53:51 2018

URLLoaderFactoryImpl cleanup

URLLoaderFactoryImpl has two CreateLoaderAndStart functions: One is
a static method used by ResourceMessageFilter and another is an
instance method used by ServiceWorker navigation preload. This CL
removes the static function and has ResourceMessageFilter use a
URLLoaderFactoryImpl instance for consistency.

Bug: 736308
Change-Id: I5e687d8faf9bf8cc78abc0a66a19b407cf0c660c
Reviewed-on: https://chromium-review.googlesource.com/872553
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530442}
[modify] https://crrev.com/a9334ced0cb384575504683dfa3016717b99c5a2/content/browser/loader/resource_message_filter.cc
[modify] https://crrev.com/a9334ced0cb384575504683dfa3016717b99c5a2/content/browser/loader/resource_message_filter.h
[modify] https://crrev.com/a9334ced0cb384575504683dfa3016717b99c5a2/content/browser/loader/url_loader_factory_impl.cc
[modify] https://crrev.com/a9334ced0cb384575504683dfa3016717b99c5a2/content/browser/loader/url_loader_factory_impl.h
[modify] https://crrev.com/a9334ced0cb384575504683dfa3016717b99c5a2/content/browser/loader/url_loader_factory_impl_unittest.cc
[modify] https://crrev.com/a9334ced0cb384575504683dfa3016717b99c5a2/content/browser/service_worker/service_worker_fetch_dispatcher.cc

Project Member

Comment 66 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9d650af3544643bc2ecc81dd1399280ff1af419

commit c9d650af3544643bc2ecc81dd1399280ff1af419
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Fri Jan 19 11:40:42 2018

URLLoaderFactoryImpl followup for the last cleanup

In the last cleanup change below, OnConnectionError() was mistakenly
left in the header file. This patch just deletes it.

https://chromium-review.googlesource.com/c/chromium/src/+/872553

Bug: 736308
Change-Id: I863466d77d1556d1420dca265e7bef46ac0ebe02
Reviewed-on: https://chromium-review.googlesource.com/875687
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530486}
[modify] https://crrev.com/c9d650af3544643bc2ecc81dd1399280ff1af419/content/browser/loader/url_loader_factory_impl.h

Project Member

Comment 67 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42926ddd2790cb10623b7a990f21736b898ac878

commit 42926ddd2790cb10623b7a990f21736b898ac878
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Wed Jan 24 06:08:41 2018

OOR-CORS: Move CORSURLLoader from content/renderer to content/network

This patch moves content::CORSURLLoader from content/renderer to
the browser process, and hooks up URLLoaderFactoryImpl to use the
CORSURLLoader when kOutOfBlinkCORS feature is enabled.

With this patch, "chrome --enable-features=OutOfBlinkCORS" will handle
basic CORS checks in the browser process.

Test: ./Tools/Scripts/run-webkit-tests virtual/outofblink-cors
Test: ./out/Debug/chrome --enable-features=OutOfBlinkCORS
Test: ./out/Debug/content_unittests --gtest_filter="CORS*.*"
Bug: 736308
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: If646da1f022ceb040a6069ef8942c3909b7f01a1
Reviewed-on: https://chromium-review.googlesource.com/866657
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531454}
[modify] https://crrev.com/42926ddd2790cb10623b7a990f21736b898ac878/content/browser/loader/resource_message_filter.cc
[modify] https://crrev.com/42926ddd2790cb10623b7a990f21736b898ac878/content/browser/loader/url_loader_factory_impl.cc
[modify] https://crrev.com/42926ddd2790cb10623b7a990f21736b898ac878/content/network/BUILD.gn
[modify] https://crrev.com/42926ddd2790cb10623b7a990f21736b898ac878/content/network/DEPS
[rename] https://crrev.com/42926ddd2790cb10623b7a990f21736b898ac878/content/network/cors/cors_url_loader.cc
[rename] https://crrev.com/42926ddd2790cb10623b7a990f21736b898ac878/content/network/cors/cors_url_loader.h
[add] https://crrev.com/42926ddd2790cb10623b7a990f21736b898ac878/content/network/cors/cors_url_loader_factory.cc
[add] https://crrev.com/42926ddd2790cb10623b7a990f21736b898ac878/content/network/cors/cors_url_loader_factory.h
[rename] https://crrev.com/42926ddd2790cb10623b7a990f21736b898ac878/content/network/cors/cors_url_loader_unittest.cc
[modify] https://crrev.com/42926ddd2790cb10623b7a990f21736b898ac878/content/renderer/BUILD.gn
[delete] https://crrev.com/8c965371abdc7377fb01048959b75383f83c97d2/content/renderer/loader/cors_url_loader_factory.cc
[delete] https://crrev.com/8c965371abdc7377fb01048959b75383f83c97d2/content/renderer/loader/cors_url_loader_factory.h
[modify] https://crrev.com/42926ddd2790cb10623b7a990f21736b898ac878/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/42926ddd2790cb10623b7a990f21736b898ac878/content/test/BUILD.gn

Blockedon: 807565
Project Member

Comment 69 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35e3f875c500e48e0860be6099b21f7e52e4e5d9

commit 35e3f875c500e48e0860be6099b21f7e52e4e5d9
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Thu Feb 01 06:26:27 2018

OOR-CORS: move public/platform/CORSStatus to platform/loader/cors

CORSStatus.h is placed at public/platform, but is not used outside
Blink. This patch is a mechanical change to move the CORSStatus.h
to platform/loader/cors.

Bug: 736308
Change-Id: I0febd97b85fe8ad9ce7866925831b043e494081d
Reviewed-on: https://chromium-review.googlesource.com/892728
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533594}
[rename] https://crrev.com/35e3f875c500e48e0860be6099b21f7e52e4e5d9/third_party/WebKit/Source/platform/loader/cors/CORSStatus.h
[modify] https://crrev.com/35e3f875c500e48e0860be6099b21f7e52e4e5d9/third_party/WebKit/Source/platform/loader/fetch/Resource.h

Labels: OOR-CORS
Blockedon: 256976
Project Member

Comment 72 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc68cb1454636776f3a8858af6569efbffdd3f93

commit dc68cb1454636776f3a8858af6569efbffdd3f93
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Thu Feb 22 09:43:46 2018

OOR-CORS: change ServiceWorkerMode enums to bool

Until this change, we define the ServiceWorkerMode in
blink::WebURLRequest and has equivalent enum in content
for Service Worker implementation.

For network service, we just hold it as an integer value
in network::ResourceRequest, and didn't touch it inside
the network service.

Now that the enum have only two items, let me change it
to a boolean flag, 'skip_service_worker'.

ServiceWorkerMode::kAll is converted to skip_service_worker: false,
ServiceWorkerMode::kNone is to skip_service_worker: true.

Bug: 736308
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I07f562f66b66bfa3d833a18afb7985ff892e952a
Tbr: mseaborn@chromium.org, reillyg@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/873571
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538385}
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/components/nacl/renderer/ppb_nacl_private_impl.cc
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/content/common/resource_messages.h
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/content/public/common/service_worker_modes.h
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/content/public/renderer/associated_resource_fetcher.h
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/content/renderer/fetchers/associated_resource_fetcher_impl.cc
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/content/renderer/fetchers/associated_resource_fetcher_impl.h
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/content/renderer/loader/web_url_request_util.cc
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/content/renderer/loader/web_url_request_util.h
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/content/renderer/pepper/pepper_url_loader_host.cc
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/content/renderer/pepper/url_request_info_util.cc
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/content/renderer/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/content/renderer/service_worker/worker_fetch_context_impl.cc
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/services/network/public/cpp/network_param_ipc_traits.h
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/services/network/public/cpp/resource_request.h
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/third_party/WebKit/Source/core/fetch/FetchManager.cpp
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/third_party/WebKit/Source/core/loader/ImageLoader.cpp
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/third_party/WebKit/Source/platform/exported/WebCORS.cpp
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.cpp
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.h
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/third_party/WebKit/Source/platform/loader/fetch/ResourceRequestTest.cpp
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/third_party/WebKit/public/platform/WebCORS.h
[modify] https://crrev.com/dc68cb1454636776f3a8858af6569efbffdd3f93/third_party/WebKit/public/platform/WebURLRequest.h

Blockedon: 811669
Cc: falken@chromium.org
Issue 827074 has been merged into this issue.
Project Member

Comment 75 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acb002b6f0452b0d5378e019d55c4921b19198d6

commit acb002b6f0452b0d5378e019d55c4921b19198d6
Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Date: Thu Mar 29 13:23:05 2018

Mark fetch-event.https.html as failing in addition to crashing

An upcoming change in WPT is triggering a DCHECK in the test that is
preventing WPT imports.

Since the Blink trybots run without DCHECKs, when rebaselining the new tests
the WPT importer is removing the existing entry for
virtual/outofblink-cors/external/wpt/service-workers/service-worker/fetch-event.https.html
from TestExpectations.

Mark it as failing in addition to crashing to prevent the TestExpectations
entry from being removed.

TBR=markdittmer@chromium.org

Bug: 736308
Change-Id: I15d8c7af8e85be41a8ac820c01019183394bc95f
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/985985
Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#546803}
[modify] https://crrev.com/acb002b6f0452b0d5378e019d55c4921b19198d6/third_party/WebKit/LayoutTests/TestExpectations

Cc: domfarolino@gmail.com
Project Member

Comment 77 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40cbcec3444bdaa95ddda05ebc61a83e1f31898c

commit 40cbcec3444bdaa95ddda05ebc61a83e1f31898c
Author: Marc Treib <treib@chromium.org>
Date: Thu May 03 12:13:52 2018

Mark redirect-cross-origin-post.html as Crash in addition to Timeout

It occasionally crashes instead of timing out on Linux, Windows, and
Mac (all debug).

Flakiness link for convenience:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual/outofblink-cors/http/tests/xmlhttprequest/redirect-cross-origin-post.html

TBR=toyoshim@chromium.org

Bug: 736308
Change-Id: If30ac47f075df6766b4e14221db4c9d75f195048
Reviewed-on: https://chromium-review.googlesource.com/1041953
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555699}
[modify] https://crrev.com/40cbcec3444bdaa95ddda05ebc61a83e1f31898c/third_party/WebKit/LayoutTests/TestExpectations

I enabled 'Out of blink CORS' flag and it caused lot of problems, youtube video was not running, and when I inspect it. It said 

Failed to load 
'https://r5---sn-qxa7sn7r.googlevideo.com/videoplayback?......rn=6&rbuf=0'

No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'https://www.youtube.com' is therefore not allowed access.
Untitled.png
171 KB View Download
See the status. It isn't closed yet, but just marked as Started, that means it's WIP.

Comment 80 by dxie@chromium.org, May 22 2018

this does not block canary.

Comment 81 by dxie@chromium.org, May 22 2018

Labels: Hotlist-KnownIssue
Cc: worker-dev@chromium.org
Issue 850564 has been merged into this issue.
Cc: -worker-dev@chromium.org
Project Member

Comment 84 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da209031fd39ff6c2b207350b666d48d9fef21f9

commit da209031fd39ff6c2b207350b666d48d9fef21f9
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Jun 13 07:45:31 2018

[OOR-CORS] Implement redirect logic in CORSURLLoader

This CL adds redirect logic to CORSURLLoader. There are some TODOs and
I'll address them later.

Bug: 736308
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I8db4eccb6c5bb453882f6a469d4185487848773a
Reviewed-on: https://chromium-review.googlesource.com/1088715
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566751}
[modify] https://crrev.com/da209031fd39ff6c2b207350b666d48d9fef21f9/services/network/cors/cors_url_loader.cc
[modify] https://crrev.com/da209031fd39ff6c2b207350b666d48d9fef21f9/services/network/cors/cors_url_loader.h
[modify] https://crrev.com/da209031fd39ff6c2b207350b666d48d9fef21f9/services/network/cors/cors_url_loader_unittest.cc
[modify] https://crrev.com/da209031fd39ff6c2b207350b666d48d9fef21f9/services/network/cors/preflight_controller.cc
[modify] https://crrev.com/da209031fd39ff6c2b207350b666d48d9fef21f9/services/network/cors/preflight_controller.h
[modify] https://crrev.com/da209031fd39ff6c2b207350b666d48d9fef21f9/services/network/cors/preflight_controller_unittest.cc
[modify] https://crrev.com/da209031fd39ff6c2b207350b666d48d9fef21f9/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/a275018ea52d2039212735aaeb45aaf77c1b654f/third_party/WebKit/LayoutTests/virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-cookies-redirect.any-expected.txt
[delete] https://crrev.com/a275018ea52d2039212735aaeb45aaf77c1b654f/third_party/WebKit/LayoutTests/virtual/outofblink-cors/external/wpt/fetch/api/cors/cors-cookies-redirect.any.worker-expected.txt
[add] https://crrev.com/da209031fd39ff6c2b207350b666d48d9fef21f9/third_party/WebKit/LayoutTests/virtual/outofblink-cors/http/tests/xmlhttprequest/open-in-body-onload-sync-to-invalid-redirect-response-handling-expected.txt
[add] https://crrev.com/da209031fd39ff6c2b207350b666d48d9fef21f9/third_party/WebKit/LayoutTests/virtual/outofblink-cors/http/tests/xmlhttprequest/redirect-cross-origin-sync-double-expected.txt
[modify] https://crrev.com/da209031fd39ff6c2b207350b666d48d9fef21f9/third_party/blink/renderer/core/loader/document_threadable_loader.cc

Project Member

Comment 86 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53587424bc5c5c20bb3c09d75e305cb49930b8f7

commit 53587424bc5c5c20bb3c09d75e305cb49930b8f7
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Jun 13 10:11:42 2018

[OOR-CORS] Do not send cookies and authentication data via preflight

load_flags is set from fetch_credentials_mode in renderer/loader but
for preflight requests we need to set it manually.

Bug: 736308
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I7ff8b945c091bf1195dd83318d74945c5020aece
Reviewed-on: https://chromium-review.googlesource.com/1095124
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566785}
[modify] https://crrev.com/53587424bc5c5c20bb3c09d75e305cb49930b8f7/services/network/cors/preflight_controller.cc
[modify] https://crrev.com/53587424bc5c5c20bb3c09d75e305cb49930b8f7/services/network/cors/preflight_controller_unittest.cc
[modify] https://crrev.com/53587424bc5c5c20bb3c09d75e305cb49930b8f7/third_party/WebKit/LayoutTests/TestExpectations

Blocking: 786673
Blockedon: 854630
Blockedon: 859988
Project Member

Comment 90 by bugdroid1@chromium.org, Jul 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddba739033b5d813630ac836ba06512fbff9f218

commit ddba739033b5d813630ac836ba06512fbff9f218
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Jul 05 05:41:28 2018

Remove stale virtual/outofblink-cors expectations

Bug: 736308
Change-Id: If613a88bd211fc3b6d8a68b02d3c7160c6d727ce
Reviewed-on: https://chromium-review.googlesource.com/1126684
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572713}
[modify] https://crrev.com/ddba739033b5d813630ac836ba06512fbff9f218/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 91 by bugdroid1@chromium.org, Jul 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4034be40e56f475e8f0d7bf2167e7f8ec77d2423

commit 4034be40e56f475e8f0d7bf2167e7f8ec77d2423
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Jul 05 06:57:20 2018

Enable ServiceWorker Servification for outofblink-cors virtual tests

ServiceWorker servicification is getting stable, and the loading stack
will be simpler with the feature. Let's enable the feature for
outofblink-cors virtual tests.

Bug: 736308
Change-Id: I8c7dd75154e0ee730642d8259eb756240b8381d5
Reviewed-on: https://chromium-review.googlesource.com/1126685
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572721}
[modify] https://crrev.com/4034be40e56f475e8f0d7bf2167e7f8ec77d2423/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/4034be40e56f475e8f0d7bf2167e7f8ec77d2423/third_party/WebKit/LayoutTests/VirtualTestSuites

Project Member

Comment 92 by bugdroid1@chromium.org, Jul 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/394d3c99da2d586070df6902c4149563bc41365f

commit 394d3c99da2d586070df6902c4149563bc41365f
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Jul 05 07:02:08 2018

[OOR-CORS] Fix a DCHECK error for service worker fallback request

Bug: 736308
Change-Id: Ifc3f79d6f385683d8f5be2da1da687a1d3542831
Reviewed-on: https://chromium-review.googlesource.com/1126690
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572722}
[modify] https://crrev.com/394d3c99da2d586070df6902c4149563bc41365f/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/394d3c99da2d586070df6902c4149563bc41365f/third_party/blink/renderer/core/loader/document_threadable_loader.cc

Project Member

Comment 93 by bugdroid1@chromium.org, Jul 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ea90201afc40a66951cc804a70ca89e73466c64

commit 5ea90201afc40a66951cc804a70ca89e73466c64
Author: Pavol Marko <pmarko@chromium.org>
Date: Thu Jul 05 11:58:38 2018

Mark virtual/outofblink-cors service-worker-csp-connect test as failing

The test is crashing on dbg linux/mac builders, failing on non-dbg linux/mac
builders, and succeeding on a win builder.

TBR=yhirano@chromium.org

Bug: 736308
Change-Id: I5695b9280f1846397bf2f500b01e531de0970a52
Reviewed-on: https://chromium-review.googlesource.com/1127021
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572760}
[modify] https://crrev.com/5ea90201afc40a66951cc804a70ca89e73466c64/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 94 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54722f0c12ff5acbc6172faf6cac0809bca4f268

commit 54722f0c12ff5acbc6172faf6cac0809bca4f268
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Jul 10 10:15:00 2018

[OOR-CORS] Fix console messages for CORS violations

With this CL, the CORS modules located in the network service sends
error details such as an invalid header value back to the renderer
so that we can print the information to console.

network::CheckAccess and friends now return
Optional<network::CORSErrorStatus>, not
Optional<netork::mojom::CORSError>. blink::ErrorParameter gets the
header information from network::CORSErrorStatus instead of
HTTPHeaderMap, so this CL removes HTTPHeaderMap reference from the
struct.

Bug: 736308
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I2951c97fcfde09456ccbe842e996d33ca1bfb496
Reviewed-on: https://chromium-review.googlesource.com/1126751
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573674}
[modify] https://crrev.com/54722f0c12ff5acbc6172faf6cac0809bca4f268/content/renderer/loader/sync_load_context.cc
[modify] https://crrev.com/54722f0c12ff5acbc6172faf6cac0809bca4f268/content/renderer/loader/sync_load_response.h
[modify] https://crrev.com/54722f0c12ff5acbc6172faf6cac0809bca4f268/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/54722f0c12ff5acbc6172faf6cac0809bca4f268/services/network/cors/cors_url_loader.cc
[modify] https://crrev.com/54722f0c12ff5acbc6172faf6cac0809bca4f268/services/network/cors/preflight_controller.cc
[modify] https://crrev.com/54722f0c12ff5acbc6172faf6cac0809bca4f268/services/network/public/cpp/cors/cors.cc
[modify] https://crrev.com/54722f0c12ff5acbc6172faf6cac0809bca4f268/services/network/public/cpp/cors/cors.h
[modify] https://crrev.com/54722f0c12ff5acbc6172faf6cac0809bca4f268/services/network/public/cpp/cors/cors_unittest.cc
[modify] https://crrev.com/54722f0c12ff5acbc6172faf6cac0809bca4f268/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/54722f0c12ff5acbc6172faf6cac0809bca4f268/third_party/blink/public/platform/web_cors.h
[modify] https://crrev.com/54722f0c12ff5acbc6172faf6cac0809bca4f268/third_party/blink/renderer/core/DEPS
[modify] https://crrev.com/54722f0c12ff5acbc6172faf6cac0809bca4f268/third_party/blink/renderer/core/loader/document_threadable_loader.cc
[modify] https://crrev.com/54722f0c12ff5acbc6172faf6cac0809bca4f268/third_party/blink/renderer/platform/exported/web_cors.cc
[modify] https://crrev.com/54722f0c12ff5acbc6172faf6cac0809bca4f268/third_party/blink/renderer/platform/loader/cors/cors.cc
[modify] https://crrev.com/54722f0c12ff5acbc6172faf6cac0809bca4f268/third_party/blink/renderer/platform/loader/cors/cors.h
[modify] https://crrev.com/54722f0c12ff5acbc6172faf6cac0809bca4f268/third_party/blink/renderer/platform/loader/cors/cors_error_string.cc
[modify] https://crrev.com/54722f0c12ff5acbc6172faf6cac0809bca4f268/third_party/blink/renderer/platform/loader/cors/cors_error_string.h
[modify] https://crrev.com/54722f0c12ff5acbc6172faf6cac0809bca4f268/third_party/blink/renderer/platform/loader/fetch/resource.cc
[modify] https://crrev.com/54722f0c12ff5acbc6172faf6cac0809bca4f268/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc

Project Member

Comment 95 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/689e778b9014fe05e70fd811102bcead5aa22de7

commit 689e778b9014fe05e70fd811102bcead5aa22de7
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Jul 10 16:14:44 2018

[OOR-CORS] Omit credentials on cross-origin redirects

When request's credentials mode is "same-origin" and the request goes to
cross-origin, we should stop sending credentials data. This is
implemented in renderers (when making a request) and in net/
(on redirect), but CORSURLLoader sometimes creates a new network loader
on redirect, and in such a case the net/ logic doesn't work. This CL
adds the logic in CORSURLLoader.

Bug: 736308
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I79b287159233f8924fb2b459e0dee62ef31a0fe9
Reviewed-on: https://chromium-review.googlesource.com/1126805
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573760}
[modify] https://crrev.com/689e778b9014fe05e70fd811102bcead5aa22de7/services/network/cors/cors_url_loader.cc
[modify] https://crrev.com/689e778b9014fe05e70fd811102bcead5aa22de7/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 96 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c7a0e70709bab71c5e0717d36f8fe27e3be3569

commit 8c7a0e70709bab71c5e0717d36f8fe27e3be3569
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Jul 11 03:45:31 2018

[OOR-CORS] Suppress preflight when needed

With this CL, CORSURLLoader doesn't make a preflight request when
 - The request mode is no-cors, or
 - cors_preflight_policy is kPreventPreflight
.

Bug: 736308, 803766
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: If0476052f5ad15cc978187dffc984783719c3d2f
Reviewed-on: https://chromium-review.googlesource.com/1126840
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574061}
[modify] https://crrev.com/8c7a0e70709bab71c5e0717d36f8fe27e3be3569/services/network/cors/cors_url_loader.cc
[modify] https://crrev.com/8c7a0e70709bab71c5e0717d36f8fe27e3be3569/services/network/public/cpp/network_ipc_param_traits.h
[modify] https://crrev.com/8c7a0e70709bab71c5e0717d36f8fe27e3be3569/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 97 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec3424c1810196a75492d1e2ba84aa4193d66f81

commit ec3424c1810196a75492d1e2ba84aa4193d66f81
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Jul 11 06:13:11 2018

[OOR-CORS] Handle preflight request failure

Currently PreflightLoader doesn't do anything when the preflight request
fails by network errors. This CL fixes that.

Bug: 736308, 803766
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ica8f911e060b185980a653d7ddecb08f5c86c8ac
Reviewed-on: https://chromium-review.googlesource.com/1126894
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574085}
[modify] https://crrev.com/ec3424c1810196a75492d1e2ba84aa4193d66f81/services/network/cors/cors_url_loader.cc
[modify] https://crrev.com/ec3424c1810196a75492d1e2ba84aa4193d66f81/services/network/cors/cors_url_loader.h
[modify] https://crrev.com/ec3424c1810196a75492d1e2ba84aa4193d66f81/services/network/cors/preflight_controller.cc
[modify] https://crrev.com/ec3424c1810196a75492d1e2ba84aa4193d66f81/services/network/cors/preflight_controller.h
[modify] https://crrev.com/ec3424c1810196a75492d1e2ba84aa4193d66f81/services/network/cors/preflight_controller_unittest.cc
[modify] https://crrev.com/ec3424c1810196a75492d1e2ba84aa4193d66f81/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 98 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfd0a11a0cea1ea0cc3a2e8b901d6e013e4884ec

commit cfd0a11a0cea1ea0cc3a2e8b901d6e013e4884ec
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Jul 11 07:09:07 2018

[OOR-CORS] Update TestExpecatations

Some entries are missing, some are fixed, some are not specific to
virtual/outofblink-cors. This CL removes fixed/missing ones and
reorders entries which are not specific to virtual/outofblink-cors.

Bug: 736308
Change-Id: Ic39ce52e5ccd730ccf476bc9be7804d04bcc3f19
Reviewed-on: https://chromium-review.googlesource.com/1130558
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574099}
[modify] https://crrev.com/cfd0a11a0cea1ea0cc3a2e8b901d6e013e4884ec/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 99 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0885f06dc51a3aaa472651911b364b4710ceb43b

commit 0885f06dc51a3aaa472651911b364b4710ceb43b
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Jul 17 08:16:26 2018

[OOR-CORS] Fix CORS flag configuration

With this CL, CORSURLLoader::fetch_cors_flag_ which represents the CORS
flag in the spec will not be set if the request's mode is "no-cors".
This CL also fixes how the origin header is attached.

Bug: 736308
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I9cc510377ad97ec0ac99039e98b888e1eb91f2f6
Reviewed-on: https://chromium-review.googlesource.com/1139938
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575579}
[modify] https://crrev.com/0885f06dc51a3aaa472651911b364b4710ceb43b/services/network/cors/cors_url_loader.cc
[modify] https://crrev.com/0885f06dc51a3aaa472651911b364b4710ceb43b/services/network/cors/cors_url_loader_unittest.cc

Project Member

Comment 100 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7

commit c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Jul 19 05:22:08 2018

Hook up CORSURLLoader to Network Service

This CL consists of several parts:

 - Move mojo::Binding from network::URLLoaderFactory to
   network::CORSURLLoaderFactory:
   Now CORSURLLoaderFactory is the implementation of
   network::URLLoaderFactory returned from
   NetworkContext::CreateURLLoaderFactory, so this CL moves the binding
   logic to CORSURLLoader.
 - Loosen the redirect mode check in CORSURLLoader:
   Some requests with kNavigate mode and kManual redirect mode
   calls FollowRedirect. It seems a reasonable usage, so CORSURLLoader
   now allows that.
 - Add virtual/outofblink-cors-ns:
   From some infrastructure issues we cannot test out-of-blink CORS
   with Network Service, with virtual/outofblink-cors on linux-mojo. This
   CL explicitly adds one more virtual test suite instead.

Bug: 736308, 862184
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: If5db2725b2c5af83a2f1c1481c612bcb4ea75567
Reviewed-on: https://chromium-review.googlesource.com/1134926
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576381}
[modify] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/content/browser/loader/navigation_url_loader_impl_unittest.cc
[modify] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/content/browser/loader/resource_message_filter.cc
[modify] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/services/network/cors/cors_url_loader.cc
[modify] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/services/network/cors/cors_url_loader.h
[modify] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/services/network/cors/cors_url_loader_factory.cc
[modify] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/services/network/cors/cors_url_loader_factory.h
[modify] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/services/network/cors/cors_url_loader_unittest.cc
[modify] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/services/network/network_context.cc
[modify] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/services/network/network_context.h
[modify] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/services/network/url_loader.h
[modify] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/services/network/url_loader_factory.cc
[modify] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/services/network/url_loader_factory.h
[modify] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/services/network/url_loader_unittest.cc
[modify] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/external/wpt/fetch/README.txt
[add] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/external/wpt/http/README.txt
[add] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/external/wpt/referrer-policy/README.txt
[add] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/external/wpt/service-workers/README.txt
[add] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/external/wpt/service-workers/service-worker/clients-matchall-client-types.https-expected.txt
[add] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/http/tests/fetch/README.txt
[add] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/http/tests/xmlhttprequest/README.txt
[add] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/http/tests/xmlhttprequest/open-in-body-onload-sync-to-invalid-redirect-response-handling-expected.txt
[add] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/http/tests/xmlhttprequest/origin-header-cross-origin-get-sync-expected.txt
[add] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/http/tests/xmlhttprequest/origin-header-cross-origin-post-sync-expected.txt
[add] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/http/tests/xmlhttprequest/origin-header-same-origin-post-sync-expected.txt
[add] https://crrev.com/c9dcd5e903db6fd1a4943b9e5e2eb3afdaca6ad7/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/http/tests/xmlhttprequest/redirect-cross-origin-sync-double-expected.txt

Project Member

Comment 101 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cde0f2f178a172fc31912545fc398df061ffffd3

commit cde0f2f178a172fc31912545fc398df061ffffd3
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Jul 19 06:16:15 2018

[OOR-CORS] Support --disable-web-security

This CL adds --disable-web-security support to CORSURLLoader. This CL
also removes layout tests because with out-of-blink CORS it's not
testable. Instead, this CL adds some browser tests to verify the
behavior.

Bug: 736308
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I609f08e2613f0d4a3c9dc5cc87c236ba15189968
Reviewed-on: https://chromium-review.googlesource.com/1131045
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576392}
[modify] https://crrev.com/cde0f2f178a172fc31912545fc398df061ffffd3/content/browser/frame_host/origin_policy_throttle.cc
[modify] https://crrev.com/cde0f2f178a172fc31912545fc398df061ffffd3/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/cde0f2f178a172fc31912545fc398df061ffffd3/content/browser/loader/cors_file_origin_browsertest.cc
[modify] https://crrev.com/cde0f2f178a172fc31912545fc398df061ffffd3/content/browser/loader/resource_message_filter.cc
[modify] https://crrev.com/cde0f2f178a172fc31912545fc398df061ffffd3/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/cde0f2f178a172fc31912545fc398df061ffffd3/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/cde0f2f178a172fc31912545fc398df061ffffd3/content/browser/url_loader_factory_getter.cc
[modify] https://crrev.com/cde0f2f178a172fc31912545fc398df061ffffd3/services/network/cors/cors_url_loader_factory.cc
[modify] https://crrev.com/cde0f2f178a172fc31912545fc398df061ffffd3/services/network/cors/cors_url_loader_factory.h
[modify] https://crrev.com/cde0f2f178a172fc31912545fc398df061ffffd3/services/network/cors/cors_url_loader_unittest.cc
[modify] https://crrev.com/cde0f2f178a172fc31912545fc398df061ffffd3/services/network/public/mojom/network_context.mojom
[modify] https://crrev.com/cde0f2f178a172fc31912545fc398df061ffffd3/third_party/WebKit/LayoutTests/LeakExpectations
[modify] https://crrev.com/cde0f2f178a172fc31912545fc398df061ffffd3/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/a1edde57de5f03a46f7dfacb1c2b86ae88e12132/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/resources/frame-with-insecure-xhr.html
[delete] https://crrev.com/a1edde57de5f03a46f7dfacb1c2b86ae88e12132/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/resources/frame-with-insecure-xhr.html
[delete] https://crrev.com/a1edde57de5f03a46f7dfacb1c2b86ae88e12132/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/xmlhttprequest-allowed-with-disabled-web-security-expected.txt
[delete] https://crrev.com/a1edde57de5f03a46f7dfacb1c2b86ae88e12132/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/xmlhttprequest-allowed-with-disabled-web-security.html
[delete] https://crrev.com/a1edde57de5f03a46f7dfacb1c2b86ae88e12132/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-allowed-with-disabled-web-security-expected.txt
[delete] https://crrev.com/a1edde57de5f03a46f7dfacb1c2b86ae88e12132/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-allowed-with-disabled-web-security.html

Project Member

Comment 102 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27f088978ef6cb2b39dc72bd3ef3e558b4502045

commit 27f088978ef6cb2b39dc72bd3ef3e558b4502045
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Jul 19 10:01:41 2018

Reject insane requests in CORSURLLoaderFactory

With this CL, CORSURLLoaderFactory rejects ill-configuared requests.

 - CORS needs a proper origin (including an opaque unique origin)
   attached to a request. Hence CORSURLLoaderFactory rejects a request
   which has a CORS-enabled mode and null request_initiator. Also,
   a request with null request_initiator won't set the CORS flag with
   this CL.
 - The relationship between fetch credentials mode and load_flags is
   a bit unclear. If a request's credentials mode is "omit" but
   one of LOAD_DO_NOT_SAVE_COOKIES, LOAD_DO_NOT_SEND_COOKIES and
   LOAD_DO_NOT_SEND_AUTH_DATA is not set on load_flags, that is likely
   a mis-configuration, so fail the request.

Bug: 736308, 862184
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I51fb491b865de330b22b028a0eddbc30043e6b69
Reviewed-on: https://chromium-review.googlesource.com/1136342
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576430}
[modify] https://crrev.com/27f088978ef6cb2b39dc72bd3ef3e558b4502045/services/network/cors/cors_url_loader.cc
[modify] https://crrev.com/27f088978ef6cb2b39dc72bd3ef3e558b4502045/services/network/cors/cors_url_loader_factory.cc
[modify] https://crrev.com/27f088978ef6cb2b39dc72bd3ef3e558b4502045/services/network/cors/cors_url_loader_factory.h
[modify] https://crrev.com/27f088978ef6cb2b39dc72bd3ef3e558b4502045/services/network/cors/cors_url_loader_unittest.cc
[modify] https://crrev.com/27f088978ef6cb2b39dc72bd3ef3e558b4502045/services/network/public/cpp/resource_request.h

Project Member

Comment 103 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4aa3b2f002844f00fc7b339cdc7bcbd2ae01ffe

commit a4aa3b2f002844f00fc7b339cdc7bcbd2ae01ffe
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Jul 20 06:05:24 2018

[OOR-CORS] Update TestExpecatations

external/wpt/service-workers/service-worker/service-worker-csp-connect.https.html
has been passing for a while. Remove the stale expectations.

Bug: 736308
Change-Id: I5feaaf93b73733c25054cb8e92678f0e635bdce9
Reviewed-on: https://chromium-review.googlesource.com/1144595
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576795}
[modify] https://crrev.com/a4aa3b2f002844f00fc7b339cdc7bcbd2ae01ffe/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 104 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e87203b986d8ee7a7a4c46a25d2fe464c1cd31a6

commit e87203b986d8ee7a7a4c46a25d2fe464c1cd31a6
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Jul 20 06:18:28 2018

[OOR-CORS] Mark outofblink-cors/.../navigation-timing.https.html as PASS

external/wpt/service-workers/service-worker/navigation-timing.https.html
has an expectation file consisting of two FAILs and one PASS, but in
virtual/outofblink-cors[-ns] the test result changes to two PASSes and
one FAIL. Since PASS is better than FAIL let's accept that result.

Bug: 736308
Change-Id: I4bc33bf2c7c68b16528371cc1b0987dd6048e324
Reviewed-on: https://chromium-review.googlesource.com/1144597
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576797}
[modify] https://crrev.com/e87203b986d8ee7a7a4c46a25d2fe464c1cd31a6/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/e87203b986d8ee7a7a4c46a25d2fe464c1cd31a6/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/external/wpt/service-workers/service-worker/navigation-timing.https-expected.txt
[add] https://crrev.com/e87203b986d8ee7a7a4c46a25d2fe464c1cd31a6/third_party/WebKit/LayoutTests/virtual/outofblink-cors/external/wpt/service-workers/service-worker/navigation-timing.https-expected.txt

Project Member

Comment 105 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92409c5c0178f60934c263794016c66c4072a335

commit 92409c5c0178f60934c263794016c66c4072a335
Author: Clark DuVall <cduvall@chromium.org>
Date: Fri Jul 20 17:59:33 2018

Revert "[OOR-CORS] Mark outofblink-cors/.../navigation-timing.https.html as PASS"

This reverts commit e87203b986d8ee7a7a4c46a25d2fe464c1cd31a6.

Reason for revert: This caused the Mojo builders to start failing: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Linux/16264

Test still fails with --enable-features=NetworkService

Original change's description:
> [OOR-CORS] Mark outofblink-cors/.../navigation-timing.https.html as PASS
> 
> external/wpt/service-workers/service-worker/navigation-timing.https.html
> has an expectation file consisting of two FAILs and one PASS, but in
> virtual/outofblink-cors[-ns] the test result changes to two PASSes and
> one FAIL. Since PASS is better than FAIL let's accept that result.
> 
> Bug: 736308
> Change-Id: I4bc33bf2c7c68b16528371cc1b0987dd6048e324
> Reviewed-on: https://chromium-review.googlesource.com/1144597
> Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576797}

TBR=falken@chromium.org,yhirano@chromium.org

Change-Id: I7424a1f9267ae4e7fcd0589752c6fae9e488df89
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 736308
Reviewed-on: https://chromium-review.googlesource.com/1145443
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576921}
[modify] https://crrev.com/92409c5c0178f60934c263794016c66c4072a335/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/277b7985fae75c9f21f8ab9111fb65d250328f70/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/external/wpt/service-workers/service-worker/navigation-timing.https-expected.txt
[delete] https://crrev.com/277b7985fae75c9f21f8ab9111fb65d250328f70/third_party/WebKit/LayoutTests/virtual/outofblink-cors/external/wpt/service-workers/service-worker/navigation-timing.https-expected.txt

Project Member

Comment 106 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f6c7797453ecfcb6cace1dc7dbb3ef57117a562

commit 8f6c7797453ecfcb6cace1dc7dbb3ef57117a562
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Mon Jul 23 03:36:23 2018

[OOR-CORS] Support header modification on FollowRedirect

Bug: 736308
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I86bccc93b2e2050326d59c26a03d05a51ed1ae81
Reviewed-on: https://chromium-review.googlesource.com/1144807
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577107}
[modify] https://crrev.com/8f6c7797453ecfcb6cace1dc7dbb3ef57117a562/services/network/cors/cors_url_loader.cc

Project Member

Comment 107 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7be01159c27747c0498a181301393afb237c8919

commit 7be01159c27747c0498a181301393afb237c8919
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Mon Jul 23 07:49:58 2018

[OOR-CORS] Fix messages for CORS-disabled schemes

With this CL, CORSURLLoader only allows "http", "https" and "data"
schemes for CORS enabled requests. This CL adds a new error code,
kCORSDisabledScheme, for the error. As noted in the design doc[1],
no one updates the scheme list in Chromium, so it's safe to
assume url::GetCORSEnabledSchemes is equivalent to the
counterpart in blink::SchemeRegistry. We are planning to remove
blink::SchemeRegistry::RegisterURLSchemeAsSecure.

The existing xmlhttprequest/resources/cross-origin-unsupported-url.js
output relies heavily on the error output timing. This CL fixes the
test.

Because the error is reported asynchronously, console messages change
a bit (i.e., the line number doesn't show up). We accept that change.

1: https://docs.google.com/document/d/1JNmUcvbw2UcjfdI2uyUpveHXCbae-DQ1n8d_sVs5fLg/edit#heading=h.r9hjqrw3gn9e

Bug: 736308
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Id49ad02e1413353e96c9fed1d0a84d34f0262fab
Reviewed-on: https://chromium-review.googlesource.com/1144903
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577120}
[modify] https://crrev.com/7be01159c27747c0498a181301393afb237c8919/services/network/cors/cors_url_loader.cc
[modify] https://crrev.com/7be01159c27747c0498a181301393afb237c8919/services/network/public/mojom/cors.mojom
[modify] https://crrev.com/7be01159c27747c0498a181301393afb237c8919/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/7be01159c27747c0498a181301393afb237c8919/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/cross-origin-unsupported-url-expected.txt
[modify] https://crrev.com/7be01159c27747c0498a181301393afb237c8919/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/cross-origin-unsupported-url.html
[modify] https://crrev.com/7be01159c27747c0498a181301393afb237c8919/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-unsupported-url.js
[modify] https://crrev.com/7be01159c27747c0498a181301393afb237c8919/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/cross-origin-unsupported-url-expected.txt
[modify] https://crrev.com/7be01159c27747c0498a181301393afb237c8919/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/cross-origin-unsupported-url.html
[add] https://crrev.com/7be01159c27747c0498a181301393afb237c8919/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/http/tests/xmlhttprequest/cross-origin-unsupported-url-expected.txt
[add] https://crrev.com/7be01159c27747c0498a181301393afb237c8919/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/http/tests/xmlhttprequest/workers/cross-origin-unsupported-url-expected.txt
[add] https://crrev.com/7be01159c27747c0498a181301393afb237c8919/third_party/WebKit/LayoutTests/virtual/outofblink-cors/http/tests/xmlhttprequest/cross-origin-unsupported-url-expected.txt
[add] https://crrev.com/7be01159c27747c0498a181301393afb237c8919/third_party/WebKit/LayoutTests/virtual/outofblink-cors/http/tests/xmlhttprequest/workers/cross-origin-unsupported-url-expected.txt
[modify] https://crrev.com/7be01159c27747c0498a181301393afb237c8919/third_party/blink/renderer/platform/loader/cors/cors_error_string.cc
[modify] https://crrev.com/7be01159c27747c0498a181301393afb237c8919/third_party/blink/renderer/platform/loader/fetch/resource_error.cc
[modify] https://crrev.com/7be01159c27747c0498a181301393afb237c8919/third_party/blink/renderer/platform/loader/fetch/resource_error.h

Project Member

Comment 108 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f

commit 7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Jul 24 04:42:51 2018

Remove FetchParameters::OriginRestriction

OriginRestriction has three values:
 - kUseDefaultOriginRestrictionForType
 - kRestrictToSameOrigin
 - kNoOriginRestriction

kRestrictToSameOrigin is equivalent to "same-origin" request mode.
kUseDefaultOriginRestrictionForType works as kRestrictToSameOrigin for
certain resource types. kNoOriginRestriction works completely
differently, it bypasses a CanDisplay check in
BaseFetchContext::CanRequest.

This CL replaces kRestrictToSameOrigin with "same-origin" request mode,
kUseDefaultOriginRestrictionForType with "same-origin" request mode for
the corresponding resource types. This CL also replaces
kNoOriginRestriction with SecurityOrigin::GrantUniversalAccess because
the CL which introduced the value[1] seems to want to bypass checks for
requests with has_universal_access_ in PepperURLLoaderHost.

1: https://codereview.chromium.org/344883006

Bug: 736308
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0fb39b9f59aa6fd3c25244516e735b72a7183593
Reviewed-on: https://chromium-review.googlesource.com/1143669
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577428}
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/content/renderer/pepper/pepper_url_loader_host.cc
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/WebKit/LayoutTests/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/WebKit/LayoutTests/http/tests/workers/worker-redirect-expected.txt
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/public/web/web_associated_url_loader_options.h
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/core/dom/processing_instruction.cc
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/core/exported/web_associated_url_loader_impl.cc
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/core/exported/web_associated_url_loader_impl_test.cc
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/core/loader/base_fetch_context.cc
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/core/loader/base_fetch_context.h
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/core/loader/base_fetch_context_test.cc
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/core/loader/document_threadable_loader.cc
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/core/loader/frame_fetch_context.cc
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/core/loader/frame_fetch_context.h
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/core/loader/frame_fetch_context_test.cc
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/core/loader/resource/document_resource.cc
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/core/svg/svg_resource.cc
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/core/svg/svg_use_element.cc
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/core/xml/xsl_style_sheet_libxslt.cc
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/core/xml/xslt_processor_libxslt.cc
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/platform/loader/fetch/fetch_context.h
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/platform/loader/fetch/fetch_parameters.cc
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/platform/loader/fetch/fetch_parameters.h
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[modify] https://crrev.com/7e8ddbb76b3aed2cfcc885f048fb9bc99a2f7d5f/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h

Blockedon: 866787
Project Member

Comment 110 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0994aa897e24d8b3f3b6aef9c4ae20e5be8777c

commit d0994aa897e24d8b3f3b6aef9c4ae20e5be8777c
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Jul 24 07:06:26 2018

[OOR-CORS] Have PreflightResult functions return CORSErrorStatus

...instead of mojom::CORSError. Currently they return a mojom::CORSError
and callers need to compose a CORSErrorStatus from it. That requires
callers to know which specific errors are returned from the function,
which is not good.

Bug: 736308
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I5b0dfaf5b906e0203c9a72ebaef759a8fafa4ad3
Reviewed-on: https://chromium-review.googlesource.com/1147681
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577443}
[modify] https://crrev.com/d0994aa897e24d8b3f3b6aef9c4ae20e5be8777c/services/network/cors/preflight_controller.cc
[modify] https://crrev.com/d0994aa897e24d8b3f3b6aef9c4ae20e5be8777c/services/network/public/cpp/cors/preflight_result.cc
[modify] https://crrev.com/d0994aa897e24d8b3f3b6aef9c4ae20e5be8777c/services/network/public/cpp/cors/preflight_result.h
[modify] https://crrev.com/d0994aa897e24d8b3f3b6aef9c4ae20e5be8777c/services/network/public/cpp/cors/preflight_result_unittest.cc
[modify] https://crrev.com/d0994aa897e24d8b3f3b6aef9c4ae20e5be8777c/third_party/blink/renderer/platform/loader/cors/cors.cc

Project Member

Comment 111 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b53bca17f41038da87367186e37bcad0165719c8

commit b53bca17f41038da87367186e37bcad0165719c8
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Jul 25 12:53:58 2018

Fix empty value handling of HttpResponseHeaders::GetNormalizedHeader

Per RFC7230 empty header field is valid, but
HttpResponseHeaders::GetNormalizedHeader sometimes ignores empty values.
This CL fixes the issue.

Bug: 866787, 736308
Change-Id: I227e18e413740e345d557e2c24a25e45e68b0ae8
Reviewed-on: https://chromium-review.googlesource.com/1148091
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577852}
[modify] https://crrev.com/b53bca17f41038da87367186e37bcad0165719c8/net/http/http_response_headers.cc
[modify] https://crrev.com/b53bca17f41038da87367186e37bcad0165719c8/net/http/http_response_headers_unittest.cc

Project Member

Comment 112 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc0443b140d8511046a73f3b3f093c5f315ef02f

commit fc0443b140d8511046a73f3b3f093c5f315ef02f
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Jul 26 06:41:35 2018

Update CORS error messages

In preparation for out-of-blink CORS, this CL largely updates
CORS error messages.

 1. "Failed to load" is removed from DocumentThreadableLoader, and
    "Access to..." is now used instead, in order to align with
    CORS error messages in ResourceLoader.
 2. We now use "Access to <type> at <last request url> (redirected
    from <initial request url>) from origin <origin> has been blocked
    by CORS policy:" for all CORS error messages. "(redirected from
    <initial request url>)" is omitted when <initial request url> and
    <last request url> are same.
 3. As implied at 2, "Redirect from <redirect src> to <redirect dest>
    has been blocked by CORS policy" is removed.
 4. Http status code is not shown any more.
 5. "Origin <origin> is therefore not allowed access." is redundant,
    so it is removed.

Bug: 736308, 851419
Change-Id: I1ceeab4a00a5cf4994acc317b792ffacd39db86d
Reviewed-on: https://chromium-review.googlesource.com/1147890
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578221}
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/devtools/console-xhr-logging-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/eventsource/eventsource-cors-basic-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/eventsource/eventsource-cors-non-http-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/eventsource/eventsource-cors-redirect-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/eventsource/eventsource-cors-with-credentials-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/eventsource/workers/eventsource-cors-basic-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/eventsource/workers/eventsource-cors-non-http-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/eventsource/workers/eventsource-cors-redirect-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/eventsource/workers/eventsource-cors-with-credentials-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/fetch/chromium/error-messages-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/htmlimports/cors-same-origin-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/htmlimports/cross-origin-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/htmlimports/import-script-block-crossorigin-dynamic-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/security/img-crossorigin-redirect-anonymous-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/security/img-crossorigin-redirect-no-cors-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/security/img-with-failed-cors-check-fails-to-load-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/security/isolatedWorld/cross-origin-xhr-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-reinserted-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/security/link-crossorigin-stylesheet-use-credentials-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/security/preload-script-crossorigin-fails-cross-origin-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/security/script-crossorigin-fails-cross-origin-2-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/security/script-crossorigin-fails-cross-origin-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/security/script-crossorigin-loads-correctly-credentials-2-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/security/script-crossorigin-redirect-anonymous-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/security/script-crossorigin-redirect-credentials-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/security/script-crossorigin-redirect-no-cors-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/security/script-onerror-crossorigin-no-cors-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/security/script-with-failed-cors-check-fails-to-load-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/security/subresourceIntegrity/subresource-integrity-script-no-cors-bad-integrity-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/security/text-track-crossorigin-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/security/video-poster-cross-origin-crash-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/security/video-poster-cross-origin-crash2-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/cross-origin-no-credential-prompt-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/cross-origin-unsupported-url-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/cross-site-denied-response-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/cross-site-denied-response-sync-2-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/cross-site-denied-response-sync-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/onerror-event-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/ontimeout-event-override-after-failure-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/open-in-body-onload-sync-to-invalid-cross-origin-response-handling-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/open-in-body-onload-sync-to-invalid-preflight-handling-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/open-in-body-onload-sync-to-invalid-redirect-response-handling-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/07-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/08-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/09-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/10-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/11-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/12-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/13-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/14-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/15-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/16-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/17-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/18-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/19-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/20-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/21-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/22-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/23-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/24-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/25-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/26-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/27-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/28-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/29-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/30-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/31-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/32-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/33-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/34-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/35-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/36-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/37-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/38-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/39-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/40-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/41-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/42-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/43-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/44-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/45-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/46-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-exact-matching/47-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-whitelisting-https-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-whitelisting-ip-addresses-with-subdomains-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/origin-whitelisting-removal-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/post-blob-content-type-async-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/post-blob-content-type-sync-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-2-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-post-sync-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-sync-double-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-sync-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/redirect-cross-origin-tripmine-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/simple-cross-origin-denied-events-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-sync-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/simple-cross-origin-denied-events-sync-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/simple-cross-origin-progress-events-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/upload-request-error-event-order-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/workers/cross-origin-unsupported-url-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-sync-no-progress-events-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt
[delete] https://crrev.com/0365d00eadee5c3b30271e36f95fceecc6634c31/third_party/WebKit/LayoutTests/platform/linux/virtual/outofblink-cors/http/tests/xmlhttprequest/origin-header-cross-origin-get-sync-expected.txt
[delete] https://crrev.com/0365d00eadee5c3b30271e36f95fceecc6634c31/third_party/WebKit/LayoutTests/platform/linux/virtual/outofblink-cors/http/tests/xmlhttprequest/origin-header-same-origin-post-async-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/http/tests/xmlhttprequest/cross-origin-unsupported-url-expected.txt
[delete] https://crrev.com/0365d00eadee5c3b30271e36f95fceecc6634c31/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/http/tests/xmlhttprequest/open-in-body-onload-sync-to-invalid-redirect-response-handling-expected.txt
[delete] https://crrev.com/0365d00eadee5c3b30271e36f95fceecc6634c31/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/http/tests/xmlhttprequest/origin-header-cross-origin-get-sync-expected.txt
[delete] https://crrev.com/0365d00eadee5c3b30271e36f95fceecc6634c31/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/http/tests/xmlhttprequest/origin-header-cross-origin-post-sync-expected.txt
[delete] https://crrev.com/0365d00eadee5c3b30271e36f95fceecc6634c31/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/http/tests/xmlhttprequest/origin-header-same-origin-post-sync-expected.txt
[delete] https://crrev.com/0365d00eadee5c3b30271e36f95fceecc6634c31/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/http/tests/xmlhttprequest/redirect-cross-origin-sync-double-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/http/tests/xmlhttprequest/workers/cross-origin-unsupported-url-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/virtual/outofblink-cors/http/tests/xmlhttprequest/cross-origin-unsupported-url-expected.txt
[delete] https://crrev.com/0365d00eadee5c3b30271e36f95fceecc6634c31/third_party/WebKit/LayoutTests/virtual/outofblink-cors/http/tests/xmlhttprequest/open-in-body-onload-sync-to-invalid-redirect-response-handling-expected.txt
[delete] https://crrev.com/0365d00eadee5c3b30271e36f95fceecc6634c31/third_party/WebKit/LayoutTests/virtual/outofblink-cors/http/tests/xmlhttprequest/origin-header-cross-origin-post-sync-expected.txt
[delete] https://crrev.com/0365d00eadee5c3b30271e36f95fceecc6634c31/third_party/WebKit/LayoutTests/virtual/outofblink-cors/http/tests/xmlhttprequest/origin-header-same-origin-post-sync-expected.txt
[delete] https://crrev.com/0365d00eadee5c3b30271e36f95fceecc6634c31/third_party/WebKit/LayoutTests/virtual/outofblink-cors/http/tests/xmlhttprequest/redirect-cross-origin-sync-double-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/WebKit/LayoutTests/virtual/outofblink-cors/http/tests/xmlhttprequest/workers/cross-origin-unsupported-url-expected.txt
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/blink/renderer/core/loader/threadable_loader.cc
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/blink/renderer/core/loader/threadable_loader.h
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/blink/renderer/core/loader/threadable_loader_test.cc
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/blink/renderer/platform/loader/cors/cors.cc
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/blink/renderer/platform/loader/cors/cors.h
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/blink/renderer/platform/loader/cors/cors_error_string.cc
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/blink/renderer/platform/loader/cors/cors_error_string.h
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/blink/renderer/platform/loader/fetch/resource_error.cc
[modify] https://crrev.com/fc0443b140d8511046a73f3b3f093c5f315ef02f/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc

Blockedon: 867834
Project Member

Comment 115 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3973b69c4637789f0f2a5df3bd5a5f9567aa1869

commit 3973b69c4637789f0f2a5df3bd5a5f9567aa1869
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Aug 02 02:43:05 2018

Have http/tests/xmlhttprequest/open-in-body-* use testharness

With out-of-blink CORS, CORS errors for XHR are displayed in
ResourceLoader, which brings flakiness to open-in-body-* tests, because
Resource and ResourceLoader continue working a while after
ThreadableLoader::Cancel is called, because of the async cancellation
mechanism in ResourceLoader. These tests make ill cross-origin requests,
and then abort them (by calling open() of the same XMLHttpRequest
object) after that. When a response arrives befor the cancellation is
performed but after async cancellation is started, then we see a
console log of a CORS error for an aborted XHR.

Let's have such tests use testharness.js instead of js-test.js so that
such console errors don't affect the test results.

Bug: 736308
Change-Id: I680ce2997a6c10e06368db8a89d789534c47097d
Reviewed-on: https://chromium-review.googlesource.com/1156329
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580035}
[delete] https://crrev.com/f22da7dc9446d5fd7f0cf811548734fee0dea112/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/open-in-body-onload-sync-to-invalid-cross-origin-response-handling-expected.txt
[modify] https://crrev.com/3973b69c4637789f0f2a5df3bd5a5f9567aa1869/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/open-in-body-onload-sync-to-invalid-cross-origin-response-handling.html
[delete] https://crrev.com/f22da7dc9446d5fd7f0cf811548734fee0dea112/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/open-in-body-onload-sync-to-invalid-preflight-handling-expected.txt
[modify] https://crrev.com/3973b69c4637789f0f2a5df3bd5a5f9567aa1869/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/open-in-body-onload-sync-to-invalid-preflight-handling.html
[delete] https://crrev.com/f22da7dc9446d5fd7f0cf811548734fee0dea112/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/open-in-body-onload-sync-to-invalid-redirect-response-handling-expected.txt
[modify] https://crrev.com/3973b69c4637789f0f2a5df3bd5a5f9567aa1869/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/open-in-body-onload-sync-to-invalid-redirect-response-handling.html

Blocking: 870172
Blocking: 870173
Blockedon: 870173
Blocking: -870173
Blockedon: 870172
Blocking: -870172
Project Member

Comment 122 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22fdb5852ada6187d35a697fb9a7731d28160b1a

commit 22fdb5852ada6187d35a697fb9a7731d28160b1a
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Aug 02 04:01:30 2018

Fix redirect handling on ThreadableLoader

 - Decrement |cors_redirect_limit_| even when IsAllowedRedirect(...)
   returns true.
 - Redirect count logic is not applied when |out_of_blink_cors_| is
   set.
 - Take the return value of a call of client_->WillFollowRedirect
   introduced at [1] into account.

1: https://chromium-review.googlesource.com/c/chromium/src/+/1150695

Bug: 736308, 353768
Change-Id: I5c251881902a66429d7c601e62786bd20890eb95
Reviewed-on: https://chromium-review.googlesource.com/1156120
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580054}
[modify] https://crrev.com/22fdb5852ada6187d35a697fb9a7731d28160b1a/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/redirect-loop.js
[modify] https://crrev.com/22fdb5852ada6187d35a697fb9a7731d28160b1a/third_party/blink/renderer/core/loader/threadable_loader.cc
[modify] https://crrev.com/22fdb5852ada6187d35a697fb9a7731d28160b1a/third_party/blink/renderer/core/loader/threadable_loader.h

Project Member

Comment 123 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36751f43351cd1f624c92755b52ce9e8f2ae5fd3

commit 36751f43351cd1f624c92755b52ce9e8f2ae5fd3
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Aug 07 11:54:15 2018

[OOR-CORS] Mark outofblink-cors/.../navigation-timing.https.html as PASS

This is a reland of
https://crrev.com/e87203b986d8ee7a7a4c46a25d2fe464c1cd31a6. The result
change is due to service worker servicification.

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Bug: 736308
Change-Id: I24d926c13211d8a579640fc6a156c01a3eb725bb
Reviewed-on: https://chromium-review.googlesource.com/1164971
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581197}
[modify] https://crrev.com/36751f43351cd1f624c92755b52ce9e8f2ae5fd3/third_party/WebKit/LayoutTests/TestExpectations
[rename] https://crrev.com/36751f43351cd1f624c92755b52ce9e8f2ae5fd3/third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/external/wpt/service-workers/service-worker/navigation-timing.https-expected.txt
[copy] https://crrev.com/36751f43351cd1f624c92755b52ce9e8f2ae5fd3/third_party/WebKit/LayoutTests/virtual/outofblink-cors/external/wpt/service-workers/service-worker/navigation-timing.https-expected.txt

Blocking: 855171
Project Member

Comment 125 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c

commit 43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Aug 08 07:37:45 2018

[OOR-CORS] Implement redirect location checks

This CL:
 - fixes CheckRedirectLocation implementation so that we can use it
   from CORSURLLoader.
 - fixes CORS flag handling in ResourceLoader so that it can use
   CheckRedirectLocation,
 - removes WebCORS::HandleRedirect, and has it implemented in
   blink::ResourceLoader instead,
 - integrates CheckRedirectLocation with CORSURLLoader, and
 - removes mojom::CORSError::kRedirectDisallowedScheme in favor of
   mojom::CORSError::kCORSDisabledScheme.

Bug: 736308, 800669, 870173
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ib31ab135b03dcc0beca137cbc39592fe3f314790
Reviewed-on: https://chromium-review.googlesource.com/1158089
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581495}
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/services/network/cors/cors_url_loader.cc
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/services/network/public/cpp/cors/cors.cc
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/services/network/public/cpp/cors/cors.h
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/services/network/public/cpp/cors/cors_unittest.cc
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/services/network/public/mojom/cors.mojom
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/blink/public/platform/web_cors.h
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/blink/renderer/core/loader/threadable_loader.cc
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/blink/renderer/core/loader/threadable_loader.h
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/blink/renderer/platform/exported/web_cors.cc
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/blink/renderer/platform/loader/cors/cors.cc
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/blink/renderer/platform/loader/cors/cors.h
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/blink/renderer/platform/loader/cors/cors_error_string.cc
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[modify] https://crrev.com/43b8facd3a2fbfb8f75b455f07d64acc2c13fb5c/third_party/blink/renderer/platform/loader/fetch/resource_loader.h

Project Member

Comment 126 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb62ee4a84550d4a47347f475bd1f4c98541541f

commit cb62ee4a84550d4a47347f475bd1f4c98541541f
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Aug 29 05:58:46 2018

Rename ResourceResponseInfo::response_type_via_service_worker

In preparation to a further change, this CL renames
response_type_via_service_worker in network::ResourceResponseInfo to
resource_type. The field will have a value in general, not only when
service worker is involved. Corresponding fields in related structs
are renamed, too.

Bug: 736308
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ib128c7aca7fb289efab3f37315ccf6a2cd9f327c
Reviewed-on: https://chromium-review.googlesource.com/1154768
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587020}
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/content/browser/service_worker/service_worker_navigation_loader_unittest.cc
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/content/browser/service_worker/service_worker_response_info.cc
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/content/common/service_worker/service_worker_loader_helpers.cc
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/media/blink/resource_multibuffer_data_provider.cc
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/services/network/cross_origin_read_blocking.cc
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/services/network/public/cpp/network_ipc_param_traits.h
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/services/network/public/cpp/resource_response.cc
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/services/network/public/cpp/resource_response_info.cc
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/services/network/public/cpp/resource_response_info.h
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/third_party/blink/public/platform/web_url_response.h
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/third_party/blink/renderer/core/fetch/fetch_manager.cc
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/third_party/blink/renderer/core/loader/resource/image_resource.cc
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/third_party/blink/renderer/core/loader/resource/multipart_image_resource_parser.cc
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/third_party/blink/renderer/core/loader/threadable_loader.cc
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/third_party/blink/renderer/platform/exported/web_url_response.cc
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/third_party/blink/renderer/platform/loader/fetch/resource.cc
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/third_party/blink/renderer/platform/loader/fetch/resource_loader_test.cc
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/third_party/blink/renderer/platform/loader/fetch/resource_response.cc
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/third_party/blink/renderer/platform/loader/fetch/resource_response.h
[modify] https://crrev.com/cb62ee4a84550d4a47347f475bd1f4c98541541f/third_party/blink/renderer/platform/loader/subresource_integrity_test.cc

Project Member

Comment 127 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61e0b32989f28f831922af32a465030f4c632204

commit 61e0b32989f28f831922af32a465030f4c632204
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Aug 31 03:36:42 2018

Replace CORSStatus with response type

blink::Resource has a field cors_status_ to store the result of CORS
check. This CL replaces the concept with "response type", a concept
defined in the fetch spec as
https://fetch.spec.whatwg.org/#concept-response-type. Actually, that
field has existed for long for service worker, but this CL starts using
it for network fetch. Using response type enables us to have the
consistent logic among several implementations, namely, CORSURLLoader,
ResourceLoader and ThreadableLoader.

https://html.spec.whatwg.org/#cors-same-origin and
https://html.spec.whatwg.org/#cors-cross-origin are now implemented so
various resource clients should use them.

Side effects:
 - blink::ResourceLoader now dispatches a ResourceError with a CORS
   error for CORS violations instead of an abort error.
 - Now CORS erros from CORSURLLoader are printed on the devtools
   console.

Bug: 736308, 878339
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I8777904654c0478d092ad90a2a919d5eb5dcc2bd
Reviewed-on: https://chromium-review.googlesource.com/1154246
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587935}
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/media/blink/BUILD.gn
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/media/blink/DEPS
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/media/blink/resource_multibuffer_data_provider.cc
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/services/network/cors/cors_url_loader.cc
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/services/network/cors/cors_url_loader.h
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/services/network/public/cpp/cors/cors.cc
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/services/network/public/cpp/cors/cors.h
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/services/network/public/cpp/cors/cors_unittest.cc
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/third_party/blink/renderer/core/css/remote_font_face_source.cc
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/third_party/blink/renderer/core/loader/resource/image_resource.cc
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/third_party/blink/renderer/core/loader/resource/script_resource.cc
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/third_party/blink/renderer/core/loader/threadable_loader.cc
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/third_party/blink/renderer/core/loader/threadable_loader.h
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/third_party/blink/renderer/platform/loader/cors/cors.cc
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/third_party/blink/renderer/platform/loader/cors/cors.h
[delete] https://crrev.com/3279bfda61401e969fa047bbe002c32d46ef9735/third_party/blink/renderer/platform/loader/cors/cors_status.h
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/third_party/blink/renderer/platform/loader/fetch/resource.cc
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/third_party/blink/renderer/platform/loader/fetch/resource.h
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/third_party/blink/renderer/platform/loader/fetch/resource_loader.h
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/third_party/blink/renderer/platform/loader/fetch/resource_loader_test.cc
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/third_party/blink/renderer/platform/loader/fetch/resource_response.cc
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/third_party/blink/renderer/platform/loader/fetch/resource_response.h
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/third_party/blink/renderer/platform/loader/subresource_integrity.cc
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/third_party/blink/renderer/platform/loader/subresource_integrity_test.cc
[modify] https://crrev.com/61e0b32989f28f831922af32a465030f4c632204/third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h

Project Member

Comment 128 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/940026e7d5d13195f9430fad4ea29b999516ad0c

commit 940026e7d5d13195f9430fad4ea29b999516ad0c
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Wed Sep 05 10:36:07 2018

OOR-CORS: LayoutTests TestExpectations updates

Bug: 736308
Change-Id: Ifccbcaa39040d36b6084338055572b3813e92f7d
Reviewed-on: https://chromium-review.googlesource.com/1201862
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588822}
[modify] https://crrev.com/940026e7d5d13195f9430fad4ea29b999516ad0c/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 129 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cf2a0a035a537f09892be7b1e400990d9081070

commit 6cf2a0a035a537f09892be7b1e400990d9081070
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Sep 27 07:50:18 2018

[OOR-CORS] Support --allow-file-access-from-files

network::ResourceRequest::request_initiator is set based on
blink::ResourceRequest::RequestorOrigin. The former is a url::Origin
the latter is a scoped_refptr<const blink::SecurityOrigin>.

A file: origin is handled in a special manner in blink. Without
--allow-file-access-from-files, it is NOT opaque but it is serialized
as "null". Currently conversion from blink::SecurityOrigin to
url::Origin relies on opacity (i.e., blink::SecurityOrigin::IsOpaque)
but that is not good for CORS.

This CL changes that. With this CL, A SecurityOrigin serializes as
"null" is converted to a unique url::Origin.

Bug: 736308
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I7b5ec4894c52499d85165689fd114e28bbd8bb97
Reviewed-on: https://chromium-review.googlesource.com/1131021
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594625}
[modify] https://crrev.com/6cf2a0a035a537f09892be7b1e400990d9081070/content/browser/loader/cors_file_origin_browsertest.cc
[modify] https://crrev.com/6cf2a0a035a537f09892be7b1e400990d9081070/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/6cf2a0a035a537f09892be7b1e400990d9081070/services/network/cors/cors_url_loader.cc
[modify] https://crrev.com/6cf2a0a035a537f09892be7b1e400990d9081070/services/network/cors/preflight_controller.cc
[modify] https://crrev.com/6cf2a0a035a537f09892be7b1e400990d9081070/services/network/public/cpp/cors/cors.cc
[modify] https://crrev.com/6cf2a0a035a537f09892be7b1e400990d9081070/services/network/public/cpp/cors/cors.h
[modify] https://crrev.com/6cf2a0a035a537f09892be7b1e400990d9081070/third_party/blink/renderer/platform/loader/cors/cors.cc

Project Member

Comment 130 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c6ce7173722c5e0734d19787138dc12753ef741

commit 5c6ce7173722c5e0734d19787138dc12753ef741
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Wed Oct 10 09:50:12 2018

OOR-CORS: Skip some CrossSiteDocumentBlockingTest tests

CrossSiteDocumentBlockingTest relied on
WebPreferences::web_security_enabled that won't be supported by
OOR-CORS, and some tests do not make much sense if CORS checks
are implemented in out of renderer processes.

This patch modifies CrossSiteDocumentBlockingTest to run with
or without kOutOfBlinkCORS feature, and skips test cases that
won't make much sense for kOutOfBlinkCORS.

Bug: 870173, 736308
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: If45b213d8e14039a19af1e54a11759ebba42694a
Reviewed-on: https://chromium-review.googlesource.com/c/1253623
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Ɓukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598270}
[modify] https://crrev.com/5c6ce7173722c5e0734d19787138dc12753ef741/content/browser/loader/cross_site_document_blocking_browsertest.cc
[modify] https://crrev.com/5c6ce7173722c5e0734d19787138dc12753ef741/services/network/cross_origin_read_blocking.h

Blockedon: 894690
Blockedon: 905971
Blocking: 750987
Blockedon: 915546
Cc: yoavweiss@chromium.org
Showing comments 36 - 135 of 135 Older

Sign in to add a comment