Use 192x192 as ideal size for touch icons on Android |
||||||||
Issue descriptionOn Android, the ideal size for favicons should be 192x192, regardless of its type. Currently, touch icons use 144x144 as ideal size.
,
Jul 24 2017
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/195ee4a01e7dfb6a1a13a32e01526464e7715f12 commit 195ee4a01e7dfb6a1a13a32e01526464e7715f12 Author: mastiz <mastiz@chromium.org> Date: Thu Jul 27 16:40:13 2017 Revert of Always prefer 192x192 on mobile, also for touch icons (patchset #2 id:20001 of https://codereview.chromium.org/2972643002/ ) Reason for revert: Perf regression, suspect of accidentally fixing a bug that was believed to be previously fixed ( crbug.com/735354 ) due to the max image size used during download. BUG= 749331 Original issue's description: > Always prefer 192x192 on mobile, also for touch icons > > Previously, the ideal size for a touch icon was 144x144, which was > originally introduced honoring iPad icon size. > > Always going for 192x192 (for both touch and non-touch icons) is > simpler, more consistent and more compatible with Apple's current > recommendations for iOS [1], which for example recommend a 180x180 icon > for iPhone 6 Plus (scale factor of 3x). > > [1] https://developer.apple.com/ios/human-interface-guidelines/graphics/app-icon/ > > BUG= 736290 > > Review-Url: https://codereview.chromium.org/2972643002 > Cr-Commit-Position: refs/heads/master@{#488935} > Committed: https://chromium.googlesource.com/chromium/src/+/c63d78c7a25a50f2fdfa0ab5cbb5566a21a6774e TBR=pkotwicz@chromium.org,noyau@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 736290 Review-Url: https://codereview.chromium.org/2986033002 Cr-Commit-Position: refs/heads/master@{#489971} [modify] https://crrev.com/195ee4a01e7dfb6a1a13a32e01526464e7715f12/components/favicon/core/favicon_handler.cc [modify] https://crrev.com/195ee4a01e7dfb6a1a13a32e01526464e7715f12/components/favicon/core/favicon_handler.h [modify] https://crrev.com/195ee4a01e7dfb6a1a13a32e01526464e7715f12/components/favicon/core/favicon_handler_unittest.cc
,
Jul 27 2017
,
Aug 1 2017
,
Aug 1 2017
,
Aug 1 2017
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 1 2017
,
Aug 1 2017
Sorry for the above, I requested a merge for the wrong patch/bug, should have been crbug.com/711187 instead.
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67bebf2024d59842f759169154b4b030fe7aafa4 commit 67bebf2024d59842f759169154b4b030fe7aafa4 Author: Mikel Astiz <mastiz@chromium.org> Date: Fri Jan 05 10:46:31 2018 Reland "Always prefer 192x192 on mobile, also for touch icons" Reland attempt after a perf regression motivated a revert, https://codereview.chromium.org/2986033002. The underlying bug ( crbug.com/735354 ) is believed to be fixed now so no (illegit) perf regression is expected now. Original change's description: > Always prefer 192x192 on mobile, also for touch icons > > Previously, the ideal size for a touch icon was 144x144, which was > originally introduced honoring iPad icon size. > > Always going for 192x192 (for both touch and non-touch icons) is > simpler, more consistent and more compatible with Apple's current > recommendations for iOS [1], which for example recommend a 180x180 icon > for iPhone 6 Plus (scale factor of 3x). > > [1] https://developer.apple.com/ios/human-interface-guidelines/graphics/app-icon/ > > BUG= 736290 > > Review-Url: https://codereview.chromium.org/2972643002 > Cr-Commit-Position: refs/heads/master@{#488935} Bug: 736290 Bug: 749331 Change-Id: I18e9db377e890af0dd95aa2d3329f203611d1d4f Reviewed-on: https://chromium-review.googlesource.com/836368 Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#527255} [modify] https://crrev.com/67bebf2024d59842f759169154b4b030fe7aafa4/components/favicon/core/favicon_handler.cc [modify] https://crrev.com/67bebf2024d59842f759169154b4b030fe7aafa4/components/favicon/core/favicon_handler_unittest.cc
,
Jan 15 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Jul 24 2017