New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736255 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Layout Test external/wpt/.../mozilla-central-reftests/flexbox/flexbox-baseline-multi-item-vert-001b.html skipped

Project Member Reported by tansell@chromium.org, Jun 23 2017

Issue description

The following layout test(s) is failing on Mac:

 * external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/writing-modes-3/text-combine-upright-compression-001.html

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 23 2017

Also looks like these two are flaky as well;

 * external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-multi-item-vert-001b.html
 * external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/writing-modes-3/text-combine-upright-compression-001.html
 * external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/writing-modes-3/text-combine-upright-compression-004.html
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa750369cc4572ec05021c414db21fb58ad7db56

commit fa750369cc4572ec05021c414db21fb58ad7db56
Author: tansell <tansell@chromium.org>
Date: Fri Jun 23 10:33:54 2017

WPT: Disable more tests for Mac.

 * external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-multi-item-vert-001b.html
 * external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/writing-modes-3/text-combine-upright-compression-001.html
 * external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/writing-modes-3/text-combine-upright-compression-004.html

BUG=736255
TBR=jsbell@chromium.org,dpranke@chromium.org,mcgreevy@chromium.org,qyearsley@chromium.org,jeffcarp@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2954103002
Cr-Commit-Position: refs/heads/master@{#481845}

[modify] https://crrev.com/fa750369cc4572ec05021c414db21fb58ad7db56/third_party/WebKit/LayoutTests/TestExpectations

Cc: foolip@chromium.org
 Issue 736319  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2380ef342b43c3d4a172d53208c83af56173efd

commit f2380ef342b43c3d4a172d53208c83af56173efd
Author: Xida Chen <xidachen@chromium.org>
Date: Fri Jun 23 12:34:41 2017

Mark some text-combine-upright-compression-xxx tests flaky

TBR=foolip@chromium.org
NOTRY=true

Bug: 736255
Change-Id: I5c44e037aa86f8de3060f97cc9326544a79f12c0
Reviewed-on: https://chromium-review.googlesource.com/545278
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481862}
[modify] https://crrev.com/f2380ef342b43c3d4a172d53208c83af56173efd/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d522b564fe1969779589405660027a94df5b05b4

commit d522b564fe1969779589405660027a94df5b05b4
Author: Xida Chen <xidachen@chromium.org>
Date: Sat Jun 24 00:52:20 2017

Mark some text-combine-upright-compression-xxx tests flaky on Mac

TBR=imcheng@chromium.org
NOTRY=true

Bug: 736255
Change-Id: Id60f98ddaa7bafc27d1e6d0435108355da19a68f
Reviewed-on: https://chromium-review.googlesource.com/547255
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482097}
[modify] https://crrev.com/d522b564fe1969779589405660027a94df5b05b4/third_party/WebKit/LayoutTests/TestExpectations

Comment 8 by foolip@chromium.org, Jun 27 2017

Cc: m...@gsnedders.com
Geoffrey, any thoughts on what should be done with css/vendor-imports/?

Comment 9 by geoff...@gmail.com, Jun 27 2017

Cc: -m...@gsnedders.com geoff...@gmail.com
Looking at the first test mentioned here, this seems likely to just be  bug 507054  again, given the reliance on web fonts.

Philip,

I'd like to get rid of it, but it's stuck in a mess of Mozilla internal politics. Given https://bugzilla.mozilla.org/show_bug.cgi?id=1363428 has now been fixed, I'm hopeful we can get rid of it soonish.
Labels: -OS-All OS-Mac
Status: Available (was: Untriaged)
Summary: Layout Test external/wpt/.../mozilla-central-reftests/flexbox/flexbox-baseline-multi-item-vert-001b.html skipped (was: Layout Test external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/writing-modes-3/text-combine-upright-compression-001.html is flaky on Windows)
There is currently one line in TestExpectations associated with this bug:
crbug.com/736255 [ Mac ] external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-multi-item-vert-001b.html [ Skip ]

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f239a9f5a852110b61e9f0f088ac15fd22c91ff

commit 1f239a9f5a852110b61e9f0f088ac15fd22c91ff
Author: Peter Mayo <petermayo@chromium.org>
Date: Mon Jul 16 15:01:55 2018

Re-enable WPT flexbox-baseline-multi-item-vert-001b

It seems that external/wpt/css/vendor-imports/mozilla/...
   mozilla-central-reftests/flexbox/...
   flexbox-baseline-multi-item-vert-001b.html
has been passing consistently for as long as the flakiness
dashboard has history now.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#
   testType=webkit_layout_tests&
   tests=flexbox-baseline-multi-item-vert-001b.html

This test also seems to pass on the Mac bots, so we might
just as well enable it there at the same time.

Bug: 736255,626703
Change-Id: I008407bfd4cf65c88d60b2095ecb58c4dd5a2cce
Reviewed-on: https://chromium-review.googlesource.com/1133304
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575267}
[modify] https://crrev.com/1f239a9f5a852110b61e9f0f088ac15fd22c91ff/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment