[Missing Tests]: Avatar icon is not seen properly on fresh launch |
|||
Issue descriptionAutomated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future? CL: https://chromium.googlesource.com/chromium/src/+/b0f420e81d69cf2712f7847a364b2d7d3d59195c Ref Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=732684 Note : Tagging this as RBS since the base bug is blocker. Thank you!
,
Jun 26 2017
Removing the RBS label; this isn't truly a blocker for release.
,
Jun 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09fba90138a1c3197d0568fec12ceb75217aedf3 commit 09fba90138a1c3197d0568fec12ceb75217aedf3 Author: pnoland <pnoland@chromium.org> Date: Mon Jun 26 21:38:27 2017 [sync] Fix IsSyncConfirmationNeeded crash when local backend is enabled signin_ isn't present when local backend is enabled, so we need to avoid dereferencing it. Other call sites for IsSignedIn() do this check already. R=skym@chromium.org BUG=736118, 736241 Review-Url: https://codereview.chromium.org/2961673002 Cr-Commit-Position: refs/heads/master@{#482419} [modify] https://crrev.com/09fba90138a1c3197d0568fec12ceb75217aedf3/components/browser_sync/profile_sync_service.cc [modify] https://crrev.com/09fba90138a1c3197d0568fec12ceb75217aedf3/components/browser_sync/profile_sync_service_startup_unittest.cc [modify] https://crrev.com/09fba90138a1c3197d0568fec12ceb75217aedf3/components/browser_sync/profile_sync_service_unittest.cc
,
Jun 26 2017
The above-referenced patch adds a unit test that test for the specific condition that triggered the bug. I'm going to leave this open for now since we would also benefit from a more general set of tests around sync error indicators.
,
Jan 17 2018
While this would be nice to have, it's unlikely to get done any time soon. |
|||
►
Sign in to add a comment |
|||
Comment 1 by sheriffbot@chromium.org
, Jun 26 2017