New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736219 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Dec 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression:'Hit F5 to reload and capture filmstrip' message appears even after filmstrip is capturing in Devtools

Project Member Reported by rkalavakuntla@chromium.org, Jun 23 2017

Issue description

Chrome Version:61.0.3138.0/9677.0.0 dev channel Daisy & Candy
OS:Chrome

What steps will reproduce the problem?
(1)Sign into user >>Launch chrome >> Press Ctrl+Shift+I to open Devtools
(2)Go to Network tab >> Click on Capture screenshots >>Hit Reload button and Observe the process of filmstrip capturing

Actual: After pressing Reload button 'Hit F5 to reload and capture filmstrip' message appears again in between recording also
Expected:After pressing Reload button , frames should be recorded and fetched,no such message text should be seen.

This is a regression issue broken in M-61

Note:Issue is also seen in Linux, Windows OS

Other info would be updated soon..



 
Expected (2).webm
2.7 MB View Download
Actual.webm
1.4 MB View Download
Labels: ReleaseBlock-Stable
Owner: allada@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce the issue on Windows 7,Mac OS 10.12.4, Ubuntu 14.04 using latest Canary #61.0.3138.0 dev

Manual Bisect Info:
-------------------
Good build:61.0.3136.0(480665)
Bad build :61.0.3137.0(481056)

Using per-revision bisect providing the bisect results:

You are probably looking for a change made after 480727 (known good), but no later than 480728 (first known bad).
CHANGELOG URL:
 https://chromium.googlesource.com/chromium/src/+log/e60d1d4ae98c4c916db70cb2f090f59e3ad76a51..ca6a9f1f759e79a3a08be1747c47ee9354db6cff

Suspecting: https://chromium.googlesource.com/chromium/src/+/ca6a9f1f759e79a3a08be1747c47ee9354db6cff
Review-Url: https://codereview.chromium.org/2914033002

allada@:Could you please take a look into this issue and reassign if this issue is not related to your change.

Thanks..!!
@allada -- Could you please look into the issue and provide an update.
Thanks in Advance.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41957a695219fcad78fee46ca3b00e4aac388799

commit 41957a695219fcad78fee46ca3b00e4aac388799
Author: Nathan Bruer <allada@chromium.org>
Date: Fri Jul 07 22:12:27 2017

[Devtools] Fixed regression from SDK.TracingModel.reset() being called

Fixes a regression caused by:
https://chromium-review.googlesource.com/c/526855/

SDK.TracingModel.reset() was removed in favor of destroy() and
re-constructing it, but closure did not complain because of
@unrestricted. This patch also will keep this from happening here by
removing @unrestricted from classes in NetworkPanel.js.

R=caseq
BUG= 736219 

Change-Id: I4284602dbaca4af93e6645dd395ce4ebc51613ed
Reviewed-on: https://chromium-review.googlesource.com/562299
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485068}
[modify] https://crrev.com/41957a695219fcad78fee46ca3b00e4aac388799/third_party/WebKit/LayoutTests/inspector/throttling/mobile-throttling.html
[modify] https://crrev.com/41957a695219fcad78fee46ca3b00e4aac388799/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

Tested this on Windows 7(61.0.3153.3),Mac OS 10.12.4, Ubuntu 14.04 using latest Canary #61.0.3154.0 dev and Observed that after reloading the page still able to  see 'Hit F5 to reload and capture filmstrip' message which is not as expected.

Attached screen-cast for your reference
@allada: Could you please confirm whether this is intended behavior..
Thanks!!

736219.webm
2.1 MB View Download

Comment 5 by ajha@chromium.org, Jul 11 2017

Labels: Needs-Feedback

Comment 6 by gov...@chromium.org, Jul 11 2017

A friendly reminder that M61 branch is coming soon on 07/20! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix ASAP to trunk. This way we branch M61 from a high quality trunk. Thank you.

Comment 7 by ajha@chromium.org, Jul 14 2017

allada@: Could you please review the C#4 and update accordingly.
allada@,

friendly ping to get an update on this issue as per comment#4, as it is marked RB stable.
Thanks..!!
allada@: Could you please check the issue as per C#4 and update accordingly.
Thanks..!!
This patch did not fix it, but was needed for the patch that actually does fix it.
URGENT - PTAL.
Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the M61 branch #3163 ASAP to have enough baking time in Beta before Stable promotion. Thank you!

Know that this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label.

@Allada: Is there any latest update's available on this issue? since it's tagged with Release Block Stable.

Thanks!!
Labels: -ReleaseBlock-Stable
Owner: alph@chromium.org

Comment 15 by alph@chromium.org, Mar 2 2018

Labels: -Pri-1 Pri-3
Status: Archived (was: Assigned)
Archiving feature requests that we are unlikely to address during the next 18 months.

Sign in to add a comment