Settings: "Handlers" page should use friendly names for protocols |
|||||
Issue descriptionChrome Version: 61 OS: Desktop What steps will reproduce the problem? (1) Register a mailto link (e.g., Gmail) (2) chrome://settings/handlers What is the expected result? Gmail listed under "email". What happens instead? Gmail listed under "mailto". There is code for showing a "friendly name" for certain protocols (mailto and webcal) which is used by the permission request dialog: https://cs.chromium.org/chromium/src/chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc?l=17 This same code could be re-used in Settings for a consistent experience.
,
Mar 30 2018
,
Apr 2 2018
,
Apr 3 2018
,
Apr 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed90af462bd60a0ef1d13948f20d4d21e5f49968 commit ed90af462bd60a0ef1d13948f20d4d21e5f49968 Author: Esmael El-Moslimany <aee@chromium.org> Date: Wed Apr 04 00:17:21 2018 Settings WebUI: use friendly protocol name in UI when a friendly name is available Bug: 736217 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie8e661305b9135ef3ccba5fd52b6053467c695c2 Reviewed-on: https://chromium-review.googlesource.com/991202 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#547883} [modify] https://crrev.com/ed90af462bd60a0ef1d13948f20d4d21e5f49968/chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc [modify] https://crrev.com/ed90af462bd60a0ef1d13948f20d4d21e5f49968/chrome/browser/resources/settings/site_settings/protocol_handlers.html [modify] https://crrev.com/ed90af462bd60a0ef1d13948f20d4d21e5f49968/chrome/browser/resources/settings/site_settings/protocol_handlers.js [modify] https://crrev.com/ed90af462bd60a0ef1d13948f20d4d21e5f49968/chrome/browser/ui/content_settings/content_setting_bubble_model.cc [modify] https://crrev.com/ed90af462bd60a0ef1d13948f20d4d21e5f49968/chrome/browser/ui/webui/settings/protocol_handlers_handler.cc [modify] https://crrev.com/ed90af462bd60a0ef1d13948f20d4d21e5f49968/chrome/common/custom_handlers/protocol_handler.cc [modify] https://crrev.com/ed90af462bd60a0ef1d13948f20d4d21e5f49968/chrome/common/custom_handlers/protocol_handler.h [modify] https://crrev.com/ed90af462bd60a0ef1d13948f20d4d21e5f49968/chrome/test/data/webui/settings/protocol_handlers_tests.js
,
Apr 4 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tkent@chromium.org
, Jul 14 2017