New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736195 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security

Blocking:
issue pdfium:11



Sign in to add a comment

Heap-buffer-overflow in SkiaState::ClipRestore

Project Member Reported by ClusterFuzz, Jun 23 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5391008601997312

Fuzzer: libFuzzer_pdfium_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 4
Crash Address: 0x612000003dbc
Crash State:
  SkiaState::ClipRestore
  CFX_SkiaDeviceDriver::RestoreState
  CFX_RenderDevice::RestoreState
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=481514:481576

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5391008601997312


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: thestig@chromium.org
Components: Internals>Plugins>PDF
Owner: dsinclair@chromium.org
Status: Assigned (was: Untriaged)
And another.
Blocking: pdfium:11
May be related to  bug 736105 .

We may flip Skia off again in the near future.
Cc: caryclark@google.com
Labels: Pri-1
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 23 2017

Labels: M-61
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 23 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -caryclark@google.com dsinclair@chromium.org
Owner: caryclark@chromium.org
Labels: -ReleaseBlock-Stable
The skia path code has been disabled now. Removing release block label.
Project Member

Comment 8 by ClusterFuzz, Jun 28 2017

ClusterFuzz has detected this issue as fixed in range 481576:482713.

Detailed report: https://clusterfuzz.com/testcase?key=5391008601997312

Fuzzer: libFuzzer_pdfium_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 4
Crash Address: 0x612000003dbc
Crash State:
  SkiaState::ClipRestore
  CFX_SkiaDeviceDriver::RestoreState
  CFX_RenderDevice::RestoreState
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=481514:481576
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=481576:482713

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5391008601997312


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Jun 28 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5391008601997312 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 28 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -M-61 ClusterFuzz-Wrong
Status: Assigned (was: Verified)
Skia Paths were disabled.
Owner: caryclark@google.com
bug is in core/fxge/skia/fx_skia_device.cpp:

@@ -936,2 +1031,2 @@ class SkiaState {
-    if (m_commandIndex < count - 1) {
+    if (m_commandIndex < count) {

 Issue 736105  has been merged into this issue.
Project Member

Comment 15 by sheriffbot@chromium.org, Jun 29 2017

Labels: M-61
Project Member

Comment 16 by sheriffbot@chromium.org, Jun 29 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Security_Impact-Head -ReleaseBlock-Stable
Feature triggering bug has been turned off; bug remains open to track fixing underlying bug.
Project Member

Comment 18 by sheriffbot@chromium.org, Jun 30 2017

Labels: Security_Impact-Head
Project Member

Comment 19 by sheriffbot@chromium.org, Jun 30 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Issue 737041 has been merged into this issue.
Project Member

Comment 21 by sheriffbot@chromium.org, Jun 30 2017

Labels: Fracas FoundIn-M-61
Users experienced this crash on the following builds:

Linux Dev 61.0.3141.7 -  1.06 CPM, 1 reports, 1 clients (signature SkiaState::SetClip)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas
Labels: -Fracas -Security_Impact-Head -ReleaseBlock-Stable Fracas-Wrong
Project Member

Comment 23 by sheriffbot@chromium.org, Jul 1 2017

Labels: Security_Impact-Head
Project Member

Comment 24 by sheriffbot@chromium.org, Jul 1 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Security_Impact-Head -ReleaseBlock-Stable Security_Impact-None
This code has been disabled, removing RBS.
Status: Fixed (was: Assigned)
Fixed here: https://pdfium-review.googlesource.com/c/7276/
Labels: -ClusterFuzz-Wrong
Project Member

Comment 28 by sheriffbot@chromium.org, Oct 16 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment