Pending tree raster duration timer crashes on linux_chromium_asan_rel_ng |
||
Issue descriptionhttps://codereview.chromium.org/2946223003/ added pending_tree_raster_duration_timer_ to LTHI I had a CL (https://chromium-review.googlesource.com/c/541580/) fail on the linux_chromium_asan_rel_ng trybot because of this error: [ RUN ] LayerTreeHostContextTestDontUseLostResources.RunMultiThread_DelegatingRenderer [24159:24160:0622/195340.050935:1969012336:FATAL:layer_tree_host_impl.cc(393)] Check failed: !pending_tree_raster_duration_timer_. Stack trace isn't symbolicated. https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/398426 logdog: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.linux%2Flinux_chromium_asan_rel_ng%2F398426%2F%2B%2Frecipes%2Fsteps%2Fcc_unittests__with_patch_%2F0%2Flogs%2FLayerTreeHostContextTestDontUseLostResources.RunMultiThread_DelegatingRenderer%2F0
,
Jun 23 2017
,
Jun 23 2017
https://codereview.chromium.org/2956563002/ is up to fix this.
,
Jun 23 2017
In CQ.
,
Jun 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55116d34017a084746e6829576e5716d5586d084 commit 55116d34017a084746e6829576e5716d5586d084 Author: khushalsagar <khushalsagar@chromium.org> Date: Fri Jun 23 19:01:07 2017 cc: Fix DCHECK failure for pending tree raster duration timer. We currently assume that activation will always be preceded by being notified that the tree is ready to be activated but that's not necessarily true. Fix that. BUG= 736193 R=sunnyps@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2956563002 Cr-Commit-Position: refs/heads/master@{#481980} [modify] https://crrev.com/55116d34017a084746e6829576e5716d5586d084/cc/trees/layer_tree_host_impl.cc
,
Jun 23 2017
,
Jun 23 2017
Thanks for the quick fix.
,
Jun 23 2017
No problem. Thanks for catching it and sorry I missed this initially. |
||
►
Sign in to add a comment |
||
Comment 1 by khushals...@chromium.org
, Jun 23 2017