New issue
Advanced search Search tips

Issue 736192 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocked on:
issue 594639



Sign in to add a comment

Put ES6 Modules behind a finch flag as a failsafe measure

Project Member Reported by kenjibaheux@chromium.org, Jun 23 2017

Issue description

Just in case something unexpected happens, let's use a finch flag to control the feature.
 

Comment 1 by kouhei@chromium.org, Jun 23 2017

Blockedon: 594639

Comment 2 by kinuko@chromium.org, Jun 27 2017

Status: Assigned (was: Untriaged)
Owner: toyoshim@chromium.org
Components: Blink>HTML>Script
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08ff97980714bbfb42d9b0d50ac01feabce3e500

commit 08ff97980714bbfb42d9b0d50ac01feabce3e500
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Tue Jul 04 08:06:34 2017

ES6 modules: Enable by default with a kill switch

This patch enables ES6 modules support by default with a kill switch
that can be managed by about://flags and server providing configurations.

Bug:  736192 
Change-Id: I5c244ba0103a95625aefc9b42e9295d03ff8d4a2
Reviewed-on: https://chromium-review.googlesource.com/558727
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484063}
[modify] https://crrev.com/08ff97980714bbfb42d9b0d50ac01feabce3e500/chrome/browser/about_flags.cc
[modify] https://crrev.com/08ff97980714bbfb42d9b0d50ac01feabce3e500/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/08ff97980714bbfb42d9b0d50ac01feabce3e500/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/08ff97980714bbfb42d9b0d50ac01feabce3e500/content/child/runtime_features.cc
[modify] https://crrev.com/08ff97980714bbfb42d9b0d50ac01feabce3e500/content/public/common/content_features.cc
[modify] https://crrev.com/08ff97980714bbfb42d9b0d50ac01feabce3e500/content/public/common/content_features.h
[modify] https://crrev.com/08ff97980714bbfb42d9b0d50ac01feabce3e500/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/08ff97980714bbfb42d9b0d50ac01feabce3e500/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/08ff97980714bbfb42d9b0d50ac01feabce3e500/third_party/WebKit/LayoutTests/virtual/stable/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/08ff97980714bbfb42d9b0d50ac01feabce3e500/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/08ff97980714bbfb42d9b0d50ac01feabce3e500/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/08ff97980714bbfb42d9b0d50ac01feabce3e500/third_party/WebKit/public/platform/WebRuntimeFeatures.h
[modify] https://crrev.com/08ff97980714bbfb42d9b0d50ac01feabce3e500/tools/metrics/histograms/enums.xml

Status: Fixed (was: Assigned)

Sign in to add a comment