PageInfoPopup.java:
- addDescriptionSection(): Remove
- addSection(): Modify
- Check for has_certificate. If true:
- call addCertificateViewer()
- Save mCertificateLayout for addResetCertDecisionsButton()
- setCertificateViewer(): Change to addCertificateViewer(ViewGroup layout, String label)
- addResetCertDecisionsButton(): Keep
- Add to mCertificateLayout (part of the connection explanation) instead of mContainer (as a top-level bullet).
- Audit for unneeded member variables.
C++
- Add SecurityStyleExplanations to IdentityInfo
- In PageInfo::PresentSiteIdentity(), use web_contents()->GetDelegate()->GetSecurityStyle() to set info.security_style_explanations (with localize set to true)
- In ConnectionInfoPopupAndroid::SetIdentityInfo, iterate over each list of explanations and call Java_ConnectionInfoPopup_addSection() for each explanation.
Comment 1 by lgar...@chromium.org
, Jun 27 2017