New issue
Advanced search Search tips

Issue 736185 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Team-Security-UX

Blocking:
issue 657299



Sign in to add a comment

Switch Android ConnectionInfoPopup code to security panel bullets

Project Member Reported by lgar...@chromium.org, Jun 23 2017

Issue description

PageInfoPopup.java:
- addDescriptionSection(): Remove
- addSection(): Modify
  - Check for has_certificate. If true:
    - call addCertificateViewer()
    - Save mCertificateLayout for addResetCertDecisionsButton()
- setCertificateViewer(): Change to addCertificateViewer(ViewGroup layout, String label)
- addResetCertDecisionsButton(): Keep
  - Add to mCertificateLayout (part of the connection explanation) instead of mContainer (as a top-level bullet).
- Audit for unneeded member variables.

C++
- Add SecurityStyleExplanations to IdentityInfo
- In PageInfo::PresentSiteIdentity(), use web_contents()->GetDelegate()->GetSecurityStyle() to set info.security_style_explanations (with localize set to true)
- In ConnectionInfoPopupAndroid::SetIdentityInfo, iterate over each list of explanations and call Java_ConnectionInfoPopup_addSection() for each explanation.

 
Summary: Switch Android ConnectionInfoPopup code to security panel bullets (was: Switch Android Connection Info to security panel bullets)

Comment 2 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt
Owner: ----
Status: Available (was: Started)

Comment 4 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt

Sign in to add a comment