Issue metadata
Sign in to add a comment
|
Reader Mode should be available in accessibility mode |
||||||||||||||||||||||||
Issue descriptionChrome Version: M59 OS: Android Reader Mode (or Mobile-friendly View) on Clank is disabled if the accessibility mode (TalkBack) is on due to issue 503232. Now that Reader Mode is no longer an Overlay Panel after https://codereview.chromium.org/2878543003, it became accessible. Therefore, it should not be disabled anymore.
,
Jun 24 2017
Based on my tests I believe the java stack is unrelated. The native stack is less than helpful. Occasionally I see the following in the log: 06-23 17:43:46.436 18039 18039 I chromium: [INFO:CONSOLE(115)] "DomDistiller debug level: 0", source: (115) So it looks like distillation at least starts but fails. I changed the infobar to navigate to a different URL and it doesn't crash, so it looks like a problem with the dom-distiller component.
,
Jul 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b6112cc6c198d8b6df38b3e0a9a1aa19f16b383 commit 4b6112cc6c198d8b6df38b3e0a9a1aa19f16b383 Author: wychen <wychen@chromium.org> Date: Fri Jul 07 18:15:36 2017 Add "AllArticles" mode to Reader Mode heuristics This is a preliminary change to enable the desired mode in the back end. BUG= 736168 Review-Url: https://codereview.chromium.org/2961533002 Cr-Commit-Position: refs/heads/master@{#484987} [modify] https://crrev.com/4b6112cc6c198d8b6df38b3e0a9a1aa19f16b383/chrome/browser/about_flags.cc [modify] https://crrev.com/4b6112cc6c198d8b6df38b3e0a9a1aa19f16b383/chrome/browser/dom_distiller/distillable_page_utils_browsertest.cc [modify] https://crrev.com/4b6112cc6c198d8b6df38b3e0a9a1aa19f16b383/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/4b6112cc6c198d8b6df38b3e0a9a1aa19f16b383/chrome/browser/flag_descriptions.h [modify] https://crrev.com/4b6112cc6c198d8b6df38b3e0a9a1aa19f16b383/components/dom_distiller/content/renderer/distillability_agent.cc [modify] https://crrev.com/4b6112cc6c198d8b6df38b3e0a9a1aa19f16b383/components/dom_distiller/core/dom_distiller_switches.cc [modify] https://crrev.com/4b6112cc6c198d8b6df38b3e0a9a1aa19f16b383/components/dom_distiller/core/dom_distiller_switches.h [modify] https://crrev.com/4b6112cc6c198d8b6df38b3e0a9a1aa19f16b383/components/dom_distiller/core/experiments.cc [modify] https://crrev.com/4b6112cc6c198d8b6df38b3e0a9a1aa19f16b383/components/dom_distiller/core/experiments.h [modify] https://crrev.com/4b6112cc6c198d8b6df38b3e0a9a1aa19f16b383/ios/chrome/browser/ui/reader_mode/reader_mode_checker.mm
,
Jul 26 2017
Surprisingly the crash mentioned in #c1 no longer reproduces after rebasing to ToT. No idea why.
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c29838bdd576446894d4fa5a7f19974a8c1b51e commit 6c29838bdd576446894d4fa5a7f19974a8c1b51e Author: wychen <wychen@chromium.org> Date: Thu Jul 27 00:09:08 2017 Do not disable ReaderMode when TalkBack is on ReaderMode became accessible again after https://codereview.chromium.org/2878543003. Therefore, it should not be disabled when TalkBack is turned on anymore. BUG= 736168 Review-Url: https://codereview.chromium.org/2955533002 Cr-Commit-Position: refs/heads/master@{#489806} [modify] https://crrev.com/6c29838bdd576446894d4fa5a7f19974a8c1b51e/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
,
Aug 7 2017
,
Sep 29 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by wychen@chromium.org
, Jun 23 2017