New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 736166 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug
Team-Security-UX

Blocking:
issue 734590



Sign in to add a comment

Add Superfish interstitial to chrome://interstitials

Project Member Reported by est...@chromium.org, Jun 23 2017

Issue description

This will allow us to test the Superfish interstitial easily.

Otherwise, it's difficult to test it; you either need a laptop with Superfish installed, or we'd need to modify superfish.badssl.com to serve the root to trigger the interstitial (cc lgarron)
 
Why would we need to serve the root?

Comment 2 by est...@chromium.org, Jun 23 2017

Cc: mea...@chromium.org
Components: UI>Browser>Interstitials
Labels: Hotlist-GoodFirstBug
sperigo, let me know if you're interested in picking this up, and I can give more detail. It would basically just be adding a parameter to this method: https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/interstitials/interstitial_ui.cc?l=129

Comment 3 by est...@chromium.org, Jun 23 2017

Re: comment #1: the logic to trigger the interstitial looks for the presence of the root certificate and triggers the interstitial if it's there, so it doesn't trigger on superfish.badssl.com right now unless you actually have the root installed.

Comment 4 by est...@chromium.org, Jun 28 2017

Status: Started (was: Assigned)

Comment 6 by est...@chromium.org, Jun 28 2017

Status: Fixed (was: Started)

Sign in to add a comment