New issue
Advanced search Search tips

Issue 736163 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Timing information for logging messages in logdog

Project Member Reported by tansell@chromium.org, Jun 23 2017

Issue description

(This is a non-urgent feature request.)

A lot of the time it is very useful to know how long between two log messages appeared in the logs. 

Currently a lot of the tools support outputting timing information, but not all do and they don't have a consistent format for them.

I believe that LogDog is already recording some type of timing information about the log data. Is there a way to surface this information?

Dirk said;
> In one sense that pushes the timestamp farther away from when the event is actually happening (as opposed to when logdog sees it)
> In another sense, though, I think the logdog records are already timestamped
> But there isn't a direct correlation between a logdog record and a single line

 

Comment 1 by hinoka@chromium.org, Jun 23 2017

fwiw there's currently a flag in the cit logdog tool to display this.  afaik it's not surfaced in the web ui atm.

Comment 2 by estaab@chromium.org, Jun 23 2017

Labels: Pri-3
Status: Available (was: Untriaged)
Yeah, I think logdog used to show this and people wanted the UI to be simpler. We can talk about the right balance to get the info without UI clutter or perf costs.

Comment 3 by d...@chromium.org, Jun 23 2017

LogDog records have timestamps regarding when the data was *read* (not sent) by LogDog. Kernel buffers can certainly affect this, but it should be largely accurate all things considered.

The web viewer *does* have the ability to render this. It does this by fundamentally modifying the rendered layout to include metadata blocks, which dramatically slows down the rendering (which is why it's not enabled by default). You can see this in a log stream by:
1) Appending "&m=1" to the viewer URL.
2) Clicking the "Metadata" option that appears once the log stream has finished rendering.

Since this has to happen during rendering, it's not the sort of thing you can trivially toggle, which is why it's manual rather than a UI element.

Comment 4 by d...@chromium.org, Jun 23 2017

 RE #2, s/simpler/faster. One of the largest rendering speed increases that we got was by rendering logs as lengthy blocks of "\n"-delimited text instead of individual elements per line. However, to interpolate metadata elements in between lines, we need to have each line be an element, regressing this performance boost.

iannucci@ suggested a dynamic mouseover/highlight thing where you could highlight text and a status box would pop up with metadata (including timestamps) about the text. That would be achievable in theory without adding extra elements (could store a text offset to metadata mapping), but would take a bit of work to integrate. I do like this idea though if someone wants to make it happen!
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 25 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
Owner: hinoka@chromium.org
Status: Fixed (was: Available)
We have timestamps now.  How's it look?

Sign in to add a comment