New issue
Advanced search Search tips

Issue 736159 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

network_certificate_handler.cc GetCertificate function mixes issuer and subject data

Project Member Reported by mattm@chromium.org, Jun 23 2017

Issue description

chromeos/network/network_certificate_handler.cc has this code:
28	  std::string alt_text;
29	  if (!cert.subject().organization_names.empty())
30	    alt_text = cert.subject().organization_names[0];
31	  if (alt_text.empty())
32	    alt_text = cert.subject().GetDisplayName();
33	  result.issued_by =
34	      certificate::GetIssuerCommonName(cert.os_cert_handle(), alt_text);

data from the certificate subject is being used as the alt text if the issuer commonName is empty. I guess that should be issuer() in the above code?
 

Comment 1 by mattm@chromium.org, Jun 23 2017

Noticed the same thing in chrome/browser/chromeos/options/cert_library.cc GetDisplayString function too.

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7

commit 0d0c142a92ce08a4a205aeaa8e218e30915b6ab7
Author: Matt Mueller <mattm@chromium.org>
Date: Thu Sep 07 18:08:38 2017

Make ChromeOS certificate code use NSS types directly.

Bug:  671420 ,  736159 
Change-Id: Ic480cf5dedc644294b4f11737f3f151243febce6
Reviewed-on: https://chromium-review.googlesource.com/621489
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500334}
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chrome/browser/certificate_manager_model.cc
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chrome/browser/chromeos/options/cert_library.cc
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chrome/browser/chromeos/options/cert_library.h
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chromeos/cert_loader.cc
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chromeos/cert_loader.h
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chromeos/cert_loader_unittest.cc
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chromeos/network/auto_connect_handler_unittest.cc
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chromeos/network/certificate_helper.cc
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chromeos/network/certificate_helper.h
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chromeos/network/client_cert_resolver.cc
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chromeos/network/client_cert_resolver.h
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chromeos/network/client_cert_resolver_unittest.cc
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chromeos/network/network_cert_migrator.cc
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chromeos/network/network_cert_migrator.h
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chromeos/network/network_cert_migrator_unittest.cc
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chromeos/network/network_certificate_handler.cc
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chromeos/network/network_certificate_handler.h
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chromeos/network/network_connection_handler_impl.cc
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chromeos/network/network_connection_handler_impl.h
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/chromeos/network/network_connection_handler_impl_unittest.cc
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/net/cert/x509_util_nss.cc
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/net/cert/x509_util_nss.h
[modify] https://crrev.com/0d0c142a92ce08a4a205aeaa8e218e30915b6ab7/net/cert/x509_util_nss_unittest.cc

Comment 3 by mattm@chromium.org, Sep 7 2017

Status: Fixed (was: Untriaged)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment